mirror of
				https://github.com/go-gitea/gitea.git
				synced 2025-10-29 10:57:44 +09:00 
			
		
		
		
	The MinIO client isn't redirecting to the correct AWS endpoint if a non-default data center is used. In my use case I created an AWS bucket at `eu-central-1` region. Because of the missing region initialization of the client the default `us-east-1` API endpoint is used returning a `301 Moved Permanently` response that's not handled properly by MinIO client. This in return aborts using S3 storage on AWS as the `BucketExists()` call will fail with the http moved error. MinIO client trace shows the issue: ```text ---------START-HTTP--------- HEAD / HTTP/1.1 Host: xxxxxxxxxxx-prod-gitea-data.s3.dualstack.us-east-1.amazonaws.com User-Agent: MinIO (windows; amd64) minio-go/v7.0.61 Authorization: AWS4-HMAC-SHA256 Credential=**REDACTED**/20230809/accesspoint.eu-central-1/s3/aws4_request, SignedHeaders=host;x-amz-content-sha256;x-amz-date, Signature=**REDACTED** X-Amz-Content-Sha256: e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855 X-Amz-Date: 20230809T141143Z HTTP/1.1 301 Moved Permanently Connection: close Content-Type: application/xml Date: Wed, 09 Aug 2023 14:11:43 GMT Server: AmazonS3 X-Amz-Bucket-Region: eu-central-1 X-Amz-Id-2: UK7wfeYi0HcTcytNvQ3wTAZ5ZP1mOSMnvRZ9Fz4xXzeNsS47NB/KfFx2unFxo3L7XckHpMNPPVo= X-Amz-Request-Id: S1V2MJV8SZ11GEVN ---------END-HTTP--------- ``` Co-authored-by: Heiko Besemann <heiko.besemann@qbeyond.de>
		
			
				
	
	
		
			244 lines
		
	
	
		
			6.2 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			244 lines
		
	
	
		
			6.2 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2020 The Gitea Authors. All rights reserved.
 | |
| // SPDX-License-Identifier: MIT
 | |
| 
 | |
| package storage
 | |
| 
 | |
| import (
 | |
| 	"context"
 | |
| 	"crypto/tls"
 | |
| 	"fmt"
 | |
| 	"io"
 | |
| 	"net/http"
 | |
| 	"net/url"
 | |
| 	"os"
 | |
| 	"path"
 | |
| 	"strings"
 | |
| 	"time"
 | |
| 
 | |
| 	"code.gitea.io/gitea/modules/log"
 | |
| 	"code.gitea.io/gitea/modules/setting"
 | |
| 	"code.gitea.io/gitea/modules/util"
 | |
| 
 | |
| 	"github.com/minio/minio-go/v7"
 | |
| 	"github.com/minio/minio-go/v7/pkg/credentials"
 | |
| )
 | |
| 
 | |
| var (
 | |
| 	_ ObjectStorage = &MinioStorage{}
 | |
| 
 | |
| 	quoteEscaper = strings.NewReplacer("\\", "\\\\", `"`, "\\\"")
 | |
| )
 | |
| 
 | |
| type minioObject struct {
 | |
| 	*minio.Object
 | |
| }
 | |
| 
 | |
| func (m *minioObject) Stat() (os.FileInfo, error) {
 | |
| 	oi, err := m.Object.Stat()
 | |
| 	if err != nil {
 | |
| 		return nil, convertMinioErr(err)
 | |
| 	}
 | |
| 
 | |
| 	return &minioFileInfo{oi}, nil
 | |
| }
 | |
| 
 | |
| // MinioStorage returns a minio bucket storage
 | |
| type MinioStorage struct {
 | |
| 	cfg      *setting.MinioStorageConfig
 | |
| 	ctx      context.Context
 | |
| 	client   *minio.Client
 | |
| 	bucket   string
 | |
| 	basePath string
 | |
| }
 | |
| 
 | |
| func convertMinioErr(err error) error {
 | |
| 	if err == nil {
 | |
| 		return nil
 | |
| 	}
 | |
| 	errResp, ok := err.(minio.ErrorResponse)
 | |
| 	if !ok {
 | |
| 		return err
 | |
| 	}
 | |
| 
 | |
| 	// Convert two responses to standard analogues
 | |
| 	switch errResp.Code {
 | |
| 	case "NoSuchKey":
 | |
| 		return os.ErrNotExist
 | |
| 	case "AccessDenied":
 | |
| 		return os.ErrPermission
 | |
| 	}
 | |
| 
 | |
| 	return err
 | |
| }
 | |
| 
 | |
| // NewMinioStorage returns a minio storage
 | |
| func NewMinioStorage(ctx context.Context, cfg *setting.Storage) (ObjectStorage, error) {
 | |
| 	config := cfg.MinioConfig
 | |
| 	if config.ChecksumAlgorithm != "" && config.ChecksumAlgorithm != "default" && config.ChecksumAlgorithm != "md5" {
 | |
| 		return nil, fmt.Errorf("invalid minio checksum algorithm: %s", config.ChecksumAlgorithm)
 | |
| 	}
 | |
| 
 | |
| 	log.Info("Creating Minio storage at %s:%s with base path %s", config.Endpoint, config.Bucket, config.BasePath)
 | |
| 
 | |
| 	minioClient, err := minio.New(config.Endpoint, &minio.Options{
 | |
| 		Creds:     credentials.NewStaticV4(config.AccessKeyID, config.SecretAccessKey, ""),
 | |
| 		Secure:    config.UseSSL,
 | |
| 		Transport: &http.Transport{TLSClientConfig: &tls.Config{InsecureSkipVerify: config.InsecureSkipVerify}},
 | |
| 		Region:    config.Location,
 | |
| 	})
 | |
| 	if err != nil {
 | |
| 		return nil, convertMinioErr(err)
 | |
| 	}
 | |
| 
 | |
| 	if err := minioClient.MakeBucket(ctx, config.Bucket, minio.MakeBucketOptions{
 | |
| 		Region: config.Location,
 | |
| 	}); err != nil {
 | |
| 		// Check to see if we already own this bucket (which happens if you run this twice)
 | |
| 		exists, errBucketExists := minioClient.BucketExists(ctx, config.Bucket)
 | |
| 		if !exists || errBucketExists != nil {
 | |
| 			return nil, convertMinioErr(err)
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	return &MinioStorage{
 | |
| 		cfg:      &config,
 | |
| 		ctx:      ctx,
 | |
| 		client:   minioClient,
 | |
| 		bucket:   config.Bucket,
 | |
| 		basePath: config.BasePath,
 | |
| 	}, nil
 | |
| }
 | |
| 
 | |
| func (m *MinioStorage) buildMinioPath(p string) string {
 | |
| 	p = util.PathJoinRelX(m.basePath, p)
 | |
| 	if p == "." {
 | |
| 		p = "" // minio doesn't use dot as relative path
 | |
| 	}
 | |
| 	return p
 | |
| }
 | |
| 
 | |
| // Open opens a file
 | |
| func (m *MinioStorage) Open(path string) (Object, error) {
 | |
| 	opts := minio.GetObjectOptions{}
 | |
| 	object, err := m.client.GetObject(m.ctx, m.bucket, m.buildMinioPath(path), opts)
 | |
| 	if err != nil {
 | |
| 		return nil, convertMinioErr(err)
 | |
| 	}
 | |
| 	return &minioObject{object}, nil
 | |
| }
 | |
| 
 | |
| // Save saves a file to minio
 | |
| func (m *MinioStorage) Save(path string, r io.Reader, size int64) (int64, error) {
 | |
| 	uploadInfo, err := m.client.PutObject(
 | |
| 		m.ctx,
 | |
| 		m.bucket,
 | |
| 		m.buildMinioPath(path),
 | |
| 		r,
 | |
| 		size,
 | |
| 		minio.PutObjectOptions{
 | |
| 			ContentType: "application/octet-stream",
 | |
| 			// some storages like:
 | |
| 			// * https://developers.cloudflare.com/r2/api/s3/api/
 | |
| 			// * https://www.backblaze.com/b2/docs/s3_compatible_api.html
 | |
| 			// do not support "x-amz-checksum-algorithm" header, so use legacy MD5 checksum
 | |
| 			SendContentMd5: m.cfg.ChecksumAlgorithm == "md5",
 | |
| 		},
 | |
| 	)
 | |
| 	if err != nil {
 | |
| 		return 0, convertMinioErr(err)
 | |
| 	}
 | |
| 	return uploadInfo.Size, nil
 | |
| }
 | |
| 
 | |
| type minioFileInfo struct {
 | |
| 	minio.ObjectInfo
 | |
| }
 | |
| 
 | |
| func (m minioFileInfo) Name() string {
 | |
| 	return path.Base(m.ObjectInfo.Key)
 | |
| }
 | |
| 
 | |
| func (m minioFileInfo) Size() int64 {
 | |
| 	return m.ObjectInfo.Size
 | |
| }
 | |
| 
 | |
| func (m minioFileInfo) ModTime() time.Time {
 | |
| 	return m.LastModified
 | |
| }
 | |
| 
 | |
| func (m minioFileInfo) IsDir() bool {
 | |
| 	return strings.HasSuffix(m.ObjectInfo.Key, "/")
 | |
| }
 | |
| 
 | |
| func (m minioFileInfo) Mode() os.FileMode {
 | |
| 	return os.ModePerm
 | |
| }
 | |
| 
 | |
| func (m minioFileInfo) Sys() any {
 | |
| 	return nil
 | |
| }
 | |
| 
 | |
| // Stat returns the stat information of the object
 | |
| func (m *MinioStorage) Stat(path string) (os.FileInfo, error) {
 | |
| 	info, err := m.client.StatObject(
 | |
| 		m.ctx,
 | |
| 		m.bucket,
 | |
| 		m.buildMinioPath(path),
 | |
| 		minio.StatObjectOptions{},
 | |
| 	)
 | |
| 	if err != nil {
 | |
| 		return nil, convertMinioErr(err)
 | |
| 	}
 | |
| 	return &minioFileInfo{info}, nil
 | |
| }
 | |
| 
 | |
| // Delete delete a file
 | |
| func (m *MinioStorage) Delete(path string) error {
 | |
| 	err := m.client.RemoveObject(m.ctx, m.bucket, m.buildMinioPath(path), minio.RemoveObjectOptions{})
 | |
| 
 | |
| 	return convertMinioErr(err)
 | |
| }
 | |
| 
 | |
| // URL gets the redirect URL to a file. The presigned link is valid for 5 minutes.
 | |
| func (m *MinioStorage) URL(path, name string) (*url.URL, error) {
 | |
| 	reqParams := make(url.Values)
 | |
| 	// TODO it may be good to embed images with 'inline' like ServeData does, but we don't want to have to read the file, do we?
 | |
| 	reqParams.Set("response-content-disposition", "attachment; filename=\""+quoteEscaper.Replace(name)+"\"")
 | |
| 	u, err := m.client.PresignedGetObject(m.ctx, m.bucket, m.buildMinioPath(path), 5*time.Minute, reqParams)
 | |
| 	return u, convertMinioErr(err)
 | |
| }
 | |
| 
 | |
| // IterateObjects iterates across the objects in the miniostorage
 | |
| func (m *MinioStorage) IterateObjects(dirName string, fn func(path string, obj Object) error) error {
 | |
| 	opts := minio.GetObjectOptions{}
 | |
| 	lobjectCtx, cancel := context.WithCancel(m.ctx)
 | |
| 	defer cancel()
 | |
| 
 | |
| 	basePath := m.basePath
 | |
| 	if dirName != "" {
 | |
| 		// ending slash is required for avoiding matching like "foo/" and "foobar/" with prefix "foo"
 | |
| 		basePath = m.buildMinioPath(dirName) + "/"
 | |
| 	}
 | |
| 
 | |
| 	for mObjInfo := range m.client.ListObjects(lobjectCtx, m.bucket, minio.ListObjectsOptions{
 | |
| 		Prefix:    basePath,
 | |
| 		Recursive: true,
 | |
| 	}) {
 | |
| 		object, err := m.client.GetObject(lobjectCtx, m.bucket, mObjInfo.Key, opts)
 | |
| 		if err != nil {
 | |
| 			return convertMinioErr(err)
 | |
| 		}
 | |
| 		if err := func(object *minio.Object, fn func(path string, obj Object) error) error {
 | |
| 			defer object.Close()
 | |
| 			return fn(strings.TrimPrefix(mObjInfo.Key, m.basePath), &minioObject{object})
 | |
| 		}(object, fn); err != nil {
 | |
| 			return convertMinioErr(err)
 | |
| 		}
 | |
| 	}
 | |
| 	return nil
 | |
| }
 | |
| 
 | |
| func init() {
 | |
| 	RegisterStorageType(setting.MinioStorageType, NewMinioStorage)
 | |
| }
 |