mirror of
https://github.com/go-gitea/gitea.git
synced 2026-10-01 20:59:45 +09:00
JerryLien
f365a6b9c8
On a repository's Actions tab, runs are sorted newest first on initial page load. After the first auto refresh (added in #38329, every 3 seconds while runs are active and every 12 seconds otherwise), the same runs may appear in a different order and move again as their status changes. Example with four runs (Gitea 28.0.0, SQLite): ``` page load: #10 success, #9 failure, #8 success, #7 running after refresh: #8 success, #10 success, #9 failure, #7 running ``` To reproduce, open the Actions tab of a repository with runs in different statuses and wait for an auto refresh. On SQLite, the runs may be regrouped by status, with each group ordered oldest first. `preparePartialRefreshRuns` reloads the runs currently shown on the page using `GetRunsByRepoAndID`. That query has no `ORDER BY`, while the initial page load uses `FindRunOptions.ToOrders` and sorts by index descending. With SQLite, the query planner used the `(repo_id, status)` index, so the returned row order differed from the original page order. Since the query has no explicit ordering, this behavior is database-dependent. I have not tested MySQL or PostgreSQL. This change orders `GetRunsByRepoAndID` by index descending, the same order `FindRunOptions.ToOrders` uses for the initial page load. The refresh only reloads the runs already on the page, so they come back in the original order, with or without filters and on any page. The other caller of `GetRunsByRepoAndID`, run approval, does not depend on result ordering. Testing: - Added `TestPreparePartialRefreshRunsKeepsRequestedOrder`. Without the fix, runs 794, 793, 792, 791 are returned as 791, 792, 794, 793; with the fix, the test passes. - `go test` passes for `./routers/web/repo/actions/`, `./models/actions/` and `./services/actions/`. - `go vet` and `golangci-lint v2.13.2` pass for the changed packages. - Manually tested by building Gitea 28.0.0 with this patch and running it on our SQLite instance. The runs list keeps its newest-first order across auto refreshes. The official 28.0.0 binary reproduces the reordering. AI-assisted: drafted with Claude Code (claude-opus-5-5), reviewed by me. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>