mirror of
				https://github.com/go-gitea/gitea.git
				synced 2025-11-03 08:02:36 +09:00 
			
		
		
		
	Backport #17034 The rollback functionality in services/repository/repository.go:ForkRepository is incorrect and could lead to a deadlock as it uses DeleteRepository to delete the rolled-back repository - a function which creates its own transaction. This PR adjusts the rollback function to only use RemoveAll as any database changes will be automatically rolled-back. It also handles panics and adjusts the Close within WithTx to ensure that if there is a panic the session will always be closed. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
		
			
				
	
	
		
			166 lines
		
	
	
		
			4.5 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			166 lines
		
	
	
		
			4.5 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
// Copyright 2019 The Gitea Authors. All rights reserved.
 | 
						|
// Use of this source code is governed by a MIT-style
 | 
						|
// license that can be found in the LICENSE file.
 | 
						|
 | 
						|
package repository
 | 
						|
 | 
						|
import (
 | 
						|
	"fmt"
 | 
						|
	"strings"
 | 
						|
	"time"
 | 
						|
 | 
						|
	"code.gitea.io/gitea/models"
 | 
						|
	"code.gitea.io/gitea/modules/git"
 | 
						|
	"code.gitea.io/gitea/modules/log"
 | 
						|
	"code.gitea.io/gitea/modules/structs"
 | 
						|
	"code.gitea.io/gitea/modules/util"
 | 
						|
)
 | 
						|
 | 
						|
// ForkRepository forks a repository
 | 
						|
func ForkRepository(doer, owner *models.User, oldRepo *models.Repository, name, desc string) (_ *models.Repository, err error) {
 | 
						|
	forkedRepo, err := oldRepo.GetUserFork(owner.ID)
 | 
						|
	if err != nil {
 | 
						|
		return nil, err
 | 
						|
	}
 | 
						|
	if forkedRepo != nil {
 | 
						|
		return nil, models.ErrForkAlreadyExist{
 | 
						|
			Uname:    owner.Name,
 | 
						|
			RepoName: oldRepo.FullName(),
 | 
						|
			ForkName: forkedRepo.FullName(),
 | 
						|
		}
 | 
						|
	}
 | 
						|
 | 
						|
	repo := &models.Repository{
 | 
						|
		OwnerID:       owner.ID,
 | 
						|
		Owner:         owner,
 | 
						|
		OwnerName:     owner.Name,
 | 
						|
		Name:          name,
 | 
						|
		LowerName:     strings.ToLower(name),
 | 
						|
		Description:   desc,
 | 
						|
		DefaultBranch: oldRepo.DefaultBranch,
 | 
						|
		IsPrivate:     oldRepo.IsPrivate || oldRepo.Owner.Visibility == structs.VisibleTypePrivate,
 | 
						|
		IsEmpty:       oldRepo.IsEmpty,
 | 
						|
		IsFork:        true,
 | 
						|
		ForkID:        oldRepo.ID,
 | 
						|
	}
 | 
						|
 | 
						|
	oldRepoPath := oldRepo.RepoPath()
 | 
						|
 | 
						|
	needsRollback := false
 | 
						|
	rollbackFn := func() {
 | 
						|
		if !needsRollback {
 | 
						|
			return
 | 
						|
		}
 | 
						|
 | 
						|
		repoPath := models.RepoPath(owner.Name, repo.Name)
 | 
						|
 | 
						|
		if exists, _ := util.IsExist(repoPath); !exists {
 | 
						|
			return
 | 
						|
		}
 | 
						|
 | 
						|
		// As the transaction will be failed and hence database changes will be destroyed we only need
 | 
						|
		// to delete the related repository on the filesystem
 | 
						|
		if errDelete := util.RemoveAll(repoPath); errDelete != nil {
 | 
						|
			log.Error("Failed to remove fork repo")
 | 
						|
		}
 | 
						|
	}
 | 
						|
 | 
						|
	needsRollbackInPanic := true
 | 
						|
	defer func() {
 | 
						|
		panicErr := recover()
 | 
						|
		if panicErr == nil {
 | 
						|
			return
 | 
						|
		}
 | 
						|
 | 
						|
		if needsRollbackInPanic {
 | 
						|
			rollbackFn()
 | 
						|
		}
 | 
						|
		panic(panicErr)
 | 
						|
	}()
 | 
						|
 | 
						|
	err = models.WithTx(func(ctx models.DBContext) error {
 | 
						|
		if err = models.CreateRepository(ctx, doer, owner, repo, false); err != nil {
 | 
						|
			return err
 | 
						|
		}
 | 
						|
 | 
						|
		if err = models.IncrementRepoForkNum(ctx, oldRepo.ID); err != nil {
 | 
						|
			return err
 | 
						|
		}
 | 
						|
 | 
						|
		// copy lfs files failure should not be ignored
 | 
						|
		if err = models.CopyLFS(ctx, repo, oldRepo); err != nil {
 | 
						|
			return err
 | 
						|
		}
 | 
						|
 | 
						|
		needsRollback = true
 | 
						|
 | 
						|
		repoPath := models.RepoPath(owner.Name, repo.Name)
 | 
						|
		if stdout, err := git.NewCommand(
 | 
						|
			"clone", "--bare", oldRepoPath, repoPath).
 | 
						|
			SetDescription(fmt.Sprintf("ForkRepository(git clone): %s to %s", oldRepo.FullName(), repo.FullName())).
 | 
						|
			RunInDirTimeout(10*time.Minute, ""); err != nil {
 | 
						|
			log.Error("Fork Repository (git clone) Failed for %v (from %v):\nStdout: %s\nError: %v", repo, oldRepo, stdout, err)
 | 
						|
			return fmt.Errorf("git clone: %v", err)
 | 
						|
		}
 | 
						|
 | 
						|
		if stdout, err := git.NewCommand("update-server-info").
 | 
						|
			SetDescription(fmt.Sprintf("ForkRepository(git update-server-info): %s", repo.FullName())).
 | 
						|
			RunInDir(repoPath); err != nil {
 | 
						|
			log.Error("Fork Repository (git update-server-info) failed for %v:\nStdout: %s\nError: %v", repo, stdout, err)
 | 
						|
			return fmt.Errorf("git update-server-info: %v", err)
 | 
						|
		}
 | 
						|
 | 
						|
		if err = createDelegateHooks(repoPath); err != nil {
 | 
						|
			return fmt.Errorf("createDelegateHooks: %v", err)
 | 
						|
		}
 | 
						|
		return nil
 | 
						|
	})
 | 
						|
	needsRollbackInPanic = false
 | 
						|
	if err != nil {
 | 
						|
		rollbackFn()
 | 
						|
		return nil, err
 | 
						|
	}
 | 
						|
 | 
						|
	// even if below operations failed, it could be ignored. And they will be retried
 | 
						|
	ctx := models.DefaultDBContext()
 | 
						|
	if err := repo.UpdateSize(ctx); err != nil {
 | 
						|
		log.Error("Failed to update size for repository: %v", err)
 | 
						|
	}
 | 
						|
	if err := models.CopyLanguageStat(oldRepo, repo); err != nil {
 | 
						|
		log.Error("Copy language stat from oldRepo failed")
 | 
						|
	}
 | 
						|
 | 
						|
	return repo, nil
 | 
						|
}
 | 
						|
 | 
						|
// ConvertForkToNormalRepository convert the provided repo from a forked repo to normal repo
 | 
						|
func ConvertForkToNormalRepository(repo *models.Repository) error {
 | 
						|
	err := models.WithTx(func(ctx models.DBContext) error {
 | 
						|
		repo, err := models.GetRepositoryByIDCtx(ctx, repo.ID)
 | 
						|
		if err != nil {
 | 
						|
			return err
 | 
						|
		}
 | 
						|
 | 
						|
		if !repo.IsFork {
 | 
						|
			return nil
 | 
						|
		}
 | 
						|
 | 
						|
		if err := models.DecrementRepoForkNum(ctx, repo.ForkID); err != nil {
 | 
						|
			log.Error("Unable to decrement repo fork num for old root repo %d of repository %-v whilst converting from fork. Error: %v", repo.ForkID, repo, err)
 | 
						|
			return err
 | 
						|
		}
 | 
						|
 | 
						|
		repo.IsFork = false
 | 
						|
		repo.ForkID = 0
 | 
						|
 | 
						|
		if err := models.UpdateRepositoryCtx(ctx, repo, false); err != nil {
 | 
						|
			log.Error("Unable to update repository %-v whilst converting from fork. Error: %v", repo, err)
 | 
						|
			return err
 | 
						|
		}
 | 
						|
 | 
						|
		return nil
 | 
						|
	})
 | 
						|
 | 
						|
	return err
 | 
						|
}
 |