public/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-10-09 08:10:06 +09:00
Code Issues Packages Projects Releases Wiki Activity

db: look up API keys by explicit primary key, not struct condition

Browse Source 
GetAPIKeyByID(0) returned the first key instead of not-found.
This commit is contained in:
Kristoffer Dalby
2026-06-05 15:06:10 +00:00
committed by Kristoffer Dalby
parent 84c99023e5
commit 10696fa634
2 changed files with 32 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
hscontrol/db/api_key.go
+4 -1
View File
@@ -109,7 +109,10 @@ func (hsdb *HSDatabase) GetAPIKey(prefix string) (*types.APIKey, error) {
// GetAPIKeyByID returns a [types.APIKey] for a given id.
func (hsdb *HSDatabase) GetAPIKeyByID(id uint64) (*types.APIKey, error) {
key := types.APIKey{}
if result := hsdb.DB.Find(&types.APIKey{ID: id}).First(&key); result.Error != nil {
// Query on an explicit primary-key clause: a struct condition would drop a
// zero-valued ID, making the lookup unconditional and returning the first
// row instead of not-found.
if result := hsdb.DB.First(&key, "id = ?", id); result.Error != nil {
return nil, result.Error
}