From 1867213b69badaa6ebe3c9574de69acf2bdecb30 Mon Sep 17 00:00:00 2001 From: Kristoffer Dalby Date: Fri, 26 Jun 2026 13:16:36 +0000 Subject: [PATCH] capver: order TailscaleLatestMajorMinor versions with cmpver Lexical sort placed v1.100 before v1.98; cmpver compares numerically. --- hscontrol/capver/capver.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hscontrol/capver/capver.go b/hscontrol/capver/capver.go index 6ff102b1..a4c535e8 100644 --- a/hscontrol/capver/capver.go +++ b/hscontrol/capver/capver.go @@ -5,10 +5,10 @@ package capver import ( "maps" "slices" - "sort" "strings" "tailscale.com/tailcfg" + "tailscale.com/util/cmpver" "tailscale.com/util/set" ) @@ -74,7 +74,9 @@ func TailscaleLatestMajorMinor(n int, stripV bool) []string { } majorSl := majors.Slice() - sort.Strings(majorSl) + // cmpver orders versions numerically, so v1.100 sorts after v1.98 rather than + // lexically before it. + slices.SortFunc(majorSl, cmpver.Compare) if n > len(majorSl) { return majorSl