mirror of
https://github.com/juanfont/headscale.git
synced 2026-10-26 16:26:50 +09:00
state: return ErrGivenNameInvalid for invalid node rename
RenameNode wrapped the raw dnsname error, so the v2 API mapped it to a 500. Emit the sentinel so an invalid name surfaces as a 400.
This commit is contained in:
1 parent
3d811f29a6
commit
2ff342764f
1 file changed
+1
-1
@@ -1034,7 +1034,7 @@ func (s *State) SetApprovedRoutes(nodeID types.NodeID, routes []netip.Prefix) (t
|
||||
func (s *State) RenameNode(nodeID types.NodeID, newName string) (types.NodeView, change.Change, error) {
|
||||
err := dnsname.ValidLabel(newName)
|
||||
if err != nil {
|
||||
return types.NodeView{}, change.Change{}, fmt.Errorf("renaming node: %w", err)
|
||||
return types.NodeView{}, change.Change{}, fmt.Errorf("%w: %w", ErrGivenNameInvalid, err)
|
||||
}
|
||||
|
||||
view, err := s.nodeStore.SetGivenName(nodeID, newName)
|
||||
|
||||
Reference in new issue
Block a user