public/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-09-19 23:04:53 +09:00
Code Issues Packages Projects Releases Wiki Activity

state: return ErrGivenNameInvalid for invalid node rename

Browse Source 
RenameNode wrapped the raw dnsname error, so the v2 API mapped it to a
500. Emit the sentinel so an invalid name surfaces as a 400.
This commit is contained in:
Kristoffer Dalby
2026-06-20 20:16:51 +00:00
parent 3d811f29a6
commit 2ff342764f
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
hscontrol/state/state.go
+1 -1
View File
@@ -1034,7 +1034,7 @@ func (s *State) SetApprovedRoutes(nodeID types.NodeID, routes []netip.Prefix) (t
func (s *State) RenameNode(nodeID types.NodeID, newName string) (types.NodeView, change.Change, error) { func (s *State) RenameNode(nodeID types.NodeID, newName string) (types.NodeView, change.Change, error) {
err := dnsname.ValidLabel(newName) err := dnsname.ValidLabel(newName)
if err != nil { if err != nil {
return types.NodeView{}, change.Change{}, fmt.Errorf("renaming node: %w", err) return types.NodeView{}, change.Change{}, fmt.Errorf("%w: %w", ErrGivenNameInvalid, err)
} }
view, err := s.nodeStore.SetGivenName(nodeID, newName) view, err := s.nodeStore.SetGivenName(nodeID, newName)