From 30d10640eabe3a75ce0686c6bb98bc5edd3e516a Mon Sep 17 00:00:00 2001 From: Kristoffer Dalby Date: Fri, 4 Sep 2026 14:53:05 +0000 Subject: [PATCH] tools/bump: reword the verify failure "invariant" is not language this repository uses. --- tools/bump/generate.go | 2 +- tools/bump/verify.go | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/tools/bump/generate.go b/tools/bump/generate.go index 82d0e049..6eafad95 100644 --- a/tools/bump/generate.go +++ b/tools/bump/generate.go @@ -45,7 +45,7 @@ func oapiVersion(r *repo) (string, error) { return m[1], nil } -// generateClients mirrors the Makefile's client recipe. The bot does not shell +// generateClients repeats the Makefile's client recipe. The bot does not shell // out to make, but check-generated.yml still runs the real target and diffs, so // any drift between the two surfaces on the bot's own pull request. func generateClients(ctx context.Context, r *repo) error { diff --git a/tools/bump/verify.go b/tools/bump/verify.go index 74324cdc..81df23fc 100644 --- a/tools/bump/verify.go +++ b/tools/bump/verify.go @@ -10,14 +10,14 @@ import ( "golang.org/x/mod/semver" ) -var errInvariants = errors.New("version pins are inconsistent") +var errPinsDisagree = errors.New("version pins disagree") -// finding is one violated invariant, phrased so the fix is obvious. +// finding is one disagreement, phrased so the fix is obvious. type finding string -// cmdVerify asserts the pins agree with each other and with their upstreams. It -// is deliberately separate from run: the same checks catch a hand-written -// commit that breaks a lockstep rule, not just a bad automated one. +// cmdVerify checks that the pins agree with each other and with their +// upstreams. It is deliberately separate from run: the same checks catch a +// hand-written commit that breaks a lockstep rule, not just a bad automated one. func cmdVerify(ctx context.Context) error { r, err := openRepo(ctx) if err != nil { @@ -41,7 +41,7 @@ func cmdVerify(ctx context.Context) error { log.Printf("- %s", f) } - return fmt.Errorf("%w: %d finding(s)", errInvariants, len(findings)) + return fmt.Errorf("%w: %d finding(s)", errPinsDisagree, len(findings)) } func verifyLockstep(ctx context.Context, r *repo) []finding {