From 507046bb7d90ca2dafa8b436575173bab2393b22 Mon Sep 17 00:00:00 2001 From: Kristoffer Dalby Date: Fri, 4 Sep 2026 14:11:15 +0000 Subject: [PATCH] tools/capver: exit non-zero on failure A failed tag fetch left the generated files untouched, which is indistinguishable from no drift: check-generated passed on stale output. --- tools/capver/main.go | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/capver/main.go b/tools/capver/main.go index e8e7a9af..73afbf09 100644 --- a/tools/capver/main.go +++ b/tools/capver/main.go @@ -458,8 +458,10 @@ func main() { versions, err := getCapabilityVersions(ctx) if err != nil { - log.Println("Error:", err) - return + // Fatal, not a soft return: leaving the generated files untouched is + // indistinguishable from "no drift", so check-generated would pass on + // stale output and an automated bump could not tell the two apart. + log.Fatalln("Error:", err) } // Calculate the minimum supported capability version @@ -467,14 +469,12 @@ func main() { err = writeCapabilityVersionsToFile(versions, minSupportedCapVer) if err != nil { - log.Println("Error writing to file:", err) - return + log.Fatalln("Error writing to file:", err) } err = writeTestDataFile(versions, minSupportedCapVer) if err != nil { - log.Println("Error writing test data file:", err) - return + log.Fatalln("Error writing test data file:", err) } log.Println("Capability versions written to", outputFile)