policy/v2: align SSH rule validation with Tailscale

Browse Source

Trim whitespace on action, users, src, dst; reject empty/wildcard users; reject empty acceptEnv; reject negative and over-max checkPeriod; reject hosts-table aliases as SSH dst; reject non-ASCII tag names; tolerate tag-owner cycles; match group-nesting wording.

...

This commit is contained in:

Kristoffer Dalby committed 2026-05-13 21:10:13 +02:00

1 parent 4ad200ab73

commit d600090f2c

70 files changed

+1361660 -308

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

hscontrol/policy/v2/testdata/ssh_results/ssh-acceptenv-null.hujson

Vendored

+22349

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-acceptenv-omitted.hujson

Vendored

+22348

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-checkperiod-null.hujson

Vendored

+22343

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-dst-empty-tag.hujson

Vendored

+22330

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-dst-trailing-whitespace.hujson

Vendored

+22348

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-group-nested-cycle.hujson

Vendored

+22109

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-group-nested-three-deep.hujson

Vendored

+22113

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-group-nested-two-deep.hujson

Vendored

+22109

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-hosts-as-dst-multi-host-prefix.hujson

Vendored

+22107

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-hosts-as-dst-single-ip.hujson

Vendored

+22107

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-malformed-acceptenv-bad-glob.hujson

Vendored

+20105

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-malformed-acceptenv-empty.hujson

Vendored

+20082

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-malformed-acceptenv-glob-shapes.hujson

Vendored

+20105

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-malformed-action-deny.hujson

Vendored

+20081

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-malformed-action-empty.hujson

Vendored

+20081

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-malformed-action-missing.hujson

Vendored

+20078

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-malformed-action-mixedcase.hujson

Vendored

+20081

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-malformed-action-uppercase.hujson

Vendored

+20081

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-malformed-action-whitespace.hujson

Vendored

+20104

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-malformed-checkperiod-exact-max.hujson

Vendored

+20099

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-malformed-checkperiod-malformed.hujson

Vendored

+20082

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-malformed-checkperiod-negative.hujson

Vendored

+20082

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-malformed-checkperiod-over-max-by-1s.hujson

Vendored

+20082

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-malformed-checkperiod-too-long.hujson

Vendored

+20082

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-malformed-checkperiod-too-short.hujson

Vendored

+20099

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-malformed-checkperiod-zero.hujson

Vendored

+20099

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-malformed-dst-empty.hujson

Vendored

+20079

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-malformed-dst-missing.hujson

Vendored

+20074

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-malformed-src-empty.hujson

Vendored

+20076

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-malformed-src-missing.hujson

Vendored

+20074

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-malformed-user-autogroup-internet.hujson

Vendored

+20112

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-malformed-user-autogroup-member.hujson

Vendored

+20112

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-malformed-user-autogroup-self.hujson

Vendored

+20104

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-malformed-user-autogroup-tagged.hujson

Vendored

+20112

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-malformed-user-empty.hujson

Vendored

+20081

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-malformed-user-group-prefix.hujson

Vendored

+20105

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-malformed-user-localpart-empty.hujson

Vendored

+20104

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-malformed-user-localpart-multi-glob.hujson

Vendored

+20083

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-malformed-user-localpart-no-at.hujson

Vendored

+20104

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-malformed-user-localpart-no-domain.hujson

Vendored

+20104

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-malformed-user-localpart-no-glob.hujson

Vendored

+20112

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-malformed-user-tag-prefix.hujson

Vendored

+20105

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-malformed-user-whitespace-leading.hujson

Vendored

+20104

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-malformed-user-wildcard.hujson

Vendored

+20081

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-malformed-users-empty-array.hujson

Vendored

+20081

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-malformed-users-missing.hujson

Vendored

+20078

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-malformed-users-mixed-valid-empty.hujson

Vendored

+20081

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-malformed-users-mixed-valid-wildcard.hujson

Vendored

+20081

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-many-tags-as-dst.hujson

Vendored

+22143

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-multi-rule-accept-then-check.hujson

Vendored

+21916

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-multi-rule-check-then-accept.hujson

Vendored

+21916

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-multi-rule-disjoint-srcs.hujson

Vendored

+22146

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-multi-rule-overlap-conflicting-acceptenv.hujson

Vendored

+22152

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-multi-rule-overlap-different-users.hujson

Vendored

+22146

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-multi-src-multi-dst-multi-user.hujson

Vendored

+22146

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-src-autogroup-tagged-no-tagged-nodes.hujson

Vendored

+21944

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-src-empty-group.hujson

Vendored

+22105

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-src-leading-whitespace.hujson

Vendored

+22123

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-tab-in-user.hujson

Vendored

+22123

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-tag-owner-cycle.hujson

Vendored

+22101

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-tag-owner-self-reference.hujson

Vendored

+22101

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-unicode-cyrillic-tag.hujson

Vendored

+21880

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-unicode-emoji-user.hujson

Vendored

+21898

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-unicode-rtl-user.hujson

Vendored

+22123

File diff suppressed because it is too large. Load diff

hscontrol/policy/v2/testdata/ssh_results/ssh-users-null.hujson

Vendored

+22106

File diff suppressed because it is too large. Load diff