Kristoffer Dalby
267ab2f4db
state: treat extra DNS record names as taken node names
2026-10-28 14:42:22 +00:00
Kristoffer Dalby
f271fc482d
state: save the name NodeStore picks for a new node
...
The row is committed before the name UPDATE, so a failed UPDATE still
returns the node and registration arms ephemeral cleanup.
2026-10-28 14:42:22 +00:00
Kristoffer Dalby
9199cc8a06
state: test that a persist racing a delete cannot resurrect the node
...
DeleteNode's early persistMu unlock is safe only while node persists
stay UPDATE-only; say so where the lock is declared.
2026-10-28 14:42:21 +00:00
Kristoffer Dalby
f320fe10e8
mapper: show an expired peer online, without endpoints or DERP
...
A connected expired node shows online to its peers. Neither its map
entry nor endpoint, DERP or disco patches carry the paths to reach it.
2026-10-28 14:42:05 +00:00
Kristoffer Dalby
3a9a1a6a4c
mapper: trim the Hostinfo sent to peers and to the node itself
...
As on Tailscale SaaS, the node's own entry keeps Hostname, RequestTags,
RoutableIPs and Services; peers get Hostname, OS, Services without
peerapi-dns-proxy, SSH host keys and AppConnector, and resend on those.
2026-10-28 14:42:05 +00:00
Kristoffer Dalby
15732cc071
state: apply requested tags on a key login that owns them
...
A requested tag the key's user owns directly, or the key's tags own one
hop away, replaces the key's tags instead of refusing the login.
2026-10-28 14:42:03 +00:00
Kristoffer Dalby
2a96a02d7b
state: auto-approve routes after an admin tag change
...
The new tags may approve announced routes. Approval runs once the policy
manager knows the new owner, as after a registration.
2026-10-28 14:42:03 +00:00
Kristoffer Dalby
e481fe49d3
state: drop auto-approved routes when they are withdrawn
...
Only routes auto-approval alone granted go; approvals from before the
upgrade stay, as do routes an admin set.
2026-10-28 14:42:02 +00:00
Kristoffer Dalby
070fe4c9bd
db, types: add a column for auto-approved routes
...
It starts empty: the current policy cannot tell which earlier approvals
were automatic, so all of them stay as an admin's.
2026-10-28 14:42:02 +00:00
Kristoffer Dalby
3c0f6e8120
state: auto-approve on registration only when the node key rotates
...
Registration runs the approval itself, once the policy manager knows the
node's owner, for a new node key or a change to the announced routes.
2026-10-28 14:42:01 +00:00
Kristoffer Dalby
822c8779a5
auth: store a client's earlier expiry and expire a tagged node at logout
...
A client may bring its expiry forward, which turns expiry on for a node
without one, but still cannot push it back. Logout expires tagged nodes
too.
2026-10-28 14:42:00 +00:00
Kristoffer Dalby
309cfbb342
auth, state: answer an expired node's same-key login with NodeKeyExpired
...
The client then rotates its node key and logs in again, so no key is
judged under the expired one. The machine stays authorised.
2026-10-28 14:41:47 +00:00
Kristoffer Dalby
7625a5ec90
state: forget a node's SSH check approvals when it is expired
2026-10-28 14:41:46 +00:00
Kristoffer Dalby
e43ee22b01
state: honour SSH check approvals only while the source keeps its owner
2026-10-28 14:41:02 +00:00
Kristoffer Dalby
bf1ff1665b
state: let a pre-auth key that is no longer valid only wake its node
...
A login that keeps its node key leaves a live node's expiry alone, even
with a valid key, and a wake-up is not refused for the tags it requests.
2026-10-28 14:40:49 +00:00
Kristoffer Dalby
c1e4c56848
state: serialise registrations presenting an unused single-use key
2026-10-28 14:40:32 +00:00
Kristoffer Dalby
a0893b43ff
state: auto-approve routes in the NodeStore writer, not on reload
...
Registration approval runs on the node the writer replaces. A policy
reload approves nothing, and a map request only when its announced
routes change, so neither re-grants a route an admin revoked.
2026-10-28 14:39:41 +00:00
Kristoffer Dalby
69c69d35e2
state: undo a failed re-registration without reverting newer writes
2026-10-28 14:39:40 +00:00
Kristoffer Dalby
cff67806cb
state: write node rows from the NodeStore under persistMu
2026-10-28 14:39:25 +00:00
Kristoffer Dalby
3cf284917d
state: apply map requests only under the node key that authorised them
2026-10-28 14:38:12 +00:00
Kristoffer Dalby
b36f9d443f
policy: offer exit routes only to viewers whose rules reach the internet
...
Every destination overlaps /0, so any rule offered a peer's exit routes.
They now need a rule to the internet, the test exit-node visibility
uses; via steering defers them to a regular grant only on that test.
2026-10-28 14:38:11 +00:00
Kristoffer Dalby
d648cf6b95
policy, state: log only the routes auto-approval adds
2026-10-28 14:38:08 +00:00
Kristoffer Dalby
619b731c18
types, state: reduce a node's routes against the matchers once
...
Reuse matcher membership and approved subnets across the route list.
Preserve route order and HA co-router visibility.
2026-10-28 14:38:03 +00:00
Kristoffer Dalby
235e6b62c7
state: skip route comparison for writes that leave routes alone
...
Reuse immutable route inputs when classifying NodeStore writes.
Only derive routes when an announcement or approval changes.
2026-10-28 14:37:37 +00:00
Kristoffer Dalby
04cbb8549d
state, policy/v2: stop treating announced-only routes as policy changes
...
Policy evaluation reads only announced-and-approved routes.
Keep publishing Hostinfo updates without rebuilding peer adjacency.
2026-10-28 14:37:30 +00:00
Kristoffer Dalby
6b99ca0ad1
policy/v2, state: elect primaries by oldest control session
...
A router that reconnects joins as a standby; one that kept its session
takes its routes back once available again, as on Tailscale. Both the
global and the via election use it, in place of anti-flap stickiness.
2026-10-28 14:37:29 +00:00
Kristoffer Dalby
afac928e2e
types: add when a node's run of control sessions began
2026-10-28 14:37:28 +00:00
Kristoffer Dalby
97d4310caa
state: keep a prefix mapped when no router is available
...
Peers keep the routes of an offline or expired router, as on Tailscale.
The previous primary keeps the prefix, else the lowest-ID approver;
never one the prober declared unreachable.
2026-10-28 14:37:27 +00:00
Kristoffer Dalby
111ed512fb
policy/v2, state: elect via primaries among online, healthy routers
...
Availability tests expiry itself, not only the online flag.
A health change on a via target now triggers a peer recompute.
2026-10-28 14:37:26 +00:00
Kristoffer Dalby
67b88fe3b2
state: withhold HA probe results only for routers tied to a deferred one
2026-10-28 14:37:25 +00:00
Kristoffer Dalby
95b44713c1
state: keep probing a lone advertiser while it is unhealthy
2026-10-28 14:37:24 +00:00
Kristoffer Dalby
524ccc46aa
db: keep only the current policy
...
Every write inserted a row and nothing deleted one, while every reader
takes only the newest. Writers store and install under one lock, so an
uncommitted insert cannot outlive the newer row that pruned the rest.
2026-10-28 14:37:08 +00:00
Kristoffer Dalby
6c06fcc919
state: install a written policy only after it is stored
...
Writers validated by installing the policy live, so a store failure
left a refused or unstored policy enforced. Validate on a throwaway
manager, store, then reload from the stored row.
2026-10-28 14:37:07 +00:00
Kristoffer Dalby
89b37fde7d
policy/v2: refuse an empty policy
...
SetPolicy returned a nil error for empty input it ignored, so the v1
API stored it as valid. Reload skips only the nil "no policy" case.
2026-10-28 14:37:06 +00:00
Kristoffer Dalby
38613d7217
state: serialise policy reloads
...
Load and install the stored policy as one step, so an older
reload cannot install its document over a newer one.
2026-10-28 14:36:57 +00:00
Kristoffer Dalby
b4e2c0e93f
servertest, state: add node name golden data
...
Labels under taken hostnames, case-only renames, hostname changes, long
hostnames and a Service's name; API, peer and self per step, and State
labels as a restart would load them.
2026-10-28 14:31:40 +00:00
Kristoffer Dalby
9f87fbd4f3
servertest, state: add map delivery golden data
...
A retag through the API, a running peer's DERP, disco, hostname and
port, down and up gaps around policy pushes; peers, filters and frames
per node.
2026-10-28 14:29:34 +00:00
Kristoffer Dalby
38125d1043
db, state: let only the delete that removed a node free its addresses
...
Fixes ANT-2026-NWTIBB02
2026-10-28 14:25:41 +00:00
Kristoffer Dalby
8126f8727a
state: drop registration locks once unused
...
The lock is taken before any credential check, so client-chosen machine
keys grew the map forever. Ref-count entries; delete at zero.
Fixes ANT-2026-ZC18AF82
2026-10-28 14:25:41 +00:00
Kristoffer Dalby
3c277949c7
auth, state: keep announced routes out of pending registrations
...
Routes are the one long list; the first MapRequest reports them.
A relogin keeps the node's own routes until then.
Fixes ANT-2026-RQS7JAPP
2026-10-28 14:25:41 +00:00
Kristoffer Dalby
c87672bcf6
state: bound client reports of nodes loaded at startup
...
Rows stored before the bounds would still fan out unbounded endpoints.
Fixes ANT-2026-RQS7JAPP
Fixes ANT-2026-5B6KE87K
Fixes ANT-2026-KFCFFM34
2026-10-28 14:25:41 +00:00
Kristoffer Dalby
7259ef6edd
hscontrol: refuse a key expiry that cannot be encoded
...
handleRegister, the OIDC auth path and SetNodeExpiry refuse it. Expiries
are stored in UTC, which SQLite can read back, and loaded in UTC, as
PostgreSQL returns the server's zone. The v1 API answers 400.
Fixes ANT-2026-QMCAFJ1Q
2026-10-28 14:25:41 +00:00
Kristoffer Dalby
159deeec41
mapper: skip peers whose key expiry cannot be encoded
...
json.Marshal refuses a year outside [0,9999], so one stored expiry
failed every map with that node. TailNode and key patches send UTC, the
builder drops what fails and the boot scan names the node.
Fixes ANT-2026-QMCAFJ1Q
2026-10-28 14:25:41 +00:00
Kristoffer Dalby
eeb0ef0901
state: give another user's key on a tagged machine a new device
...
Only a key that speaks for a tagged node re-authenticates it: a tagged
key, or one of the user it was tagged from. Another user's key or login
adds that user's own device, or only wakes the node under its node key.
Fixes ANT-2026-AWGRB7O1
2026-10-28 14:25:32 +00:00
Kristoffer Dalby
c262792660
state: need a valid pre-auth key to re-register an expired tagged node
...
Fixes ANT-2026-LYVGXVSW
2026-10-28 14:22:20 +00:00
Kristoffer Dalby
abbec204a2
state: never serve a single address inside the node ranges
...
Such a route names a node, not a subnet: it stays approved and listed
but no viewer gets it. Via inclusions skip the election, so the rule
sits on everything RoutesForPeer returns.
Fixes ANT-2026-MLP8ZR5T
2026-10-28 14:21:03 +00:00
Kristoffer Dalby
cd62031b98
state: stop the auth cache TTL sweeper on Close
...
The expirable LRU ran its sweeper forever, one goroutine per State. Purge
first so pending waiters get ErrRegistrationExpired instead of hanging.
The OIDC state cache is closed at server shutdown for the same reason.
2026-10-23 18:23:53 +02:00
Kristoffer Dalby
51b420865e
state: own request memory before storing nodes
...
A reused RegisterRequest.Hostinfo was written and stored while NodeStore readers cloned it.
2026-10-23 18:23:53 +02:00
Kristoffer Dalby
552356a2ee
state: skip the caller's policy refresh once the writer applied it
...
The writer refreshes the policy manager before publishing its batch, so
the caller's SetNodes with the published snapshot recompiled it back.
2026-10-23 18:23:53 +02:00
Kristoffer Dalby
5d21186f22
state: release persistMu before the NodeStore delete
...
Holding it serialised concurrent deletes into one NodeStore batch and
peer map build each, capping deletion at one batch tick per node.
2026-10-23 18:23:53 +02:00