Commit Graph
1221 Commits
Author SHA1 Message Date
Kristoffer Dalby 5eacf965d8 db, types: add a credentials column for keys a token made
No released version made keys from tokens, so existing rows stay false.
2026-10-28 19:06:06 +00:00
Kristoffer Dalby b26cc46b5b api/v2: show userId on admin-made tagged keys
An admin key's user is recorded as the creator of the tagged keys it
makes. A tagged key re-registers a machine by its tags, whoever made it.
2026-10-28 19:06:06 +00:00
Kristoffer Dalby a4eb791b68 api/v2: return a device name as its FQDN 2026-10-28 19:06:06 +00:00
Kristoffer Dalby f69d2ff2d7 api/v2: refuse an unknown keyType 2026-10-28 19:06:06 +00:00
Kristoffer Dalby 373b1494a9 api/v2: ignore unknown properties in request bodies
Tailscale's API ignores them.
2026-10-28 19:06:06 +00:00
Kristoffer Dalby 6a589a76f5 db: keep at most 1000 access tokens per OAuth client
Minting needs only the client secret, whatever its scopes, and
added one row per mint. Each mint now ends tokens past the newest 1000.
2026-10-28 19:06:06 +00:00
Kristoffer Dalby 69060138c4 api/v2: check the createKey scope before reading the body
createKey has no static scope, so any token got its body parsed
and validated before the handler's scope check.
2026-10-28 19:06:06 +00:00
Kristoffer Dalby 80dc7d388c api/v2: stop echoing request values in error responses
huma sets an unexpected property's value to the whole request object.
A refused policy, or another 400, now carries its reason in message,
and a failed test run one data entry per failing test naming its src.
2026-10-28 19:06:06 +00:00
Kristoffer Dalby fbce433541 api/v2: bound every request body
huma gives RawBody no limit, and validates a whole body before
the handler runs. The token form is parsed before the secret check.
2026-10-28 19:06:06 +00:00
Kristoffer Dalby 7b236fcde0 api/v2: keep a tagged all-scope client's tokens inside its tags
Only an untagged all-scope client may mint tokens for any tag, so a
tagged token may not create one.
2026-10-28 19:06:06 +00:00
Kristoffer Dalby a7fde025e6 debug: refuse requests addressed to unknown host names 2026-10-28 19:06:06 +00:00
Kristoffer Dalby 8a362c0453 types: accept only lowercase hex in auth IDs 2026-10-28 19:06:06 +00:00
Kristoffer Dalby 2616636294 oidc: show requested tags on the registration confirmation page 2026-10-28 19:06:06 +00:00
Kristoffer Dalby 61433293bf oidc: show on the confirmation page whether the device is registered 2026-10-28 19:06:06 +00:00
Kristoffer Dalby b911b9bc1b oidc: approve SSH checks on the confirmation page, not in the callback
Require an explicit click before recording the SSH verdict.
Recheck source ownership on the callback, confirmation page, and POST.
2026-10-28 19:06:06 +00:00
Kristoffer Dalby 3f5f0258d9 policy/v2: match no user for a bare "@" token 2026-10-28 19:06:06 +00:00
Kristoffer Dalby 17415a84cc policy/v2: match no one for an ambiguous user outside policy writes
A change to user identifiers must not block startup or later logins.
Keep policy writes strict; log ambiguous references on load and refresh.
2026-10-28 19:06:06 +00:00
Kristoffer Dalby dc15b793fa policy/v2: prefer the user owning an email over a username match 2026-10-28 19:06:06 +00:00
Kristoffer Dalby b88d80af01 policy/v2: check grant and nodeAttrs user references on write
Validation now refuses every input that reached the SetPolicy compile
failure, so restoring the previous policy there is defensive only.
2026-10-28 19:06:06 +00:00
Kristoffer Dalby f380459ae0 types: reject non-boolean values for boolean settings 2026-10-28 19:06:06 +00:00
Kristoffer Dalby de19c7e01f oidc: send the change from the user update in the callback 2026-10-28 19:06:05 +00:00
Kristoffer Dalby c32865f5cb state: refresh the NodeStore copies of a user in UpdateUser 2026-10-28 19:06:05 +00:00
Kristoffer Dalby 6fbee34af9 types: drop a stored OIDC email the login no longer vouches for 2026-10-28 19:06:05 +00:00
Kristoffer Dalby 2ae1260f39 state: write every user column in UpdateUser 2026-10-28 19:06:05 +00:00
Kristoffer Dalby e31a37a265 oidc: refuse logins whose subject the provider identifier would alter 2026-10-28 19:06:05 +00:00
Kristoffer Dalby a8040b1c7d state: announce a node online only after it was offline
A stream back within the reconnect grace sent peers an online patch,
a router's sent every node a policy response, and a relogin on
unchanged keys sent a key patch; nothing had changed.
2026-10-28 19:06:05 +00:00
Kristoffer Dalby 5c0b617bc7 change: do not echo a node's own report back to it
An endpoint or DERP report came back to the node as a self update;
SaaS sends it to the node's peers only.
2026-10-28 19:06:05 +00:00
Kristoffer Dalby dd0bd18d41 mapper: add device_id to the NextDNS query
SaaS sends the node's stable ID with the other device metadata.
2026-10-28 19:06:05 +00:00
Kristoffer Dalby 5b7bebff08 policy/v2: warn once at load about malformed nextdns attrs
SaaS loads them and its resolver skips them, as headscale does, but the
mapper also logged a warning per node on every DNS build.
2026-10-28 19:06:05 +00:00
Kristoffer Dalby be7891a1eb mapper: test that a hidden peer's policy change still sends filters 2026-10-28 19:06:05 +00:00
Kristoffer Dalby e56de5ca9e state, change: send a deleted node's removal only to its peers
The removal went to every node, also those the policy hid the node from.
The delete now returns the node's peers from the snapshot it replaces.
2026-10-28 19:06:05 +00:00
Kristoffer Dalby baf93d8b2c mapper: stop an older initial map removing peers newer streams hold
AddNode diffed its map against tracking after sending it, when a newer
stream may have recorded its own; it now sends the node a full instead.
2026-10-28 19:06:05 +00:00
Kristoffer Dalby f07a384fe5 mapper: bound how long one node can block a batcher worker
A node that drained slower than it was sent to held the worker for its
whole bundle; once its sends have waited 50ms, the rest waits a tick.
2026-10-28 19:06:05 +00:00
Kristoffer Dalby 90dc1d1caa mapper: send nothing while any stream awaits its initial map
Sent to the ready streams alone, a change counted as delivered and
never reached the new stream; the worker retries it once the map is out.
2026-10-28 19:06:05 +00:00
Kristoffer Dalby 95c3c2e806 mapper: cap concurrent map sessions per node
A node chose how many map streams it held, each pinning a session.
The fifth replaces the oldest; same shape as #3468's mapper commit.
2026-10-28 19:06:05 +00:00
Kristoffer Dalby 1525e7357a change: coalesce policy recomputes that carry an origin node
The recompute render ignores the origin and always carries the node's
own entry, so a burst of tag writes cost every node one per write.
2026-10-28 19:06:05 +00:00
Kristoffer Dalby dfa06e1aac state: say a taken name is already taken 2026-10-28 19:06:05 +00:00
Kristoffer Dalby bf03d4c01b db: succeed on a repeated revoke of an auth key
A repeated v2 DELETE of an auth key now answers 200, as Tailscale does.
2026-10-28 19:06:05 +00:00
Kristoffer Dalby ab6f08ebc9 auth: answer a logout that deletes an ephemeral node as authorised 2026-10-28 19:06:05 +00:00
Kristoffer Dalby c0f974ad7a db, state: keep the ephemeral flag a node was created with
The flag moves from the key to the node, so a login with another key no
longer changes it. A user claiming a tagged node still clears it. v1
nodes carry the flag.
2026-10-28 19:06:05 +00:00
Kristoffer Dalby f00b4f3bd6 db, types: add a nodes column for the ephemeral flag
The migration fills it from the key each node references.
2026-10-28 19:06:05 +00:00
Kristoffer Dalby 600ee410ad db: remove unused RenameNode 2026-10-28 19:06:05 +00:00
Kristoffer Dalby 58ea96d9ff state: bump duplicate node names loaded from the database 2026-10-28 19:06:05 +00:00
Kristoffer Dalby b952522dc2 state: cut a label so its -N suffix fits in 63 bytes 2026-10-28 19:06:05 +00:00
Kristoffer Dalby 09380277ac state: treat extra DNS record names as taken node names 2026-10-28 19:06:05 +00:00
Kristoffer Dalby 40902d57be state: save the name NodeStore picks for a new node
The row is committed before the name UPDATE, so a failed UPDATE still
returns the node and registration arms ephemeral cleanup.
2026-10-28 19:06:05 +00:00
Kristoffer Dalby d48b62096a db, api/v1: revoke rather than delete an ephemeral pre-auth key in use
The v1 list now hides revoked keys, so keys revoked through v2 also drop
out of `headscale preauthkeys list`.
2026-10-28 19:06:05 +00:00
Kristoffer Dalby 54253965cd hscontrol: arm the ephemeral GC at pre-auth key registration 2026-10-28 19:06:05 +00:00
Kristoffer Dalby 93dbfa0a41 hscontrol: skip garbage collecting a node that is no longer ephemeral 2026-10-28 19:06:05 +00:00
Kristoffer Dalby c73615d6f9 db: wrap the sequential IP allocator so freed addresses are reused 2026-10-28 19:06:05 +00:00