public/headscale
1
0 Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-11-04 20:49:24 +09:00
Code Issues Packages Projects Releases Wiki Activity
4,970 Commits 106 Branches 177 Tags
8ea774564d02a3f703ea46b2f7b0ffbbce2a8b82
Commit Graph
318 Commits
Author SHA1 Message Date
Kristoffer Dalby 66d9727cba api/v2: stop echoing request values in error responses 
huma sets an unexpected property's value to the whole request object.
A refused policy, or another 400, now carries its reason in message,
and a failed test run one data entry per failing test naming its src.
 2026-10-28 18:28:23 +00:00
Kristoffer Dalby 03473bae5f policy/v2: match no user for a bare "@" token 2026-10-28 18:28:23 +00:00
Kristoffer Dalby 559b64c66c policy/v2: match no one for an ambiguous user outside policy writes 
A change to user identifiers must not block startup or later logins.
Keep policy writes strict; log ambiguous references on load and refresh.
 2026-10-28 18:28:23 +00:00
Kristoffer Dalby 86578c5fbf policy/v2: prefer the user owning an email over a username match 2026-10-28 18:28:23 +00:00
Kristoffer Dalby 47b91487d0 policy/v2: check grant and nodeAttrs user references on write 
Validation now refuses every input that reached the SetPolicy compile
failure, so restoring the previous policy there is defensive only.
 2026-10-28 18:28:23 +00:00
Kristoffer Dalby 917c6968f1 policy/v2: warn once at load about malformed nextdns attrs 
SaaS loads them and its resolver skips them, as headscale does, but the
mapper also logged a warning per node on every DNS build.
 2026-10-28 18:28:22 +00:00
Kristoffer Dalby 95c6129315 policy: offer exit routes only to viewers whose rules reach the internet 
Every destination overlaps /0, so any rule offered a peer's exit routes.
They now need a rule to the internet, the test exit-node visibility
uses; via steering defers them to a regular grant only on that test.
 2026-10-28 18:28:22 +00:00
Kristoffer Dalby 49d8424634 policy: reduce merged destination prefixes to the node's own addresses 
Adjacent node addresses merge into one prefix, and each node's filter
kept all of it. A prefix made only of node addresses now shrinks to the
node's own; a prefix the policy wrote, or one the node routes, stays.
 2026-10-28 18:28:22 +00:00
Kristoffer Dalby f7e2b3c49e api, policy/v2: refuse route prefixes with host bits 
Routes are matched as written, so such a prefix never equals the one a
client announces. The approval APIs answer 400 and autoApprovers refuses
it at load and write, with Tailscale's text.
 2026-10-28 18:28:22 +00:00
Kristoffer Dalby 8191a88774 policy, state: log only the routes auto-approval adds 2026-10-28 18:28:22 +00:00
Kristoffer Dalby 3f97e68a20 policy/matcher, types: compare a node's routes to matchers as ranges 2026-10-28 18:28:22 +00:00
Kristoffer Dalby 633d48604e policy/matcher: binary-search ranges in overlap checks 2026-10-28 18:28:22 +00:00
Kristoffer Dalby cce082d24b policy: look up approved routes in a set when auto-approving 
Avoid scanning the growing approval list for every announcement.
Use the sorted current routes when identifying additions.
 2026-10-28 18:28:22 +00:00
Kristoffer Dalby ff5d0307f9 types, state: reduce a node's routes against the matchers once 
Reuse matcher membership and approved subnets across the route list.
Preserve route order and HA co-router visibility.
 2026-10-28 18:28:22 +00:00
Kristoffer Dalby 9b97dada51 state, policy/v2: stop treating announced-only routes as policy changes 
Policy evaluation reads only announced-and-approved routes.
Keep publishing Hostinfo updates without rebuilding peer adjacency.
 2026-10-28 18:28:22 +00:00
Kristoffer Dalby 3ce5bf5d9a policy/v2, state: elect primaries by oldest control session 
A router that reconnects joins as a standby; one that kept its session
takes its routes back once available again, as on Tailscale. Both the
global and the via election use it, in place of anti-flap stickiness.
 2026-10-28 18:28:22 +00:00
Kristoffer Dalby 4d5b202db1 policy/v2, state: elect via primaries among online, healthy routers 
Availability tests expiry itself, not only the online flag.
A health change on a via target now triggers a peer recompute.
 2026-10-28 18:28:22 +00:00
Kristoffer Dalby dcb31fe03a policy/v2: refuse check SSH rules with tag sources 
A check asks the source's user to log in again, and a tagged node has
none. Tailscale SaaS refuses the rule; headscale accepted it.
 2026-10-28 18:28:21 +00:00
Kristoffer Dalby 6c2200ae6b policy/v2: limit the destination and port pairs a policy declares 
A grant lists dst and ip apart, so its filter grows with their product.
Refuse a policy over 100,000 pairs, on every parse.
 2026-10-28 18:28:21 +00:00
Kristoffer Dalby 24f03fb786 policy/v2: refuse a port list in a grant ip entry 
Tailscale SaaS takes one port range per ip entry; a list was accepted
and expanded. Write each range as an entry of its own.
 2026-10-28 18:28:21 +00:00
Kristoffer Dalby de6eed892c policy/v2: evaluate policy tests before taking the write lock 
SetPolicy ran the policy's tests under the lock every map response and
node write needs. Run them on a snapshot of users and nodes first.
 2026-10-28 18:28:21 +00:00
Kristoffer Dalby 8f833377ad policy/v2: index compiled SSH rules by source for sshTests 
Each check scanned every rule and parsed every principal per login name,
destination and source address. Compile once per run, key each
destination's rules by principal address, and evaluate a name once.
 2026-10-28 18:28:21 +00:00
Kristoffer Dalby 645fd16843 policy/v2: parse the compiled filter once per tests run 
The tests evaluator parsed every SrcIPs and DstPorts entry again for
each assertion, source prefix and rule. Parse the filter once per run.
 2026-10-28 18:28:21 +00:00
Kristoffer Dalby e4af1dbf03 policy/v2: need every dst node for a tests accept, no range sources 
An accept passes only when each node behind the dst is reached, as on
Tailscale SaaS; a deny keeps its rule. A CIDR, "*" or autogroup:tagged
src names no user or host, so its test fails.
 2026-10-28 18:28:21 +00:00
Kristoffer Dalby 83d0bb6380 policy/v2: label sshTests failures with the dst alias 
The report goes back to the policy author: name src and dst as written,
one line per dst occurrence, and a dst with no node as not reached.
 2026-10-28 18:28:21 +00:00
Kristoffer Dalby 1835047ef8 policy/v2: bound the tests and sshTests failure report 
The report printed every failure with the full labels, so its size was
labels times failures. Print 100 lines of 256-byte labels, then a count.
 2026-10-28 18:28:21 +00:00
Kristoffer Dalby 9086f8189e policy/v2: refuse autogroup:member as an sshTests destination 
Tailscale SaaS refuses it when parsing; headscale evaluated it.
 2026-10-28 18:28:21 +00:00
Kristoffer Dalby b9e5d50b22 policy/v2: refuse address ranges as sshTests sources 
A CIDR, or a hosts entry holding one, as an sshTests src is refused,
as on Tailscale SaaS. Destinations share the range check.
 2026-10-28 18:28:21 +00:00
Kristoffer Dalby 47f79d5241 policy/v2: map login 0 to no local user in SSH rules 
Every rule that maps root now carries "0": "", as Tailscale SaaS writes
it, also when the policy lists "0".
 2026-10-28 18:28:21 +00:00
Kristoffer Dalby 75ff1c4cdf policy/v2: write an ACL's repeated destination once 
An ACL that names a destination and port twice wrote the pair twice.
Grants keep their repeats, as on Tailscale SaaS.
 2026-10-28 18:28:21 +00:00
Kristoffer Dalby 6f265f2baa policy/v2: write a single-address via destination bare 
Via rules wrote every destination with its prefix bits; ACL and grant
rules already drop them for a single address. Both use one formatter.
 2026-10-28 18:28:21 +00:00
Kristoffer Dalby c31c8187b1 policy/v2: refuse an empty policy 
SetPolicy returned a nil error for empty input it ignored, so the v1
API stored it as valid. Reload skips only the nil "no policy" case.
 2026-10-28 18:28:21 +00:00
Kristoffer Dalby ba1dec5cf3 policy/v2: resolve tag owners one hop deep 
A user claims only the tags it owns directly, and a tag owns only the
tags that list it, as on Tailscale SaaS. With no walk left, validate
names an undefined owner once, with the tag that lists it.
 2026-10-28 18:28:21 +00:00
Kristoffer Dalby eff9c8b5d5 policy/v2: evaluate sshTests sources through the nodes they cover 
A src was expanded to every address it names, so "*" or ::/0 never
finished. Principals are node addresses: keep those plus one stand-in.
 2026-10-28 18:28:21 +00:00
Kristoffer Dalby 18af75d312 policy/v2: resolve each group once per policy compile 
Group.resolve walked users and nodes for every member at every mention.
Resolve all groups once on a copy of the policy and compile from it.
 2026-10-28 18:28:21 +00:00
Kristoffer Dalby bfac20fe13 policy/v2: compile SSH rules once and share them across nodes 
SSHPolicy re-resolved every rule and built private principals per node.
Compile the rules once per policy, users and nodes; per node, only
select.
 2026-10-28 18:28:21 +00:00
Kristoffer Dalby 22410ba29e policy/v2: merge rules sharing a source slice without rejoining it 
The rules of one ACL now share one SrcIPs slice; key it once instead of
joining it again for every rule, globally and per node.
 2026-10-28 18:28:21 +00:00
Kristoffer Dalby d68bfe8deb policy/v2: resolve an ACL's sources once for all its destinations 
An ACL compiles to one grant per destination, and each resolved and
rendered the same sources. ViaRoutesForPeer only needs one grant per
ACL.
 2026-10-28 18:28:21 +00:00
Kristoffer Dalby cbd2eef3de policy/v2: bound via route steering by the peer's routes 
Include and Exclude held one entry per overlapping dst, and the election
walked them per dst. Keep one entry per route; a peer without routes
returns at once.
 2026-10-28 18:28:21 +00:00
Kristoffer Dalby c49217fcd3 policy/v2: refresh clients when a user change drops the last via grant 
SetUsers read needsPerNodeFilter after the recompile cleared it, so
the change was reported as empty and clients kept the via rules.
 2026-10-28 18:28:21 +00:00
Kristoffer Dalby bba5fd6c94 policy/v2: recapture SSH data captures 
Every ssh_results row captured again from SaaS. SaaS now maps login "0"
to no local user in rules that map root, quotes a refused checkPeriod as
written and rewords its tailnet-domain refusal.
 2026-10-28 14:31:42 +00:00
Kristoffer Dalby b7fdc48a14 policy/v2, servertest: add policy generation golden data 
One policy over joins, a via router swap, an admin tag, a delete and a
group edit; filter, SSH, peers and routes per step, and the manager
against a fresh one.
 2026-10-28 14:30:16 +00:00
Kristoffer Dalby 74ed6cbf11 servertest, policy/v2: replay tag owner chain joins through registration 
A key login never asks the policy about requested tags, so the joins are
checked where headscale decides them. OAuth mints stay at
TagOwnedByTags.
 2026-10-28 14:29:59 +00:00
Kristoffer Dalby 0e93c4775f policy/v2: name the destination in sshTests failure breakdowns 
A failure reported against the wrong dst alias no longer passes.
 2026-10-28 14:29:35 +00:00
Kristoffer Dalby 2c6c7f070f policy/v2: check the SSH login 0 mapping apart from the rules 
Its skip entries no longer hide rule count, order or principals.
 2026-10-28 14:29:34 +00:00
Kristoffer Dalby 2b2149dc80 policy/v2: add grant port list refusal capture 
Grant and ACL refusals share one check-keyed refused/message check.
 2026-10-28 14:29:34 +00:00
Kristoffer Dalby 50fc2aadbc policy/v2, servertest: add via port captures 
A port-limited ACL entry beside a via grant, and a via tag with no
advertiser. Via HA replays now compare router filters by address.
 2026-10-28 14:29:32 +00:00
Kristoffer Dalby 208b617434 policy/v2, servertest: add multi-route router captures 
A seven-route router and an exit node under six policies; replayed
through policy, peer map and map stream. Peer map now checked against
SaaS peers.
 2026-10-28 14:29:31 +00:00
Kristoffer Dalby eb188b7686 policy/v2, mapper: add nextdns attr captures 
SaaS accepts malformed nextdns profiles and keeps them in the CapMap;
its resolver skips them. DoH addresses compare per node: path, query,
ID.
 2026-10-28 14:29:30 +00:00
Kristoffer Dalby 5c8d5ee8ce policy/v2: add user token captures 
SaaS answers for unknown users, a short name and a bare "@" at every
site. Each capture also runs under headscale-only user rows, at boot and
runtime; SaaS nodes must not change and overlay nodes get nothing.
 2026-10-28 14:29:30 +00:00