Commit Graph
322 Commits
Author SHA1 Message Date
Kristoffer Dalby ccb36d2aed policy/v2, servertest: compare router peers in tailnet overlap captures
SaaS gives each router every device as a peer, whatever the policy
links, and the devices do not list the router back.
Headscale peers a router only with what its policy links.
2026-10-28 14:42:57 +00:00
Kristoffer Dalby d4ccdef066 policy/v2: add deny test captures that pass while access remains
SaaS passes a tests deny when one node of the dst alias, or one member
of a group source, is blocked, though another still gets in. Headscale
fails the dst case; it passes the group case as SaaS does.
2026-10-28 14:42:57 +00:00
Kristoffer Dalby ff37b57718 policy/v2, servertest: add group source split across rules captures
SaaS judges a tests or sshTests group source by one rule naming the
group: per-member rules fail a true accept and pass a false deny.
Headscale checks each member through its own rules.
2026-10-28 14:42:57 +00:00
Kristoffer Dalby 09471a7219 policy/v2, servertest: add bare IPv6 sshTests destination capture
SaaS fails an accept to a bare IPv6 dst, checking the source at
::ffff:100.64.0.0, which no device holds; the IPv4 twin passes.
Headscale checks the source's own addresses and accepts.
2026-10-28 14:42:56 +00:00
Kristoffer Dalby 8af7222816 api/v2: stop echoing request values in error responses
huma sets an unexpected property's value to the whole request object.
A refused policy, or another 400, now carries its reason in message,
and a failed test run one data entry per failing test naming its src.
2026-10-28 14:42:28 +00:00
Kristoffer Dalby 1ca9665a87 policy/v2: match no user for a bare "@" token 2026-10-28 14:42:27 +00:00
Kristoffer Dalby d77ea33f7d policy/v2: match no one for an ambiguous user outside policy writes
A change to user identifiers must not block startup or later logins.
Keep policy writes strict; log ambiguous references on load and refresh.
2026-10-28 14:42:27 +00:00
Kristoffer Dalby 1901a56201 policy/v2: prefer the user owning an email over a username match 2026-10-28 14:42:27 +00:00
Kristoffer Dalby 4f154a6e81 policy/v2: check grant and nodeAttrs user references on write
Validation now refuses every input that reached the SetPolicy compile
failure, so restoring the previous policy there is defensive only.
2026-10-28 14:42:27 +00:00
Kristoffer Dalby 9bf533b626 policy/v2: warn once at load about malformed nextdns attrs
SaaS loads them and its resolver skips them, as headscale does, but the
mapper also logged a warning per node on every DNS build.
2026-10-28 14:42:25 +00:00
Kristoffer Dalby b36f9d443f policy: offer exit routes only to viewers whose rules reach the internet
Every destination overlaps /0, so any rule offered a peer's exit routes.
They now need a rule to the internet, the test exit-node visibility
uses; via steering defers them to a regular grant only on that test.
2026-10-28 14:38:11 +00:00
Kristoffer Dalby 013ec0b59f policy: reduce merged destination prefixes to the node's own addresses
Adjacent node addresses merge into one prefix, and each node's filter
kept all of it. A prefix made only of node addresses now shrinks to the
node's own; a prefix the policy wrote, or one the node routes, stays.
2026-10-28 14:38:10 +00:00
Kristoffer Dalby 306a3d0f25 api, policy/v2: refuse route prefixes with host bits
Routes are matched as written, so such a prefix never equals the one a
client announces. The approval APIs answer 400 and autoApprovers refuses
it at load and write, with Tailscale's text.
2026-10-28 14:38:09 +00:00
Kristoffer Dalby d648cf6b95 policy, state: log only the routes auto-approval adds 2026-10-28 14:38:08 +00:00
Kristoffer Dalby de7e77cf3d policy/matcher, types: compare a node's routes to matchers as ranges 2026-10-28 14:38:06 +00:00
Kristoffer Dalby 6420fb4600 policy/matcher: binary-search ranges in overlap checks 2026-10-28 14:38:05 +00:00
Kristoffer Dalby 772db35e8f policy: look up approved routes in a set when auto-approving
Avoid scanning the growing approval list for every announcement.
Use the sorted current routes when identifying additions.
2026-10-28 14:38:04 +00:00
Kristoffer Dalby 619b731c18 types, state: reduce a node's routes against the matchers once
Reuse matcher membership and approved subnets across the route list.
Preserve route order and HA co-router visibility.
2026-10-28 14:38:03 +00:00
Kristoffer Dalby 04cbb8549d state, policy/v2: stop treating announced-only routes as policy changes
Policy evaluation reads only announced-and-approved routes.
Keep publishing Hostinfo updates without rebuilding peer adjacency.
2026-10-28 14:37:30 +00:00
Kristoffer Dalby 6b99ca0ad1 policy/v2, state: elect primaries by oldest control session
A router that reconnects joins as a standby; one that kept its session
takes its routes back once available again, as on Tailscale. Both the
global and the via election use it, in place of anti-flap stickiness.
2026-10-28 14:37:29 +00:00
Kristoffer Dalby 111ed512fb policy/v2, state: elect via primaries among online, healthy routers
Availability tests expiry itself, not only the online flag.
A health change on a via target now triggers a peer recompute.
2026-10-28 14:37:26 +00:00
Kristoffer Dalby b7e061f09c policy/v2: refuse check SSH rules with tag sources
A check asks the source's user to log in again, and a tagged node has
none. Tailscale SaaS refuses the rule; headscale accepted it.
2026-10-28 14:37:20 +00:00
Kristoffer Dalby 10a4daf544 policy/v2: limit the destination and port pairs a policy declares
A grant lists dst and ip apart, so its filter grows with their product.
Refuse a policy over 100,000 pairs, on every parse.
2026-10-28 14:37:19 +00:00
Kristoffer Dalby 0556d3f76b policy/v2: refuse a port list in a grant ip entry
Tailscale SaaS takes one port range per ip entry; a list was accepted
and expanded. Write each range as an entry of its own.
2026-10-28 14:37:18 +00:00
Kristoffer Dalby f311c75836 policy/v2: evaluate policy tests before taking the write lock
SetPolicy ran the policy's tests under the lock every map response and
node write needs. Run them on a snapshot of users and nodes first.
2026-10-28 14:37:18 +00:00
Kristoffer Dalby d249ec70b3 policy/v2: index compiled SSH rules by source for sshTests
Each check scanned every rule and parsed every principal per login name,
destination and source address. Compile once per run, key each
destination's rules by principal address, and evaluate a name once.
2026-10-28 14:37:17 +00:00
Kristoffer Dalby 5a2f3c6ad3 policy/v2: parse the compiled filter once per tests run
The tests evaluator parsed every SrcIPs and DstPorts entry again for
each assertion, source prefix and rule. Parse the filter once per run.
2026-10-28 14:37:16 +00:00
Kristoffer Dalby 8ebe643826 policy/v2: need every dst node for a tests accept, no range sources
An accept passes only when each node behind the dst is reached, as on
Tailscale SaaS; a deny keeps its rule. A CIDR, "*" or autogroup:tagged
src names no user or host, so its test fails.
2026-10-28 14:37:15 +00:00
Kristoffer Dalby 54257c9231 policy/v2: label sshTests failures with the dst alias
The report goes back to the policy author: name src and dst as written,
one line per dst occurrence, and a dst with no node as not reached.
2026-10-28 14:37:14 +00:00
Kristoffer Dalby f85060946a policy/v2: bound the tests and sshTests failure report
The report printed every failure with the full labels, so its size was
labels times failures. Print 100 lines of 256-byte labels, then a count.
2026-10-28 14:37:13 +00:00
Kristoffer Dalby ea2f9c5bf4 policy/v2: refuse autogroup:member as an sshTests destination
Tailscale SaaS refuses it when parsing; headscale evaluated it.
2026-10-28 14:37:13 +00:00
Kristoffer Dalby 94c410e1db policy/v2: refuse address ranges as sshTests sources
A CIDR, or a hosts entry holding one, as an sshTests src is refused,
as on Tailscale SaaS. Destinations share the range check.
2026-10-28 14:37:12 +00:00
Kristoffer Dalby 7ef3d56a50 policy/v2: map login 0 to no local user in SSH rules
Every rule that maps root now carries "0": "", as Tailscale SaaS writes
it, also when the policy lists "0".
2026-10-28 14:37:11 +00:00
Kristoffer Dalby 98c2e56794 policy/v2: write an ACL's repeated destination once
An ACL that names a destination and port twice wrote the pair twice.
Grants keep their repeats, as on Tailscale SaaS.
2026-10-28 14:37:10 +00:00
Kristoffer Dalby 6f30e2ddbe policy/v2: write a single-address via destination bare
Via rules wrote every destination with its prefix bits; ACL and grant
rules already drop them for a single address. Both use one formatter.
2026-10-28 14:37:09 +00:00
Kristoffer Dalby 89b37fde7d policy/v2: refuse an empty policy
SetPolicy returned a nil error for empty input it ignored, so the v1
API stored it as valid. Reload skips only the nil "no policy" case.
2026-10-28 14:37:06 +00:00
Kristoffer Dalby df7eb934a0 policy/v2: resolve tag owners one hop deep
A user claims only the tags it owns directly, and a tag owns only the
tags that list it, as on Tailscale SaaS. With no walk left, validate
names an undefined owner once, with the tag that lists it.
2026-10-28 14:37:05 +00:00
Kristoffer Dalby a0548e01e0 policy/v2: evaluate sshTests sources through the nodes they cover
A src was expanded to every address it names, so "*" or ::/0 never
finished. Principals are node addresses: keep those plus one stand-in.
2026-10-28 14:37:04 +00:00
Kristoffer Dalby 8caa41cd32 policy/v2: resolve each group once per policy compile
Group.resolve walked users and nodes for every member at every mention.
Resolve all groups once on a copy of the policy and compile from it.
2026-10-28 14:37:03 +00:00
Kristoffer Dalby 89ba8b7dd2 policy/v2: compile SSH rules once and share them across nodes
SSHPolicy re-resolved every rule and built private principals per node.
Compile the rules once per policy, users and nodes; per node, only
select.
2026-10-28 14:37:02 +00:00
Kristoffer Dalby 45308ec596 policy/v2: merge rules sharing a source slice without rejoining it
The rules of one ACL now share one SrcIPs slice; key it once instead of
joining it again for every rule, globally and per node.
2026-10-28 14:37:01 +00:00
Kristoffer Dalby f235907f96 policy/v2: resolve an ACL's sources once for all its destinations
An ACL compiles to one grant per destination, and each resolved and
rendered the same sources. ViaRoutesForPeer only needs one grant per
ACL.
2026-10-28 14:37:00 +00:00
Kristoffer Dalby e934cc02d7 policy/v2: bound via route steering by the peer's routes
Include and Exclude held one entry per overlapping dst, and the election
walked them per dst. Keep one entry per route; a peer without routes
returns at once.
2026-10-28 14:36:59 +00:00
Kristoffer Dalby f6a1ed0300 policy/v2: refresh clients when a user change drops the last via grant
SetUsers read needsPerNodeFilter after the recompile cleared it, so
the change was reported as empty and clients kept the via rules.
2026-10-28 14:36:58 +00:00
Kristoffer Dalby bba5fd6c94 policy/v2: recapture SSH data captures
Every ssh_results row captured again from SaaS. SaaS now maps login "0"
to no local user in rules that map root, quotes a refused checkPeriod as
written and rewords its tailnet-domain refusal.
2026-10-28 14:31:42 +00:00
Kristoffer Dalby b7fdc48a14 policy/v2, servertest: add policy generation golden data
One policy over joins, a via router swap, an admin tag, a delete and a
group edit; filter, SSH, peers and routes per step, and the manager
against a fresh one.
2026-10-28 14:30:16 +00:00
Kristoffer Dalby 74ed6cbf11 servertest, policy/v2: replay tag owner chain joins through registration
A key login never asks the policy about requested tags, so the joins are
checked where headscale decides them. OAuth mints stay at
TagOwnedByTags.
2026-10-28 14:29:59 +00:00
Kristoffer Dalby 0e93c4775f policy/v2: name the destination in sshTests failure breakdowns
A failure reported against the wrong dst alias no longer passes.
2026-10-28 14:29:35 +00:00
Kristoffer Dalby 2c6c7f070f policy/v2: check the SSH login 0 mapping apart from the rules
Its skip entries no longer hide rule count, order or principals.
2026-10-28 14:29:34 +00:00
Kristoffer Dalby 2b2149dc80 policy/v2: add grant port list refusal capture
Grant and ACL refusals share one check-keyed refused/message check.
2026-10-28 14:29:34 +00:00