Commit Graph
172 Commits
Author SHA1 Message Date
Kristoffer Dalby ccb36d2aed policy/v2, servertest: compare router peers in tailnet overlap captures
SaaS gives each router every device as a peer, whatever the policy
links, and the devices do not list the router back.
Headscale peers a router only with what its policy links.
2026-10-28 14:42:57 +00:00
Kristoffer Dalby ff37b57718 policy/v2, servertest: add group source split across rules captures
SaaS judges a tests or sshTests group source by one rule naming the
group: per-member rules fail a true accept and pass a false deny.
Headscale checks each member through its own rules.
2026-10-28 14:42:57 +00:00
Kristoffer Dalby 09471a7219 policy/v2, servertest: add bare IPv6 sshTests destination capture
SaaS fails an accept to a bare IPv6 dst, checking the source at
::ffff:100.64.0.0, which no device holds; the IPv4 twin passes.
Headscale checks the source's own addresses and accepts.
2026-10-28 14:42:56 +00:00
Kristoffer Dalby 81925d9d48 api/v2: require a token to hold a device's current tags to retag it
SetNodeTags replaces the tag set, so the tags it removes need the grant
too. A tag outside the grant answers 400, as on Tailscale SaaS.
2026-10-28 14:42:31 +00:00
Kristoffer Dalby 1af4a51b74 api/v2: show a tagged device's creator as its user
A tagged device shows the login that made the key it joined with.
Its owner stays its tags.
2026-10-28 14:42:30 +00:00
Kristoffer Dalby e5d14fd2d2 api/v2: list token-made auth keys to a token without all=true
Keys an OAuth token makes are marked so. No listing holds an invalid
key.
2026-10-28 14:42:29 +00:00
Kristoffer Dalby 3768aaf323 api/v2: show userId on admin-made tagged keys
An admin key's user is recorded as the creator of the tagged keys it
makes. A tagged key re-registers a machine by its tags, whoever made it.
2026-10-28 14:42:29 +00:00
Kristoffer Dalby fb5802c878 api/v2: return a device name as its FQDN 2026-10-28 14:42:29 +00:00
Kristoffer Dalby 8af7222816 api/v2: stop echoing request values in error responses
huma sets an unexpected property's value to the whole request object.
A refused policy, or another 400, now carries its reason in message,
and a failed test run one data entry per failing test naming its src.
2026-10-28 14:42:28 +00:00
Kristoffer Dalby e652da8744 state: refresh the NodeStore copies of a user in UpdateUser 2026-10-28 14:42:26 +00:00
Kristoffer Dalby 0acd84382b state: announce a node online only after it was offline
A stream back within the reconnect grace sent peers an online patch,
a router's sent every node a policy response, and a relogin on
unchanged keys sent a key patch; nothing had changed.
2026-10-28 14:42:26 +00:00
Kristoffer Dalby d1ab26388c change: do not echo a node's own report back to it
An endpoint or DERP report came back to the node as a self update;
SaaS sends it to the node's peers only.
2026-10-28 14:42:25 +00:00
Kristoffer Dalby ce9e3211b5 state, change: send a deleted node's removal only to its peers
The removal went to every node, also those the policy hid the node from.
The delete now returns the node's peers from the snapshot it replaces.
2026-10-28 14:42:25 +00:00
Kristoffer Dalby de3e63e258 mapper: cap concurrent map sessions per node
A node chose how many map streams it held, each pinning a session.
The fifth replaces the oldest; same shape as #3468's mapper commit.
2026-10-28 14:42:24 +00:00
Kristoffer Dalby 96d9c361dc db: succeed on a repeated revoke of an auth key
A repeated v2 DELETE of an auth key now answers 200, as Tailscale does.
2026-10-28 14:42:23 +00:00
Kristoffer Dalby 28296e6b84 auth: answer a logout that deletes an ephemeral node as authorised 2026-10-28 14:42:23 +00:00
Kristoffer Dalby 3392597804 db, state: keep the ephemeral flag a node was created with
The flag moves from the key to the node, so a login with another key no
longer changes it. A user claiming a tagged node still clears it. v1
nodes carry the flag.
2026-10-28 14:42:23 +00:00
Kristoffer Dalby af41728ecf state: cut a label so its -N suffix fits in 63 bytes 2026-10-28 14:42:22 +00:00
Kristoffer Dalby 267ab2f4db state: treat extra DNS record names as taken node names 2026-10-28 14:42:22 +00:00
Kristoffer Dalby f320fe10e8 mapper: show an expired peer online, without endpoints or DERP
A connected expired node shows online to its peers. Neither its map
entry nor endpoint, DERP or disco patches carry the paths to reach it.
2026-10-28 14:42:05 +00:00
Kristoffer Dalby 3a9a1a6a4c mapper: trim the Hostinfo sent to peers and to the node itself
As on Tailscale SaaS, the node's own entry keeps Hostname, RequestTags,
RoutableIPs and Services; peers get Hostname, OS, Services without
peerapi-dns-proxy, SSH host keys and AppConnector, and resend on those.
2026-10-28 14:42:05 +00:00
Kristoffer Dalby 9a496270c4 mapper: keep an expired node authorised in its own entry
Tailscale SaaS sends an expired node MachineAuthorized and no Expired
flag; its past KeyExpiry already moves the client to NeedsLogin.
2026-10-28 14:42:04 +00:00
Kristoffer Dalby 15732cc071 state: apply requested tags on a key login that owns them
A requested tag the key's user owns directly, or the key's tags own one
hop away, replaces the key's tags instead of refusing the login.
2026-10-28 14:42:03 +00:00
Kristoffer Dalby 2a96a02d7b state: auto-approve routes after an admin tag change
The new tags may approve announced routes. Approval runs once the policy
manager knows the new owner, as after a registration.
2026-10-28 14:42:03 +00:00
Kristoffer Dalby e481fe49d3 state: drop auto-approved routes when they are withdrawn
Only routes auto-approval alone granted go; approvals from before the
upgrade stay, as do routes an admin set.
2026-10-28 14:42:02 +00:00
Kristoffer Dalby 3c0f6e8120 state: auto-approve on registration only when the node key rotates
Registration runs the approval itself, once the policy manager knows the
node's owner, for a new node key or a change to the announced routes.
2026-10-28 14:42:01 +00:00
Kristoffer Dalby 822c8779a5 auth: store a client's earlier expiry and expire a tagged node at logout
A client may bring its expiry forward, which turns expiry on for a node
without one, but still cannot push it back. Logout expires tagged nodes
too.
2026-10-28 14:42:00 +00:00
Kristoffer Dalby 309cfbb342 auth, state: answer an expired node's same-key login with NodeKeyExpired
The client then rotates its node key and logs in again, so no key is
judged under the expired one. The machine stays authorised.
2026-10-28 14:41:47 +00:00
Kristoffer Dalby e43ee22b01 state: honour SSH check approvals only while the source keeps its owner 2026-10-28 14:41:02 +00:00
Kristoffer Dalby bf1ff1665b state: let a pre-auth key that is no longer valid only wake its node
A login that keeps its node key leaves a live node's expiry alone, even
with a valid key, and a wake-up is not refused for the tags it requests.
2026-10-28 14:40:49 +00:00
Kristoffer Dalby a0893b43ff state: auto-approve routes in the NodeStore writer, not on reload
Registration approval runs on the node the writer replaces. A policy
reload approves nothing, and a map request only when its announced
routes change, so neither re-grants a route an admin revoked.
2026-10-28 14:39:41 +00:00
Kristoffer Dalby b36f9d443f policy: offer exit routes only to viewers whose rules reach the internet
Every destination overlaps /0, so any rule offered a peer's exit routes.
They now need a rule to the internet, the test exit-node visibility
uses; via steering defers them to a regular grant only on that test.
2026-10-28 14:38:11 +00:00
Kristoffer Dalby a188777784 mapper: send a router all of its own routes
Its AllowedIPs held only the primaries the policy let it reach. It now
holds every approved route, and PrimaryRoutes the ones it serves.
2026-10-28 14:38:10 +00:00
Kristoffer Dalby 013ec0b59f policy: reduce merged destination prefixes to the node's own addresses
Adjacent node addresses merge into one prefix, and each node's filter
kept all of it. A prefix made only of node addresses now shrinks to the
node's own; a prefix the policy wrote, or one the node routes, stays.
2026-10-28 14:38:10 +00:00
Kristoffer Dalby 306a3d0f25 api, policy/v2: refuse route prefixes with host bits
Routes are matched as written, so such a prefix never equals the one a
client announces. The approval APIs answer 400 and autoApprovers refuses
it at load and write, with Tailscale's text.
2026-10-28 14:38:09 +00:00
Kristoffer Dalby 04cbb8549d state, policy/v2: stop treating announced-only routes as policy changes
Policy evaluation reads only announced-and-approved routes.
Keep publishing Hostinfo updates without rebuilding peer adjacency.
2026-10-28 14:37:30 +00:00
Kristoffer Dalby 6b99ca0ad1 policy/v2, state: elect primaries by oldest control session
A router that reconnects joins as a standby; one that kept its session
takes its routes back once available again, as on Tailscale. Both the
global and the via election use it, in place of anti-flap stickiness.
2026-10-28 14:37:29 +00:00
Kristoffer Dalby 97d4310caa state: keep a prefix mapped when no router is available
Peers keep the routes of an offline or expired router, as on Tailscale.
The previous primary keeps the prefix, else the lowest-ID approver;
never one the prober declared unreachable.
2026-10-28 14:37:27 +00:00
Kristoffer Dalby 111ed512fb policy/v2, state: elect via primaries among online, healthy routers
Availability tests expiry itself, not only the online flag.
A health change on a via target now triggers a peer recompute.
2026-10-28 14:37:26 +00:00
Kristoffer Dalby 67b88fe3b2 state: withhold HA probe results only for routers tied to a deferred one 2026-10-28 14:37:25 +00:00
Kristoffer Dalby 95b44713c1 state: keep probing a lone advertiser while it is unhealthy 2026-10-28 14:37:24 +00:00
Kristoffer Dalby b7e061f09c policy/v2: refuse check SSH rules with tag sources
A check asks the source's user to log in again, and a tagged node has
none. Tailscale SaaS refuses the rule; headscale accepted it.
2026-10-28 14:37:20 +00:00
Kristoffer Dalby 0556d3f76b policy/v2: refuse a port list in a grant ip entry
Tailscale SaaS takes one port range per ip entry; a list was accepted
and expanded. Write each range as an entry of its own.
2026-10-28 14:37:18 +00:00
Kristoffer Dalby 8ebe643826 policy/v2: need every dst node for a tests accept, no range sources
An accept passes only when each node behind the dst is reached, as on
Tailscale SaaS; a deny keeps its rule. A CIDR, "*" or autogroup:tagged
src names no user or host, so its test fails.
2026-10-28 14:37:15 +00:00
Kristoffer Dalby 94c410e1db policy/v2: refuse address ranges as sshTests sources
A CIDR, or a hosts entry holding one, as an sshTests src is refused,
as on Tailscale SaaS. Destinations share the range check.
2026-10-28 14:37:12 +00:00
Kristoffer Dalby 7ef3d56a50 policy/v2: map login 0 to no local user in SSH rules
Every rule that maps root now carries "0": "", as Tailscale SaaS writes
it, also when the policy lists "0".
2026-10-28 14:37:11 +00:00
Kristoffer Dalby f6a1ed0300 policy/v2: refresh clients when a user change drops the last via grant
SetUsers read needsPerNodeFilter after the recompile cleared it, so
the change was reported as empty and clients kept the via rules.
2026-10-28 14:36:58 +00:00
Kristoffer Dalby 45948f2feb hscontrol, servertest: add key list scope golden data
Read-only and key-making OAuth tokens of each tag set list auth keys
with and without all=true, over admin- and token-made keys of every tag
relation, one admin key made after the token-made ones.
2026-10-28 14:31:41 +00:00
Kristoffer Dalby a16a38f527 servertest: add user role dispatch golden data
An admin role change under autogroup:admin, mirrored as a user rename;
peers, filter and frames per node per step, and v2 device users.
2026-10-28 14:31:40 +00:00
Kristoffer Dalby b4e2c0e93f servertest, state: add node name golden data
Labels under taken hostnames, case-only renames, hostname changes, long
hostnames and a Service's name; API, peer and self per step, and State
labels as a restart would load them.
2026-10-28 14:31:40 +00:00