Commit Graph
318 Commits
Author SHA1 Message Date
Kristoffer Dalby 214c761fda api/v2: stop echoing request values in error responses
huma sets an unexpected property's value to the whole request object.
A refused policy, or another 400, now carries its reason in message,
and a failed test run one data entry per failing test naming its src.
2026-10-28 07:15:55 +00:00
Kristoffer Dalby 463b060a90 policy/v2: match no user for a bare "@" token 2026-10-28 07:15:55 +00:00
Kristoffer Dalby e2fd68e48e policy/v2: match no one for an ambiguous user outside policy writes
A change to user identifiers must not block startup or later logins.
Keep policy writes strict; log ambiguous references on load and refresh.
2026-10-28 07:15:55 +00:00
Kristoffer Dalby 769015779f policy/v2: prefer the user owning an email over a username match 2026-10-28 07:15:55 +00:00
Kristoffer Dalby b558031804 policy/v2: check grant and nodeAttrs user references on write
Validation now refuses every input that reached the SetPolicy compile
failure, so restoring the previous policy there is defensive only.
2026-10-28 07:15:55 +00:00
Kristoffer Dalby 2b45a32248 policy/v2: warn once at load about malformed nextdns attrs
SaaS loads them and its resolver skips them, as headscale does, but the
mapper also logged a warning per node on every DNS build.
2026-10-28 07:15:55 +00:00
Kristoffer Dalby 850c5d3fbb policy: offer exit routes only to viewers whose rules reach the internet
Every destination overlaps /0, so any rule offered a peer's exit routes.
They now need a rule to the internet, the test exit-node visibility
uses; via steering defers them to a regular grant only on that test.
2026-10-28 00:51:40 +00:00
Kristoffer Dalby 780c9406ae policy: reduce merged destination prefixes to the node's own addresses
Adjacent node addresses merge into one prefix, and each node's filter
kept all of it. A prefix made only of node addresses now shrinks to the
node's own; a prefix the policy wrote, or one the node routes, stays.
2026-10-28 00:51:40 +00:00
Kristoffer Dalby 2cb84b2905 api, policy/v2: refuse route prefixes with host bits
Routes are matched as written, so such a prefix never equals the one a
client announces. The approval APIs answer 400 and autoApprovers refuses
it at load and write, with Tailscale's text.
2026-10-28 00:51:39 +00:00
Kristoffer Dalby 144629e11e policy, state: log only the routes auto-approval adds 2026-10-28 00:51:39 +00:00
Kristoffer Dalby 1dcd8ff4cd policy/matcher, types: compare a node's routes to matchers as ranges 2026-10-28 00:51:39 +00:00
Kristoffer Dalby 3a13b2e40a policy/matcher: binary-search ranges in overlap checks 2026-10-28 00:51:39 +00:00
Kristoffer Dalby 90f873ee66 policy: look up approved routes in a set when auto-approving
Avoid scanning the growing approval list for every announcement.
Use the sorted current routes when identifying additions.
2026-10-28 00:51:39 +00:00
Kristoffer Dalby 21fd9f1366 types, state: reduce a node's routes against the matchers once
Reuse matcher membership and approved subnets across the route list.
Preserve route order and HA co-router visibility.
2026-10-28 00:51:39 +00:00
Kristoffer Dalby 4cafc80fbd state, policy/v2: stop treating announced-only routes as policy changes
Policy evaluation reads only announced-and-approved routes.
Keep publishing Hostinfo updates without rebuilding peer adjacency.
2026-10-28 00:51:39 +00:00
Kristoffer Dalby 4d1e8aa0c1 policy/v2, state: elect primaries by oldest control session
A router that reconnects joins as a standby; one that kept its session
takes its routes back once available again, as on Tailscale. Both the
global and the via election use it, in place of anti-flap stickiness.
2026-10-28 00:51:39 +00:00
Kristoffer Dalby 7daa08e94e policy/v2, state: elect via primaries among online, healthy routers
Availability tests expiry itself, not only the online flag.
A health change on a via target now triggers a peer recompute.
2026-10-28 00:51:39 +00:00
Kristoffer Dalby e6302ce9b6 policy/v2: refuse check SSH rules with tag sources
A check asks the source's user to log in again, and a tagged node has
none. Tailscale SaaS refuses the rule; headscale accepted it.
2026-10-28 00:51:39 +00:00
Kristoffer Dalby 7fa1aa7d66 policy/v2: limit the destination and port pairs a policy declares
A grant lists dst and ip apart, so its filter grows with their product.
Refuse a policy over 100,000 pairs, on every parse.
2026-10-28 00:51:39 +00:00
Kristoffer Dalby f2924f39e6 policy/v2: refuse a port list in a grant ip entry
Tailscale SaaS takes one port range per ip entry; a list was accepted
and expanded. Write each range as an entry of its own.
2026-10-28 00:51:39 +00:00
Kristoffer Dalby a0ae68f22b policy/v2: evaluate policy tests before taking the write lock
SetPolicy ran the policy's tests under the lock every map response and
node write needs. Run them on a snapshot of users and nodes first.
2026-10-28 00:51:39 +00:00
Kristoffer Dalby 350aea66f4 policy/v2: index compiled SSH rules by source for sshTests
Each check scanned every rule and parsed every principal per login name,
destination and source address. Compile once per run, key each
destination's rules by principal address, and evaluate a name once.
2026-10-28 00:51:39 +00:00
Kristoffer Dalby ea9f099657 policy/v2: parse the compiled filter once per tests run
The tests evaluator parsed every SrcIPs and DstPorts entry again for
each assertion, source prefix and rule. Parse the filter once per run.
2026-10-28 00:51:39 +00:00
Kristoffer Dalby 643ed8bfc6 policy/v2: need every dst node for a tests accept, no range sources
An accept passes only when each node behind the dst is reached, as on
Tailscale SaaS; a deny keeps its rule. A CIDR, "*" or autogroup:tagged
src names no user or host, so its test fails.
2026-10-28 00:51:39 +00:00
Kristoffer Dalby bda2cb5076 policy/v2: label sshTests failures with the dst alias
The report goes back to the policy author: name src and dst as written,
one line per dst occurrence, and a dst with no node as not reached.
2026-10-28 00:51:39 +00:00
Kristoffer Dalby 649985954f policy/v2: bound the tests and sshTests failure report
The report printed every failure with the full labels, so its size was
labels times failures. Print 100 lines of 256-byte labels, then a count.
2026-10-28 00:51:39 +00:00
Kristoffer Dalby 76bdf3adad policy/v2: refuse autogroup:member as an sshTests destination
Tailscale SaaS refuses it when parsing; headscale evaluated it.
2026-10-28 00:51:39 +00:00
Kristoffer Dalby 124efeeaa0 policy/v2: refuse address ranges as sshTests sources
A CIDR, or a hosts entry holding one, as an sshTests src is refused,
as on Tailscale SaaS. Destinations share the range check.
2026-10-27 21:32:32 +00:00
Kristoffer Dalby a70a567ab7 policy/v2: map login 0 to no local user in SSH rules
Every rule that maps root now carries "0": "", as Tailscale SaaS writes
it, also when the policy lists "0".
2026-10-27 21:32:32 +00:00
Kristoffer Dalby 1eab82f7f5 policy/v2: write an ACL's repeated destination once
An ACL that names a destination and port twice wrote the pair twice.
Grants keep their repeats, as on Tailscale SaaS.
2026-10-27 21:32:32 +00:00
Kristoffer Dalby b4b2322182 policy/v2: write a single-address via destination bare
Via rules wrote every destination with its prefix bits; ACL and grant
rules already drop them for a single address. Both use one formatter.
2026-10-27 21:32:32 +00:00
Kristoffer Dalby 3a57f3a6e3 policy/v2: refuse an empty policy
SetPolicy returned a nil error for empty input it ignored, so the v1
API stored it as valid. Reload skips only the nil "no policy" case.
2026-10-27 21:32:32 +00:00
Kristoffer Dalby 3e9dc82f20 policy/v2: resolve tag owners one hop deep
A user claims only the tags it owns directly, and a tag owns only the
tags that list it, as on Tailscale SaaS. With no walk left, validate
names an undefined owner once, with the tag that lists it.
2026-10-27 21:32:32 +00:00
Kristoffer Dalby bd63cdd767 policy/v2: evaluate sshTests sources through the nodes they cover
A src was expanded to every address it names, so "*" or ::/0 never
finished. Principals are node addresses: keep those plus one stand-in.
2026-10-27 21:32:32 +00:00
Kristoffer Dalby 6d1f582fdf policy/v2: resolve each group once per policy compile
Group.resolve walked users and nodes for every member at every mention.
Resolve all groups once on a copy of the policy and compile from it.
2026-10-27 21:32:32 +00:00
Kristoffer Dalby b00456eb02 policy/v2: compile SSH rules once and share them across nodes
SSHPolicy re-resolved every rule and built private principals per node.
Compile the rules once per policy, users and nodes; per node, only
select.
2026-10-27 21:32:32 +00:00
Kristoffer Dalby e1d755bc82 policy/v2: merge rules sharing a source slice without rejoining it
The rules of one ACL now share one SrcIPs slice; key it once instead of
joining it again for every rule, globally and per node.
2026-10-27 21:32:32 +00:00
Kristoffer Dalby 571e4476ca policy/v2: resolve an ACL's sources once for all its destinations
An ACL compiles to one grant per destination, and each resolved and
rendered the same sources. ViaRoutesForPeer only needs one grant per
ACL.
2026-10-27 21:32:32 +00:00
Kristoffer Dalby 64b324f4d4 policy/v2: bound via route steering by the peer's routes
Include and Exclude held one entry per overlapping dst, and the election
walked them per dst. Keep one entry per route; a peer without routes
returns at once.
2026-10-27 21:32:32 +00:00
Kristoffer Dalby 4dcb59d453 policy/v2: refresh clients when a user change drops the last via grant
SetUsers read needsPerNodeFilter after the recompile cleared it, so
the change was reported as empty and clients kept the via rules.
2026-10-27 21:32:32 +00:00
Kristoffer Dalby 674c52523b policy/v2: recapture SSH data captures
Every ssh_results row captured again from SaaS. SaaS now maps login "0"
to no local user in rules that map root, quotes a refused checkPeriod as
written and rewords its tailnet-domain refusal.
2026-10-27 21:31:36 +00:00
Kristoffer Dalby 376390ed7c policy/v2, servertest: add policy generation golden data
One policy over joins, a via router swap, an admin tag, a delete and a
group edit; filter, SSH, peers and routes per step, and the manager
against a fresh one.
2026-10-27 21:31:35 +00:00
Kristoffer Dalby ad4dbfdfbc servertest, policy/v2: replay tag owner chain joins through registration
A key login never asks the policy about requested tags, so the joins are
checked where headscale decides them. OAuth mints stay at
TagOwnedByTags.
2026-10-27 21:31:35 +00:00
Kristoffer Dalby f7f58523b7 policy/v2: name the destination in sshTests failure breakdowns
A failure reported against the wrong dst alias no longer passes.
2026-10-27 21:31:35 +00:00
Kristoffer Dalby 2a5cdd1c10 policy/v2: check the SSH login 0 mapping apart from the rules
Its skip entries no longer hide rule count, order or principals.
2026-10-27 21:31:35 +00:00
Kristoffer Dalby 715a36be40 policy/v2: add grant port list refusal capture
Grant and ACL refusals share one check-keyed refused/message check.
2026-10-27 21:31:35 +00:00
Kristoffer Dalby 2686253df7 servertest, policy/v2: add re-authentication golden data
Expired, live, ephemeral and admin-tagged devices logging in again with
spent, revoked, valid and other users' keys, by key and by login;
tag ownership through tags per policy function.
2026-10-27 21:30:36 +00:00
Kristoffer Dalby 4c354f0c61 policy/v2, servertest: add via port captures
A port-limited ACL entry beside a via grant, and a via tag with no
advertiser. Via HA replays now compare router filters by address.
2026-10-27 21:30:36 +00:00
Kristoffer Dalby 0a2689ae3f policy/v2, servertest: add multi-route router captures
A seven-route router and an exit node under six policies; replayed
through policy, peer map and map stream. Peer map now checked against
SaaS peers.
2026-10-27 21:30:36 +00:00
Kristoffer Dalby 076281e909 policy/v2, servertest, hscontrol: add tailnet overlap route captures
Routers announcing tailnet addresses, approved by policy, admin key and
devices:routes token; replayed through policy, map stream and v1/v2
APIs.
2026-10-27 21:30:36 +00:00