Commit Graph
142 Commits
Author SHA1 Message Date
Kristoffer Dalby f52d2216a6 state: auto-approve routes in the NodeStore writer, not on reload
Registration approval runs on the node the writer replaces. A policy
reload approves nothing, and a map request only when its announced
routes change, so neither re-grants a route an admin revoked.
2026-10-28 16:35:21 +00:00
Kristoffer Dalby 4c98552b2d policy: offer exit routes only to viewers whose rules reach the internet
Every destination overlaps /0, so any rule offered a peer's exit routes.
They now need a rule to the internet, the test exit-node visibility
uses; via steering defers them to a regular grant only on that test.
2026-10-28 16:35:21 +00:00
Kristoffer Dalby aca11eae02 mapper: send a router all of its own routes
Its AllowedIPs held only the primaries the policy let it reach. It now
holds every approved route, and PrimaryRoutes the ones it serves.
2026-10-28 16:35:21 +00:00
Kristoffer Dalby 87de37fc7a policy: reduce merged destination prefixes to the node's own addresses
Adjacent node addresses merge into one prefix, and each node's filter
kept all of it. A prefix made only of node addresses now shrinks to the
node's own; a prefix the policy wrote, or one the node routes, stays.
2026-10-28 16:35:21 +00:00
Kristoffer Dalby 12fb9fae43 api, policy/v2: refuse route prefixes with host bits
Routes are matched as written, so such a prefix never equals the one a
client announces. The approval APIs answer 400 and autoApprovers refuses
it at load and write, with Tailscale's text.
2026-10-28 16:35:21 +00:00
Kristoffer Dalby 66eada0995 state, policy/v2: stop treating announced-only routes as policy changes
Policy evaluation reads only announced-and-approved routes.
Keep publishing Hostinfo updates without rebuilding peer adjacency.
2026-10-28 16:35:21 +00:00
Kristoffer Dalby 0ae83ca9ca policy/v2, state: elect primaries by oldest control session
A router that reconnects joins as a standby; one that kept its session
takes its routes back once available again, as on Tailscale. Both the
global and the via election use it, in place of anti-flap stickiness.
2026-10-28 16:35:21 +00:00
Kristoffer Dalby e221bbb74b state: keep a prefix mapped when no router is available
Peers keep the routes of an offline or expired router, as on Tailscale.
The previous primary keeps the prefix, else the lowest-ID approver;
never one the prober declared unreachable.
2026-10-28 16:35:21 +00:00
Kristoffer Dalby 6ffa89718a policy/v2, state: elect via primaries among online, healthy routers
Availability tests expiry itself, not only the online flag.
A health change on a via target now triggers a peer recompute.
2026-10-28 16:35:21 +00:00
Kristoffer Dalby acb131a8c6 state: withhold HA probe results only for routers tied to a deferred one 2026-10-28 16:35:21 +00:00
Kristoffer Dalby b60e4a467d state: keep probing a lone advertiser while it is unhealthy 2026-10-28 16:35:21 +00:00
Kristoffer Dalby 142a853267 policy/v2: refuse check SSH rules with tag sources
A check asks the source's user to log in again, and a tagged node has
none. Tailscale SaaS refuses the rule; headscale accepted it.
2026-10-28 16:35:21 +00:00
Kristoffer Dalby 6de71bdb73 policy/v2: refuse a port list in a grant ip entry
Tailscale SaaS takes one port range per ip entry; a list was accepted
and expanded. Write each range as an entry of its own.
2026-10-28 16:35:21 +00:00
Kristoffer Dalby 8e9de2ec5f policy/v2: need every dst node for a tests accept, no range sources
An accept passes only when each node behind the dst is reached, as on
Tailscale SaaS; a deny keeps its rule. A CIDR, "*" or autogroup:tagged
src names no user or host, so its test fails.
2026-10-28 16:35:21 +00:00
Kristoffer Dalby 446965dc13 policy/v2: refuse address ranges as sshTests sources
A CIDR, or a hosts entry holding one, as an sshTests src is refused,
as on Tailscale SaaS. Destinations share the range check.
2026-10-28 16:35:21 +00:00
Kristoffer Dalby bc25fac9e6 policy/v2: map login 0 to no local user in SSH rules
Every rule that maps root now carries "0": "", as Tailscale SaaS writes
it, also when the policy lists "0".
2026-10-28 16:35:21 +00:00
Kristoffer Dalby d8f1651ab8 policy/v2: refresh clients when a user change drops the last via grant
SetUsers read needsPerNodeFilter after the recompile cleared it, so
the change was reported as empty and clients kept the via rules.
2026-10-28 16:35:21 +00:00
Kristoffer Dalby 45948f2feb hscontrol, servertest: add key list scope golden data
Read-only and key-making OAuth tokens of each tag set list auth keys
with and without all=true, over admin- and token-made keys of every tag
relation, one admin key made after the token-made ones.
2026-10-28 14:31:41 +00:00
Kristoffer Dalby a16a38f527 servertest: add user role dispatch golden data
An admin role change under autogroup:admin, mirrored as a user rename;
peers, filter and frames per node per step, and v2 device users.
2026-10-28 14:31:40 +00:00
Kristoffer Dalby b4e2c0e93f servertest, state: add node name golden data
Labels under taken hostnames, case-only renames, hostname changes, long
hostnames and a Service's name; API, peer and self per step, and State
labels as a restart would load them.
2026-10-28 14:31:40 +00:00
Kristoffer Dalby b7fdc48a14 policy/v2, servertest: add policy generation golden data
One policy over joins, a via router swap, an admin tag, a delete and a
group edit; filter, SSH, peers and routes per step, and the manager
against a fresh one.
2026-10-28 14:30:16 +00:00
Kristoffer Dalby 659ac74d19 servertest: add hidden peer and route announcement golden data
What a node hears of peers it cannot see, and what a router's peers hear
of routes it announces; presence, removals, peers and routes per step.
2026-10-28 14:30:16 +00:00
Kristoffer Dalby fbce1be506 servertest: count map frames per client
Counts ControlTime events, so frames that leave the netmap as it was,
or that a delta client applies in place, still show.
2026-10-28 14:30:16 +00:00
Kristoffer Dalby 6f9eecc80e servertest: recapture map delivery golden data
The probe now bounds snapshot reads and keeps feature refusals as data.
SaaS now sends appc and sshd laptop's unchanged entry on the restore.
2026-10-28 14:30:15 +00:00
Kristoffer Dalby 71c668fc6b servertest: wait for each replayed join before the next
Polls start in the background, so a later router could come online
first and keep the global primary SaaS gave the first.
2026-10-28 14:30:15 +00:00
Kristoffer Dalby f87985073e servertest: count deleted nodes in replayed peer views
Only nodes still in State resolved to an alias, so a client that kept
a deleted peer passed the peers and route owner checks.
2026-10-28 14:30:15 +00:00
Kristoffer Dalby edc64bf7b8 servertest: recapture via HA failover golden data
The probe now bounds its reads and stops when a step loses data.
Route owners and peers match the first capture at every step.
2026-10-28 14:30:14 +00:00
Kristoffer Dalby 48455b7812 hscontrol, servertest: fail on any unread pending login or expiry entry
Each map serves one capture, so a misspelled capture name never went
stale.
2026-10-28 14:30:14 +00:00
Kristoffer Dalby 47538563c7 servertest: require a map on each stream an expiry replay opens
The cached netmap outlives a stream, so a refused re-poll passed.
2026-10-28 14:30:14 +00:00
Kristoffer Dalby efc8c696e2 servertest: compare filter and SSH rules in expiry replays
Changed-or-not alone let empty rules pass for SaaS's new ones.
2026-10-28 14:30:14 +00:00
Kristoffer Dalby 855e14c4a7 servertest: recapture ephemeral, expiry and pending login golden data
The expiry file now holds the shared policy, DNS and observer setup.
Outcomes match the first capture; collection was seen one poll earlier.
2026-10-28 14:30:13 +00:00
Kristoffer Dalby ef496217b6 servertest: judge ephemeral collection apart from the poll that saw it
Killed nodes are checked once at the last read, for devices left and
whether the observer lost them since the kill.
2026-10-28 14:30:13 +00:00
Kristoffer Dalby b9f7317252 servertest: recapture v2 OAuth and policy API golden data
Tag writes are read back once the tags hold, and both files carry a
baseline snapshot. Statuses and read-backs match the first capture.
2026-10-28 14:30:12 +00:00
Kristoffer Dalby 74ed6cbf11 servertest, policy/v2: replay tag owner chain joins through registration
A key login never asks the policy about requested tags, so the joins are
checked where headscale decides them. OAuth mints stay at
TagOwnedByTags.
2026-10-28 14:29:59 +00:00
Kristoffer Dalby 070ac5893f servertest: recapture re-authentication golden data
The probe now stops a refused login's retries; the replay disconnects
there too. Outcomes match the first capture, and user IDs are labels.
2026-10-28 14:29:37 +00:00
Kristoffer Dalby 759cf73108 servertest: fail on skip entries no lifecycle replay reads
Consumers check entries under their own capture only, so a bare or
misspelled key never went stale.
2026-10-28 14:29:36 +00:00
Kristoffer Dalby 52faf0e692 servertest: check route continuity in every streamed step
Removal and route drops were judged only on steps SaaS sent frames for;
silent steps and a clear-then-restore within a step went unchecked.
2026-10-28 14:29:36 +00:00
Kristoffer Dalby 464656d6b3 servertest: fail step checks that never hold
A match on the last sample before the deadline no longer passes.
2026-10-28 14:29:36 +00:00
Kristoffer Dalby 54cbc3aad8 servertest: keep the address family in filter comparisons
A rule missing one family of a peer's addresses compared equal.
2026-10-28 14:29:35 +00:00
Kristoffer Dalby dca6017598 servertest: check peer visibility, routes and addresses apart
A listed difference in one no longer hides the others; the exit route
entries now key the AllowedIPs check alone.
2026-10-28 14:29:35 +00:00
Kristoffer Dalby 0b8869ce31 servertest: check peers and filters apart after a via source loss
The user node's filter already matches SaaS and is now asserted.
2026-10-28 14:29:35 +00:00
Kristoffer Dalby 2b2149dc80 policy/v2: add grant port list refusal capture
Grant and ACL refusals share one check-keyed refused/message check.
2026-10-28 14:29:34 +00:00
Kristoffer Dalby 9f87fbd4f3 servertest, state: add map delivery golden data
A retag through the API, a running peer's DERP, disco, hostname and
port, down and up gaps around policy pushes; peers, filters and frames
per node.
2026-10-28 14:29:34 +00:00
Kristoffer Dalby 40324335cd servertest: add via HA failover golden data
One route on a non-via router and a via pair through crashes and
returns, the via group down, expiry, approval loss, withdraw,
re-advertise and delete; route owner and peers per viewer per step.
2026-10-28 14:29:33 +00:00
Kristoffer Dalby 58c8abbf52 servertest: join replayed routers with their routes
A route update sent after the join could be overtaken by the stream's
first request and dropped; the probe joined with the routes set.
2026-10-28 14:29:33 +00:00
Kristoffer Dalby 9447314d95 servertest, hscontrol: add ephemeral, expiry, pending login golden data
Ephemeral devices through logout, deletes, re-auth and collection;
expired routers and nodes, a client's own expiry and logout; a login
waiting across restarts, replayed exchange by exchange.
2026-10-28 14:29:33 +00:00
Kristoffer Dalby 38e0e0e016 servertest: add login flag, endpoint, disco rotation and expiry helpers
WithLoginFlags and WithEndpoints shape what a client sends; RotateDisco
logs in again on a new disco key and leaves an auth URL waiting;
SetExpirySooner asks for an earlier key expiry.
2026-10-28 14:29:32 +00:00
Kristoffer Dalby cb7148933b hscontrol, servertest: add v2 OAuth and policy API golden data
OAuth clients, tokens, keys and tag writes by principal, and policy
writes over a baseline, replayed through v1 and v2; a deleted parent
client's key joins real clients.
2026-10-28 14:29:32 +00:00
Kristoffer Dalby 50fc2aadbc policy/v2, servertest: add via port captures
A port-limited ACL entry beside a via grant, and a via tag with no
advertiser. Via HA replays now compare router filters by address.
2026-10-28 14:29:32 +00:00
Kristoffer Dalby 208b617434 policy/v2, servertest: add multi-route router captures
A seven-route router and an exit node under six policies; replayed
through policy, peer map and map stream. Peer map now checked against
SaaS peers.
2026-10-28 14:29:31 +00:00