Kristoffer Dalby 2d04fff605 state: clear Unhealthy when node leaves HA candidate set ...

The legacy routes.PrimaryRoutes.SetRoutes(node, empty) implicitly
deleted the node from the unhealthy set; the snapshot refactor lost
that side-effect, so a probe timeout that landed during a
SetApprovedRoutes(empty) (or just before a Disconnect) left
Unhealthy=true forever. The bit then surfaced in DebugRoutes and
broke TestHASubnetRouterFailover.

Restore the invariant at the write boundaries that drop HA
candidacy (Disconnect, SetApprovedRoutes, UpdateNodeFromMapRequest)
and add a defensive guard in SetNodeUnhealthy so the prober's
post-timeout write cannot install a stale bit when the node has
since left the candidate set.

Updates #3203

2026-04-29 08:02:45 +00:00

..

assertions.go

hscontrol/servertest: add policy, route, ephemeral, and content tests

2026-03-19 07:05:58 +01:00

client.go

servertest: use memnet networking and add WithNodeExpiry option

2026-04-08 13:00:22 +01:00

connect_race_test.go

state: fold primary route election into NodeStore snapshot

2026-04-29 08:02:45 +00:00

consistency_test.go

hscontrol/servertest: add policy, route, ephemeral, and content tests

2026-03-19 07:05:58 +01:00

content_test.go

hscontrol/servertest: add policy, route, ephemeral, and content tests

2026-03-19 07:05:58 +01:00

ephemeral_test.go

state: replace zcache with bounded LRU for auth cache

2026-04-10 14:09:57 +01:00

grants_test.go

integration: remove exit node via grant tests

2026-04-01 14:10:42 +01:00

ha_dynamic_test.go

state: fold primary route election into NodeStore snapshot

2026-04-29 08:02:45 +00:00

ha_health_test.go

state: clear Unhealthy when node leaves HA candidate set

2026-04-29 08:02:45 +00:00

harness.go

hscontrol/servertest: add policy, route, ephemeral, and content tests

2026-03-19 07:05:58 +01:00

issues_test.go

hscontrol/servertest: fix test expectations for eventual consistency

2026-03-19 07:05:58 +01:00

lifecycle_test.go

hscontrol/servertest: expand issue tests to 24 scenarios, surface 4 issues

2026-03-19 07:05:58 +01:00

ping_test.go

noise: reject non-HEAD on PingResponseHandler

2026-04-17 16:31:49 +01:00

policy_test.go

servertest: add regression tests for via grant filter rules

2026-04-01 14:10:42 +01:00

poll_race_test.go

hscontrol/servertest: add race, stress, and poll race tests

2026-03-19 07:05:58 +01:00

race_test.go

hscontrol/servertest: add race, stress, and poll race tests

2026-03-19 07:05:58 +01:00

routes_test.go

servertest, integration: regression tests for HA both-offline recovery

2026-04-29 08:02:45 +00:00

server.go

servertest: use memnet networking and add WithNodeExpiry option

2026-04-08 13:00:22 +01:00

stress_test.go

hscontrol/servertest: add race, stress, and poll race tests

2026-03-19 07:05:58 +01:00

via_compat_test.go

servertest: add via grant map compat tests

2026-04-17 16:31:49 +01:00

via_ha_compat_test.go

servertest: add TestViaGrantHACompat for via+HA compat tests

2026-04-17 16:31:49 +01:00

weather_test.go

hscontrol/servertest: add control plane lifecycle and consistency tests

2026-03-19 07:05:58 +01:00