public/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2025-12-04 11:49:53 +09:00
Code Issues Actions 7 Packages Projects Releases Wiki Activity

fix(mobile): correct share option for local asset (#19233)
Some checks are pending
CodeQL / Analyze (javascript) (push) Waiting to run
Details
CodeQL / Analyze (python) (push) Waiting to run
Details
Docker / pre-job (push) Waiting to run
Details
Docker / Re-Tag ML () (push) Blocked by required conditions
Details
Docker / Re-Tag ML (-armnn) (push) Blocked by required conditions
Details
Docker / Re-Tag ML (-cuda) (push) Blocked by required conditions
Details
Docker / Re-Tag ML (-openvino) (push) Blocked by required conditions
Details
Docker / Re-Tag ML (-rknn) (push) Blocked by required conditions
Details
Docker / Re-Tag ML (-rocm) (push) Blocked by required conditions
Details
Docker / Re-Tag Server () (push) Blocked by required conditions
Details
Docker / Build and Push ML (armnn, linux/arm64, -armnn) (push) Blocked by required conditions
Details
Docker / Build and Push ML (cpu, ) (push) Blocked by required conditions
Details
Docker / Build and Push ML (cuda, linux/amd64, -cuda) (push) Blocked by required conditions
Details
Docker / Build and Push ML (openvino, linux/amd64, -openvino) (push) Blocked by required conditions
Details
Docker / Build and Push ML (rknn, linux/arm64, -rknn) (push) Blocked by required conditions
Details
Docker / Build and Push ML (rocm, linux/amd64, {"linux/amd64": "mich"}, -rocm) (push) Blocked by required conditions
Details
Docker / Build and Push Server (push) Blocked by required conditions
Details
Docker / Docker Build & Push Server Success (push) Blocked by required conditions
Details
Docker / Docker Build & Push ML Success (push) Blocked by required conditions
Details
Docs build / pre-job (push) Waiting to run
Details
Docs build / Docs Build (push) Blocked by required conditions
Details
Static Code Analysis / pre-job (push) Waiting to run
Details
Static Code Analysis / Run Dart Code Analysis (push) Blocked by required conditions
Details
Static Code Analysis / zizmor (push) Waiting to run
Details
Test / pre-job (push) Waiting to run
Details
Test / Test & Lint Server (push) Blocked by required conditions
Details
Test / Unit Test CLI (push) Blocked by required conditions
Details
Test / Unit Test CLI (Windows) (push) Blocked by required conditions
Details
Test / Lint Web (push) Blocked by required conditions
Details
Test / Test Web (push) Blocked by required conditions
Details
Test / Test i18n (push) Blocked by required conditions
Details
Test / End-to-End Lint (push) Blocked by required conditions
Details
Test / Medium Tests (Server) (push) Blocked by required conditions
Details
Test / End-to-End Tests (Server & CLI) (ubuntu-24.04-arm) (push) Blocked by required conditions
Details
Test / End-to-End Tests (Server & CLI) (ubuntu-latest) (push) Blocked by required conditions
Details
Test / End-to-End Tests (Web) (ubuntu-24.04-arm) (push) Blocked by required conditions
Details
Test / End-to-End Tests (Web) (ubuntu-latest) (push) Blocked by required conditions
Details
Test / End-to-End Tests Success (push) Blocked by required conditions
Details
Test / Unit Test Mobile (push) Blocked by required conditions
Details
Test / Unit Test ML (push) Blocked by required conditions
Details
Test / .github Files Formatting (push) Blocked by required conditions
Details
Test / ShellCheck (push) Waiting to run
Details
Test / OpenAPI Clients (push) Waiting to run
Details
Test / SQL Schema Checks (push) Waiting to run
Details

Browse Source
This commit is contained in:
Alex
2025-06-17 15:56:42 -05:00
committed by GitHub
parent c6641d4859
commit 06f1d0dc4d
2 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
mobile/lib/services/share.service.dart
View File

@@ -30,7 +30,7 @@ class ShareService {
for (var asset in assets) { for (var asset in assets) {
if (asset.isLocal) { if (asset.isLocal) {
// Prefer local assets to share // Prefer local assets to share
File? f = await asset.local!.file; File? f = await asset.local!.originFile;
downloadedXFiles.add(XFile(f!.path)); downloadedXFiles.add(XFile(f!.path));
} else if (asset.isRemote) { } else if (asset.isRemote) {
// Download remote asset otherwise // Download remote asset otherwise

17
mobile/lib/widgets/asset_grid/control_bottom_app_bar.dart
View File

@@ -131,15 +131,14 @@ class ControlBottomAppBar extends HookConsumerWidget {
List<Widget> renderActionButtons() { List<Widget> renderActionButtons() {
return [ return [
if (hasRemote) ControlBoxButton(
ControlBoxButton( iconData: Platform.isAndroid
iconData: Platform.isAndroid ? Icons.share_rounded
? Icons.share_rounded : Icons.ios_share_rounded,
: Icons.ios_share_rounded, label: "share".tr(),
label: "share".tr(), onPressed: enabled ? () => onShare(true) : null,
onPressed: enabled ? () => onShare(true) : null, ),
), if (!isInLockedView && hasRemote)
if (!isInLockedView)
ControlBoxButton( ControlBoxButton(
iconData: Icons.link_rounded, iconData: Icons.link_rounded,
label: "share_link".tr(), label: "share_link".tr(),