public/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2025-11-21 21:40:41 +09:00
Code Issues Actions 7 Packages Projects Releases Wiki Activity

fix(mobile): Dismissible menus (#14192)
Some checks are pending
CodeQL / Analyze (javascript) (push) Waiting to run
Details
CodeQL / Analyze (python) (push) Waiting to run
Details
Docker / pre-job (push) Waiting to run
Details
Docker / Re-Tag ML () (push) Blocked by required conditions
Details
Docker / Re-Tag ML (-armnn) (push) Blocked by required conditions
Details
Docker / Re-Tag ML (-cuda) (push) Blocked by required conditions
Details
Docker / Re-Tag ML (-openvino) (push) Blocked by required conditions
Details
Docker / Re-Tag Server () (push) Blocked by required conditions
Details
Docker / Build and Push ML (armnn, linux/arm64, -armnn) (push) Blocked by required conditions
Details
Docker / Build and Push ML (cpu, linux/amd64,linux/arm64) (push) Blocked by required conditions
Details
Docker / Build and Push ML (cuda, linux/amd64, -cuda) (push) Blocked by required conditions
Details
Docker / Build and Push ML (openvino, linux/amd64, -openvino) (push) Blocked by required conditions
Details
Docker / Build and Push Server (cpu, linux/amd64,linux/arm64) (push) Blocked by required conditions
Details
Docker / Docker Build & Push Server Success (push) Blocked by required conditions
Details
Docker / Docker Build & Push ML Success (push) Blocked by required conditions
Details
Docs build / pre-job (push) Waiting to run
Details
Docs build / Docs Build (push) Blocked by required conditions
Details
Static Code Analysis / pre-job (push) Waiting to run
Details
Static Code Analysis / Run Dart Code Analysis (push) Blocked by required conditions
Details
Test / pre-job (push) Waiting to run
Details
Test / Test & Lint Server (push) Blocked by required conditions
Details
Test / Unit Test CLI (push) Blocked by required conditions
Details
Test / Unit Test CLI (Windows) (push) Blocked by required conditions
Details
Test / Test & Lint Web (push) Blocked by required conditions
Details
Test / End-to-End Lint (push) Blocked by required conditions
Details
Test / Medium Tests (Server) (push) Blocked by required conditions
Details
Test / End-to-End Tests (Server & CLI) (push) Blocked by required conditions
Details
Test / End-to-End Tests (Web) (push) Blocked by required conditions
Details
Test / Unit Test Mobile (push) Blocked by required conditions
Details
Test / Unit Test ML (push) Blocked by required conditions
Details
Test / ShellCheck (push) Waiting to run
Details
Test / OpenAPI Clients (push) Waiting to run
Details
Test / TypeORM Checks (push) Waiting to run
Details

Browse Source 
* chore(mobile): make all search filters dismissible

* chore(mobile): make ImmichAppBarDialog dismissible

---------

Co-authored-by: Alex <alex.tran1502@gmail.com>
This commit is contained in:
John Stef
2024-11-18 18:06:07 +02:00
committed by GitHub
parent 6b5defc27b
commit 41f138d3c8
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
mobile/lib/pages/search/search.page.dart
View File

@@ -187,7 +187,7 @@ class SearchPage extends HookConsumerWidget {
showFilterBottomSheet( showFilterBottomSheet(
context: context, context: context,
isScrollControlled: true, isScrollControlled: true,
isDismissible: false, isDismissible: true,
child: FilterBottomSheetScaffold( child: FilterBottomSheetScaffold(
title: 'search_filter_location_title'.tr(), title: 'search_filter_location_title'.tr(),
onSearch: search, onSearch: search,
@@ -238,7 +238,7 @@ class SearchPage extends HookConsumerWidget {
showFilterBottomSheet( showFilterBottomSheet(
context: context, context: context,
isScrollControlled: true, isScrollControlled: true,
isDismissible: false, isDismissible: true,
child: FilterBottomSheetScaffold( child: FilterBottomSheetScaffold(
title: 'search_filter_camera_title'.tr(), title: 'search_filter_camera_title'.tr(),
onSearch: search, onSearch: search,

1
mobile/lib/widgets/common/app_bar_dialog/app_bar_dialog.dart
View File

@@ -259,6 +259,7 @@ class ImmichAppBarDialog extends HookConsumerWidget {
} }
return Dismissible( return Dismissible(
behavior: HitTestBehavior.translucent,
direction: DismissDirection.down, direction: DismissDirection.down,
onDismissed: (_) => Navigator.of(context).pop(), onDismissed: (_) => Navigator.of(context).pop(),
key: const Key('app_bar_dialog'), key: const Key('app_bar_dialog'),