public/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2025-11-20 14:52:40 +09:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

fix(mobile): deeplinking to asset view while viewer is already open (#19812)
Some checks are pending
CodeQL / Analyze (javascript) (push) Waiting to run
Details
CodeQL / Analyze (python) (push) Waiting to run
Details
Docker / pre-job (push) Waiting to run
Details
Docker / Re-Tag ML () (push) Blocked by required conditions
Details
Docker / Re-Tag ML (-armnn) (push) Blocked by required conditions
Details
Docker / Re-Tag ML (-cuda) (push) Blocked by required conditions
Details
Docker / Re-Tag ML (-openvino) (push) Blocked by required conditions
Details
Docker / Re-Tag ML (-rknn) (push) Blocked by required conditions
Details
Docker / Re-Tag ML (-rocm) (push) Blocked by required conditions
Details
Docker / Re-Tag Server () (push) Blocked by required conditions
Details
Docker / Build and Push ML (armnn, linux/arm64, -armnn) (push) Blocked by required conditions
Details
Docker / Build and Push ML (cpu, ) (push) Blocked by required conditions
Details
Docker / Build and Push ML (cuda, linux/amd64, -cuda) (push) Blocked by required conditions
Details
Docker / Build and Push ML (openvino, linux/amd64, -openvino) (push) Blocked by required conditions
Details
Docker / Build and Push ML (rknn, linux/arm64, -rknn) (push) Blocked by required conditions
Details
Docker / Build and Push ML (rocm, linux/amd64, {"linux/amd64": "mich"}, -rocm) (push) Blocked by required conditions
Details
Docker / Build and Push Server (push) Blocked by required conditions
Details
Docker / Docker Build & Push Server Success (push) Blocked by required conditions
Details
Docker / Docker Build & Push ML Success (push) Blocked by required conditions
Details
Docs build / pre-job (push) Waiting to run
Details
Docs build / Docs Build (push) Blocked by required conditions
Details
Static Code Analysis / pre-job (push) Waiting to run
Details
Static Code Analysis / Run Dart Code Analysis (push) Blocked by required conditions
Details
Static Code Analysis / zizmor (push) Waiting to run
Details
Test / pre-job (push) Waiting to run
Details
Test / Test & Lint Server (push) Blocked by required conditions
Details
Test / Unit Test CLI (push) Blocked by required conditions
Details
Test / Unit Test CLI (Windows) (push) Blocked by required conditions
Details
Test / Lint Web (push) Blocked by required conditions
Details
Test / Test Web (push) Blocked by required conditions
Details
Test / Test i18n (push) Blocked by required conditions
Details
Test / End-to-End Lint (push) Blocked by required conditions
Details
Test / Medium Tests (Server) (push) Blocked by required conditions
Details
Test / End-to-End Tests (Server & CLI) (ubuntu-24.04-arm) (push) Blocked by required conditions
Details
Test / End-to-End Tests (Server & CLI) (ubuntu-latest) (push) Blocked by required conditions
Details
Test / End-to-End Tests (Web) (ubuntu-24.04-arm) (push) Blocked by required conditions
Details
Test / End-to-End Tests (Web) (ubuntu-latest) (push) Blocked by required conditions
Details
Test / End-to-End Tests Success (push) Blocked by required conditions
Details
Test / Unit Test Mobile (push) Blocked by required conditions
Details
Test / Unit Test ML (push) Blocked by required conditions
Details
Test / .github Files Formatting (push) Blocked by required conditions
Details
Test / ShellCheck (push) Waiting to run
Details
Test / OpenAPI Clients (push) Waiting to run
Details
Test / SQL Schema Checks (push) Waiting to run
Details

Browse Source 
* initial attempt at new guard

* do not resolve the route when replaced

* Update gallery_guard.dart comment

---------

Co-authored-by: shenlong-tanwen <139912620+shalong-tanwen@users.noreply.github.com>
This commit is contained in:
Brandon Wees
2025-07-08 10:50:59 -05:00
committed by GitHub
parent a556de67b0
commit d03eb87058
3 changed files with 35 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
mobile/lib/routing/router.dart
View File

@@ -91,6 +91,7 @@ import 'package:immich_mobile/routing/auth_guard.dart';
import 'package:immich_mobile/routing/backup_permission_guard.dart';
import 'package:immich_mobile/routing/custom_transition_builders.dart';
import 'package:immich_mobile/routing/duplicate_guard.dart';
import 'package:immich_mobile/routing/gallery_guard.dart';
import 'package:immich_mobile/routing/locked_guard.dart';
import 'package:immich_mobile/services/api.service.dart';
import 'package:immich_mobile/services/local_auth.service.dart';
@@ -116,6 +117,7 @@ class AppRouter extends RootStackRouter {
late final DuplicateGuard _duplicateGuard;
late final BackupPermissionGuard _backupPermissionGuard;
late final LockedGuard _lockedGuard;
late final GalleryGuard _galleryGuard;
AppRouter(
ApiService apiService,
@@ -128,6 +130,7 @@ class AppRouter extends RootStackRouter {
_lockedGuard =
LockedGuard(apiService, secureStorageService, localAuthService);
_backupPermissionGuard = BackupPermissionGuard(galleryPermissionNotifier);
_galleryGuard = const GalleryGuard();
}
@override
@@ -197,7 +200,7 @@ class AppRouter extends RootStackRouter {
),
CustomRoute(
page: GalleryViewerRoute.page,
guards: [_authGuard, _duplicateGuard],
guards: [_authGuard, _galleryGuard],
transitionsBuilder: CustomTransitionsBuilders.zoomedPage,
),
AutoRoute(