public/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2025-12-08 14:23:56 +09:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(mobile): thumbnail requests not being cancelled (#21331)
Some checks are pending
CodeQL / Analyze (javascript) (push) Waiting to run
Details
CodeQL / Analyze (python) (push) Waiting to run
Details
Docker / pre-job (push) Waiting to run
Details
Docker / Re-Tag ML () (push) Blocked by required conditions
Details
Docker / Re-Tag ML (-armnn) (push) Blocked by required conditions
Details
Docker / Re-Tag ML (-cuda) (push) Blocked by required conditions
Details
Docker / Re-Tag ML (-openvino) (push) Blocked by required conditions
Details
Docker / Re-Tag ML (-rknn) (push) Blocked by required conditions
Details
Docker / Re-Tag ML (-rocm) (push) Blocked by required conditions
Details
Docker / Re-Tag Server () (push) Blocked by required conditions
Details
Docker / Build and Push ML (armnn, linux/arm64, -armnn) (push) Blocked by required conditions
Details
Docker / Build and Push ML (cpu, ) (push) Blocked by required conditions
Details
Docker / Build and Push ML (cuda, linux/amd64, -cuda) (push) Blocked by required conditions
Details
Docker / Build and Push ML (openvino, linux/amd64, -openvino) (push) Blocked by required conditions
Details
Docker / Build and Push ML (rknn, linux/arm64, -rknn) (push) Blocked by required conditions
Details
Docker / Build and Push ML (rocm, linux/amd64, {"linux/amd64": "mich"}, -rocm) (push) Blocked by required conditions
Details
Docker / Build and Push Server (push) Blocked by required conditions
Details
Docker / Docker Build & Push Server Success (push) Blocked by required conditions
Details
Docker / Docker Build & Push ML Success (push) Blocked by required conditions
Details
Docs build / pre-job (push) Waiting to run
Details
Docs build / Docs Build (push) Blocked by required conditions
Details
Static Code Analysis / pre-job (push) Waiting to run
Details
Static Code Analysis / Run Dart Code Analysis (push) Blocked by required conditions
Details
Static Code Analysis / zizmor (push) Waiting to run
Details
Test / pre-job (push) Waiting to run
Details
Test / Test & Lint Server (push) Blocked by required conditions
Details
Test / Unit Test CLI (push) Blocked by required conditions
Details
Test / Unit Test CLI (Windows) (push) Blocked by required conditions
Details
Test / Lint Web (push) Blocked by required conditions
Details
Test / Test Web (push) Blocked by required conditions
Details
Test / Test i18n (push) Blocked by required conditions
Details
Test / End-to-End Lint (push) Blocked by required conditions
Details
Test / Medium Tests (Server) (push) Blocked by required conditions
Details
Test / End-to-End Tests (Server & CLI) (ubuntu-24.04-arm) (push) Blocked by required conditions
Details
Test / End-to-End Tests (Server & CLI) (ubuntu-latest) (push) Blocked by required conditions
Details
Test / End-to-End Tests (Web) (ubuntu-24.04-arm) (push) Blocked by required conditions
Details
Test / End-to-End Tests (Web) (ubuntu-latest) (push) Blocked by required conditions
Details
Test / End-to-End Tests Success (push) Blocked by required conditions
Details
Test / Unit Test Mobile (push) Blocked by required conditions
Details
Test / Unit Test ML (push) Blocked by required conditions
Details
Test / .github Files Formatting (push) Blocked by required conditions
Details
Test / ShellCheck (push) Waiting to run
Details
Test / OpenAPI Clients (push) Waiting to run
Details
Test / SQL Schema Checks (push) Waiting to run
Details

Browse Source 
* fix requests not being cancelled

* handle thumbhash
This commit is contained in:
Mert
2025-08-27 17:40:45 -04:00
committed by GitHub
parent ae104ad7cc
commit dc6ac3aaec
5 changed files with 27 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
mobile/lib/presentation/widgets/images/thumbnail.widget.dart
View File

@@ -4,6 +4,7 @@ import 'package:flutter/material.dart';
import 'package:immich_mobile/domain/models/asset/base_asset.model.dart';
import 'package:immich_mobile/extensions/build_context_extensions.dart';
import 'package:immich_mobile/extensions/theme_extensions.dart';
import 'package:immich_mobile/presentation/widgets/images/image_provider.dart';
import 'package:immich_mobile/presentation/widgets/images/local_image_provider.dart';
import 'package:immich_mobile/presentation/widgets/images/remote_image_provider.dart';
import 'package:immich_mobile/presentation/widgets/images/thumb_hash_provider.dart';
@@ -235,6 +236,16 @@ class _ThumbnailState extends State<Thumbnail> with SingleTickerProviderStateMix
@override
void dispose() {
final imageProvider = widget.imageProvider;
if (imageProvider is CancellableImageProvider) {
imageProvider.cancel();
}
final thumbhashProvider = widget.thumbhashProvider;
if (thumbhashProvider is CancellableImageProvider) {
thumbhashProvider.cancel();
}
_fadeController.removeStatusListener(_onAnimationStatusChanged);
_fadeController.dispose();
_stopListeningToStream();