public/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2025-11-21 03:10:44 +09:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

fix: memory jarring hero animation (#20030)
Some checks failed
Docker / pre-job (push) Waiting to run
Details
Docker / Re-Tag ML () (push) Blocked by required conditions
Details
Docker / Re-Tag ML (-armnn) (push) Blocked by required conditions
Details
Docker / Re-Tag ML (-cuda) (push) Blocked by required conditions
Details
Docker / Re-Tag ML (-openvino) (push) Blocked by required conditions
Details
Docker / Re-Tag ML (-rknn) (push) Blocked by required conditions
Details
Docker / Re-Tag ML (-rocm) (push) Blocked by required conditions
Details
Docker / Re-Tag Server () (push) Blocked by required conditions
Details
Docker / Build and Push ML (armnn, linux/arm64, -armnn) (push) Blocked by required conditions
Details
Docker / Build and Push ML (cpu, ) (push) Blocked by required conditions
Details
Docker / Build and Push ML (cuda, linux/amd64, -cuda) (push) Blocked by required conditions
Details
Docker / Build and Push ML (openvino, linux/amd64, -openvino) (push) Blocked by required conditions
Details
Docker / Build and Push ML (rknn, linux/arm64, -rknn) (push) Blocked by required conditions
Details
Docker / Build and Push ML (rocm, linux/amd64, {"linux/amd64": "mich"}, -rocm) (push) Blocked by required conditions
Details
Docker / Build and Push Server (push) Blocked by required conditions
Details
Docker / Docker Build & Push Server Success (push) Blocked by required conditions
Details
Docker / Docker Build & Push ML Success (push) Blocked by required conditions
Details
Docs build / pre-job (push) Waiting to run
Details
Docs build / Docs Build (push) Blocked by required conditions
Details
Static Code Analysis / pre-job (push) Waiting to run
Details
Static Code Analysis / Run Dart Code Analysis (push) Blocked by required conditions
Details
Static Code Analysis / zizmor (push) Waiting to run
Details
Test / pre-job (push) Waiting to run
Details
Test / Test & Lint Server (push) Blocked by required conditions
Details
Test / Unit Test CLI (push) Blocked by required conditions
Details
Test / Unit Test CLI (Windows) (push) Blocked by required conditions
Details
Test / Lint Web (push) Blocked by required conditions
Details
Test / Test Web (push) Blocked by required conditions
Details
Test / Test i18n (push) Blocked by required conditions
Details
Test / End-to-End Lint (push) Blocked by required conditions
Details
Test / Medium Tests (Server) (push) Blocked by required conditions
Details
Test / End-to-End Tests (Server & CLI) (ubuntu-24.04-arm) (push) Blocked by required conditions
Details
Test / End-to-End Tests (Server & CLI) (ubuntu-latest) (push) Blocked by required conditions
Details
Test / End-to-End Tests (Web) (ubuntu-24.04-arm) (push) Blocked by required conditions
Details
Test / End-to-End Tests (Web) (ubuntu-latest) (push) Blocked by required conditions
Details
Test / End-to-End Tests Success (push) Blocked by required conditions
Details
Test / Unit Test Mobile (push) Blocked by required conditions
Details
Test / Unit Test ML (push) Blocked by required conditions
Details
Test / .github Files Formatting (push) Blocked by required conditions
Details
Test / ShellCheck (push) Waiting to run
Details
Test / OpenAPI Clients (push) Waiting to run
Details
Test / SQL Schema Checks (push) Waiting to run
Details
CodeQL / Analyze (javascript) (push) Has been cancelled
Details
CodeQL / Analyze (python) (push) Has been cancelled
Details

Browse Source 
* fix: memory jarring hero animation

* remove other hero
This commit is contained in:
Alex
2025-07-20 13:56:53 -05:00
committed by GitHub
parent 261818ddd9
commit dee6d072fb
2 changed files with 22 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
mobile/lib/presentation/widgets/memory/memory_card.widget.dart
View File

@@ -57,30 +57,24 @@ class DriftMemoryCard extends StatelessWidget {
}
if (asset.isImage) {
return Hero(
tag: 'memory-${asset.id}',
child: FullImage(
asset,
fit: fit,
size: const Size(double.infinity, double.infinity),
),
return FullImage(
asset,
fit: fit,
size: const Size(double.infinity, double.infinity),
);
} else {
return Hero(
tag: 'memory-${asset.id}',
child: SizedBox(
width: context.width,
height: context.height,
child: NativeVideoViewer(
key: ValueKey(asset.id),
asset: asset,
showControls: false,
playbackDelayFactor: 2,
image: FullImage(
asset,
size: Size(context.width, context.height),
fit: BoxFit.contain,
),
return SizedBox(
width: context.width,
height: context.height,
child: NativeVideoViewer(
key: ValueKey(asset.id),
asset: asset,
showControls: false,
playbackDelayFactor: 2,
image: FullImage(
asset,
size: Size(context.width, context.height),
fit: BoxFit.contain,
),
),
);

15
mobile/lib/presentation/widgets/memory/memory_lane.widget.dart
View File

@@ -79,15 +79,12 @@ class DriftMemoryCard extends ConsumerWidget {
Colors.black.withValues(alpha: 0.2),
BlendMode.darken,
),
child: Hero(
tag: 'memory-${memory.assets[0].id}',
child: SizedBox(
width: 205,
height: 200,
child: Thumbnail(
remoteId: memory.assets[0].id,
fit: BoxFit.cover,
),
child: SizedBox(
width: 205,
height: 200,
child: Thumbnail(
remoteId: memory.assets[0].id,
fit: BoxFit.cover,
),
),
),