fix: memory jarring hero animation (#20030)
Some checks failed
Docker / pre-job (push) Waiting to run
Docker / Re-Tag ML () (push) Blocked by required conditions
Docker / Re-Tag ML (-armnn) (push) Blocked by required conditions
Docker / Re-Tag ML (-cuda) (push) Blocked by required conditions
Docker / Re-Tag ML (-openvino) (push) Blocked by required conditions
Docker / Re-Tag ML (-rknn) (push) Blocked by required conditions
Docker / Re-Tag ML (-rocm) (push) Blocked by required conditions
Docker / Re-Tag Server () (push) Blocked by required conditions
Docker / Build and Push ML (armnn, linux/arm64, -armnn) (push) Blocked by required conditions
Docker / Build and Push ML (cpu, ) (push) Blocked by required conditions
Docker / Build and Push ML (cuda, linux/amd64, -cuda) (push) Blocked by required conditions
Docker / Build and Push ML (openvino, linux/amd64, -openvino) (push) Blocked by required conditions
Docker / Build and Push ML (rknn, linux/arm64, -rknn) (push) Blocked by required conditions
Docker / Build and Push ML (rocm, linux/amd64, {"linux/amd64": "mich"}, -rocm) (push) Blocked by required conditions
Docker / Build and Push Server (push) Blocked by required conditions
Docker / Docker Build & Push Server Success (push) Blocked by required conditions
Docker / Docker Build & Push ML Success (push) Blocked by required conditions
Docs build / pre-job (push) Waiting to run
Docs build / Docs Build (push) Blocked by required conditions
Static Code Analysis / pre-job (push) Waiting to run
Static Code Analysis / Run Dart Code Analysis (push) Blocked by required conditions
Static Code Analysis / zizmor (push) Waiting to run
Test / pre-job (push) Waiting to run
Test / Test & Lint Server (push) Blocked by required conditions
Test / Unit Test CLI (push) Blocked by required conditions
Test / Unit Test CLI (Windows) (push) Blocked by required conditions
Test / Lint Web (push) Blocked by required conditions
Test / Test Web (push) Blocked by required conditions
Test / Test i18n (push) Blocked by required conditions
Test / End-to-End Lint (push) Blocked by required conditions
Test / Medium Tests (Server) (push) Blocked by required conditions
Test / End-to-End Tests (Server & CLI) (ubuntu-24.04-arm) (push) Blocked by required conditions
Test / End-to-End Tests (Server & CLI) (ubuntu-latest) (push) Blocked by required conditions
Test / End-to-End Tests (Web) (ubuntu-24.04-arm) (push) Blocked by required conditions
Test / End-to-End Tests (Web) (ubuntu-latest) (push) Blocked by required conditions
Test / End-to-End Tests Success (push) Blocked by required conditions
Test / Unit Test Mobile (push) Blocked by required conditions
Test / Unit Test ML (push) Blocked by required conditions
Test / .github Files Formatting (push) Blocked by required conditions
Test / ShellCheck (push) Waiting to run
Test / OpenAPI Clients (push) Waiting to run
Test / SQL Schema Checks (push) Waiting to run
CodeQL / Analyze (javascript) (push) Has been cancelled
CodeQL / Analyze (python) (push) Has been cancelled

* fix: memory jarring hero animation

* remove other hero
This commit is contained in:
Alex
2025-07-20 13:56:53 -05:00
committed by GitHub
parent 261818ddd9
commit dee6d072fb
2 changed files with 22 additions and 31 deletions

View File

@@ -57,18 +57,13 @@ class DriftMemoryCard extends StatelessWidget {
} }
if (asset.isImage) { if (asset.isImage) {
return Hero( return FullImage(
tag: 'memory-${asset.id}',
child: FullImage(
asset, asset,
fit: fit, fit: fit,
size: const Size(double.infinity, double.infinity), size: const Size(double.infinity, double.infinity),
),
); );
} else { } else {
return Hero( return SizedBox(
tag: 'memory-${asset.id}',
child: SizedBox(
width: context.width, width: context.width,
height: context.height, height: context.height,
child: NativeVideoViewer( child: NativeVideoViewer(
@@ -82,7 +77,6 @@ class DriftMemoryCard extends StatelessWidget {
fit: BoxFit.contain, fit: BoxFit.contain,
), ),
), ),
),
); );
} }
}, },

View File

@@ -79,8 +79,6 @@ class DriftMemoryCard extends ConsumerWidget {
Colors.black.withValues(alpha: 0.2), Colors.black.withValues(alpha: 0.2),
BlendMode.darken, BlendMode.darken,
), ),
child: Hero(
tag: 'memory-${memory.assets[0].id}',
child: SizedBox( child: SizedBox(
width: 205, width: 205,
height: 200, height: 200,
@@ -90,7 +88,6 @@ class DriftMemoryCard extends ConsumerWidget {
), ),
), ),
), ),
),
Positioned( Positioned(
bottom: 16, bottom: 16,
left: 16, left: 16,