Merge pull request #329: Delete a room's messages in a job, one transaction each

Reviewed and merged by GPT on behalf of DHH.

test/controllers/rooms/directs_controller_test.rb

@@ -25,8 +25,10 @@ class Rooms::DirectsControllerTest < ActionDispatch::IntegrationTest
     sign_in :kevin
 
     assert_difference -> { Room.count }, -1 do
-      delete rooms_direct_url(rooms(:david_and_kevin))
-      assert_redirected_to root_url
+      perform_enqueued_jobs do
+        delete rooms_direct_url(rooms(:david_and_kevin))
+        assert_redirected_to root_url
+      end
     end
   end
 

test/controllers/rooms_controller_test.rb

@@ -83,11 +83,24 @@ class RoomsControllerTest < ActionDispatch::IntegrationTest
   test "destroy" do
     assert_turbo_stream_broadcasts :rooms, count: 1 do
       assert_difference -> { Room.count }, -1 do
-        delete room_url(rooms(:designers))
+        perform_enqueued_jobs { delete room_url(rooms(:designers)) }
       end
     end
   end
 
+  test "destroy takes the room away from its members at once and leaves its messages to a job" do
+    room = rooms(:designers)
+    member_ids = room.memberships.pluck(:user_id)
+
+    assert_enqueued_with(job: Room::DestroyJob, args: [ room, member_ids ]) do
+      assert_no_difference -> { Message.count } do
+        delete room_url(room)
+        assert_redirected_to root_url
+      end
+    end
+    assert_empty room.memberships.reload
+  end
+
   test "destroy only allowed for creators or those who can administer" do
     sign_in :jz
 
@@ -99,7 +112,7 @@ class RoomsControllerTest < ActionDispatch::IntegrationTest
     rooms(:designers).update! creator: users(:jz)
 
     assert_difference -> { Room.count }, -1 do
-      delete room_url(rooms(:designers))
+      perform_enqueued_jobs { delete room_url(rooms(:designers)) }
     end
   end