public/once-campfire
1
0
Fork 0
mirror of https://github.com/basecamp/once-campfire.git synced 2026-10-03 21:33:37 +09:00
Code Issues Packages Projects Releases Wiki Activity

Fix Codex's code review comments

Browse Source
This commit is contained in:
Stanko K.R.
2026-07-20 18:37:43 +02:00
parent c38e77a897
commit 1bb7ef7c17
8 changed files with 29 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/helpers/content_filters.rb
+1 -1
View File
@@ -9,5 +9,5 @@ module ContentFilters
EDITOR_FORMATTING_TAGS = %w[ s u mark ]
EDITOR_FORMATTING_ATTRIBUTES = %w[ data-language ]
TextMessagePresentationFilters = ActionText::Content::Filters.new(RemoveSoloUnfurledLinkText, StyleUnfurledTwitterAvatars, SanitizeTags, SanitizeAttributes)
TextMessagePresentationFilters = ActionText::Content::Filters.new(RemoveSoloUnfurledLinkText, SanitizeTags, SanitizeAttributes)
end
app/helpers/content_filters/style_unfurled_twitter_avatars.rb
-26
View File
@@ -1,26 +0,0 @@
class ContentFilters::StyleUnfurledTwitterAvatars < ActionText::Content::Filter
def applicable?
unfurled_twitter_avatars.present?
end
def apply
fragment.update do |source|
div = source.at_css("div")
div["class"] = UNFURLED_TWITTER_AVATAR_CSS_CLASS
end
end
private
UNFURLED_TWITTER_AVATAR_CSS_CLASS = "cf-twitter-avatar"
TWITTER_AVATAR_URL_PREFIX = "https://pbs.twimg.com/profile_images"
def unfurled_twitter_avatars
fragment.find_all(opengraph_css_selector).select do |node|
ActionText::Attachment::OpengraphEmbed.from_node(node)&.url.to_s.start_with?(TWITTER_AVATAR_URL_PREFIX)
end
end
def opengraph_css_selector
"action-text-attachment[@content-type='#{ActionText::Attachment::OpengraphEmbed::OPENGRAPH_EMBED_CONTENT_TYPE}']"
end
end