mirror of
https://github.com/basecamp/once-campfire.git
synced 2026-10-10 08:40:08 +09:00
Reject a QR code request that can't become a QR code
QrCodeController#show is open without signing in and decodes its id as URL-safe base64. An id that isn't base64 raised ArgumentError, and a URL longer than a QR code holds raised QRCodeRunTimeError, so both answered 500 and reached error reporting as server errors. Answer them with 400 instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LwoX7uRy5vFZSNKJhSqMSG
This commit is contained in:
@@ -7,5 +7,7 @@ class QrCodeController < ApplicationController
|
||||
|
||||
expires_in 1.year, public: true
|
||||
render plain: qr_code, content_type: "image/svg+xml"
|
||||
rescue ArgumentError, RQRCodeCore::QRCodeRunTimeError
|
||||
head :bad_request
|
||||
end
|
||||
end
|
||||
|
||||
Reference in New Issue
Block a user