public/once-campfire
1
0
Fork 0
mirror of https://github.com/basecamp/once-campfire.git synced 2026-08-29 01:52:38 +09:00
Code Issues Packages Projects Releases Wiki Activity

Fix Codex's code review comments

Browse Source
This commit is contained in:
Stanko K.R.
2026-07-20 18:37:43 +02:00
parent bfb57a23f9
commit 54a507a852
8 changed files with 29 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/javascript/controllers/unfurl_controller.js
+3 -3
View File
@@ -5,7 +5,7 @@ import { escapeHTML } from "helpers/dom_helpers"
const OPENGRAPH_EMBED_CONTENT_TYPE = "application/vnd.actiontext.opengraph-embed"
const UNFURLED_TWITTER_AVATAR_CSS_CLASS = "cf-twitter-avatar"
const UNFURLED_TWITTER_AVATAR_CSS_CLASS = "og-embed--twitter-avatar"
const TWITTER_AVATAR_URL_PREFIX = "https://pbs.twimg.com/profile_images"
export default class extends Controller {
@@ -50,8 +50,8 @@ export default class extends Controller {
}
#opengraphEmbedHTML({ title, href, image, description }) {
return `<actiontext-opengraph-embed class="${this.#embedClass(image)}">
<div class="og-embed gap">
return `<actiontext-opengraph-embed>
<div class="og-embed gap ${this.#embedClass(image)}">
<div class="og-embed__content">
<div class="og-embed__title">
<a href="${escapeHTML(href)}" rel="noreferrer" target="_blank">${escapeHTML(truncateString(title, 280))}</a>