public/once-campfire
1
0
Fork 0
mirror of https://github.com/basecamp/once-campfire.git synced 2026-10-09 00:00:12 +09:00
Code Issues Packages Projects Releases Wiki Activity

Give a video a poster only once its poster variant is made

Browse Source 
ActiveStorage::Preview#processed? is true as soon as ffmpeg's frame is attached, but the poster is a
variant of that frame and can fail on its own: the POST rescues a Vips::Error and leaves the frame
attached. The view then emitted the poster's URL, and every view retried the resize. It now checks the
variant too, from the variant records with_attached_attachment already preloads.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Bj8KnxpTf9sj2Ysa8aLAVa
This commit is contained in:
Marcello Costagliola
2026-10-06 15:34:46 +02:00
parent 9912e63d69
commit 5f198146e8
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/helpers/messages/attachment_presentation.rb
+2 -1
View File
@@ -40,9 +40,10 @@ class Messages::AttachmentPresentation
end
end
# A preview is processed once the frame is drawn, but the poster is a variant of that frame, which can fail on its own.
def video_poster_url
poster = message.attachment.preview(:poster)
url_for(poster) if poster.processed?
url_for(poster) if poster.processed? && poster.image.variant(poster.variation).processed?
end
def lightboxed_image_preview_tag