public/once-campfire
1
0
Fork 0
mirror of https://github.com/basecamp/once-campfire.git synced 2026-10-09 00:00:12 +09:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #324: Rewrite a message's search entry only when its body or attachment changes

Browse Source 
Reviewed and merged by GPT on behalf of DHH.
This commit is contained in:
GPT on behalf of DHH
2026-10-07 10:32:12 +02:00
parent 819b3896fb e07da58668
commit 6ad4735b19
2 changed files with 41 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/models/message/searchable_test.rb
+33
View File
@@ -1,6 +1,9 @@
require "test_helper"
require "active_record/testing/query_assertions"
class Message::SearchableTest < ActiveSupport::TestCase
include ActionDispatch::TestProcess, ActiveRecord::Assertions::QueryAssertions
test "message body is indexed and searchable" do
message = rooms(:designers).messages.create! body: "My hovercraft is full of eels", client_message_id: "earth", creator: users(:david)
assert_equal [ message ], rooms(:designers).messages.search("eel")
@@ -12,6 +15,36 @@ class Message::SearchableTest < ActiveSupport::TestCase
assert_equal [], rooms(:designers).messages.search("sharks")
end
test "boosting a message leaves the search index alone, whether or not its body is loaded" do
attachment_message = rooms(:designers).messages.create! attachment: fixture_file_upload("moon.jpg", "image/jpeg"), client_message_id: "moon", creator: users(:david)
[ messages(:first), Message.with_rich_text_body.find(messages(:first).id), Message.with_rich_text_body.find(attachment_message.id) ].each do |message|
assert_no_queries_match(/message_search_index/) do
message.boosts.create!(content: "🦞", booster: users(:jason)).destroy!
end
end
end
test "saving a new body replaces the old words in the index" do
message = rooms(:designers).messages.create! body: "My hovercraft is full of eels", client_message_id: "earth", creator: users(:david)
Message.find(message.id).update! body: "My hovercraft is full of sharks"
assert_equal [ message ], rooms(:designers).messages.search("sharks")
assert_equal [], rooms(:designers).messages.search("eels")
Message.find(message.id).body.update! body: "My hovercraft is full of whales"
assert_equal [ message ], rooms(:designers).messages.search("whales")
assert_equal [], rooms(:designers).messages.search("sharks")
end
test "a new attachment replaces the old file name in the index" do
message = rooms(:designers).messages.create! attachment: fixture_file_upload("moon.jpg", "image/jpeg"), client_message_id: "moon", creator: users(:david)
Message.find(message.id).update! attachment: fixture_file_upload("pixel.bmp", "image/bmp")
assert_equal [ message ], rooms(:designers).messages.search("pixel")
assert_equal [], rooms(:designers).messages.search("moon")
end
test "search results are returned in message order" do
messages = [ "first cat", "second cat", "third cat", "cat cat cat" ].map do |body|
rooms(:designers).messages.create! body: body, client_message_id: body, creator: users(:david)