public/once-campfire
1
0
Fork 0
mirror of https://github.com/basecamp/once-campfire.git synced 2026-10-08 15:50:08 +09:00
Code Issues Packages Projects Releases Wiki Activity

Rewrite a message's search entry only when its body is saved

Browse Source 
Boosting and unboosting touch the message, so after_update_commit
rewrote its row in the full-text index with the same text, loading the
rich text again to rebuild it, on every boost. The index only needs a
new row when the rich text body was saved.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0142qgjggdJ2KDdGk7RF9Xm9
This commit is contained in:
Marcello Costagliola
2026-10-05 17:09:46 +02:00
parent 2393f01ba2
commit 78a84a6ab7
2 changed files with 31 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/models/message/searchable_test.rb
+25
View File
@@ -1,6 +1,9 @@
require "test_helper"
require "active_record/testing/query_assertions"
class Message::SearchableTest < ActiveSupport::TestCase
include ActionDispatch::TestProcess, ActiveRecord::Assertions::QueryAssertions
test "message body is indexed and searchable" do
message = rooms(:designers).messages.create! body: "My hovercraft is full of eels", client_message_id: "earth", creator: users(:david)
assert_equal [ message ], rooms(:designers).messages.search("eel")
@@ -12,6 +15,28 @@ class Message::SearchableTest < ActiveSupport::TestCase
assert_equal [], rooms(:designers).messages.search("sharks")
end
test "boosting a message leaves the search index alone, whether or not its body is loaded" do
attachment_message = rooms(:designers).messages.create! attachment: fixture_file_upload("moon.jpg", "image/jpeg"), client_message_id: "moon", creator: users(:david)
[ messages(:first), Message.with_rich_text_body.find(messages(:first).id), Message.with_rich_text_body.find(attachment_message.id) ].each do |message|
assert_no_queries_match(/message_search_index/) do
message.boosts.create!(content: "🦞", booster: users(:jason)).destroy!
end
end
end
test "saving a new body replaces the old words in the index" do
message = rooms(:designers).messages.create! body: "My hovercraft is full of eels", client_message_id: "earth", creator: users(:david)
Message.find(message.id).update! body: "My hovercraft is full of sharks"
assert_equal [ message ], rooms(:designers).messages.search("sharks")
assert_equal [], rooms(:designers).messages.search("eels")
Message.find(message.id).body.update! body: "My hovercraft is full of whales"
assert_equal [ message ], rooms(:designers).messages.search("whales")
assert_equal [], rooms(:designers).messages.search("sharks")
end
test "search results are returned in message order" do
messages = [ "first cat", "second cat", "third cat", "cat cat cat" ].map do |body|
rooms(:designers).messages.create! body: body, client_message_id: body, creator: users(:david)