public/once-campfire
1
0
Fork 0
mirror of https://github.com/basecamp/once-campfire.git synced 2026-10-09 00:00:12 +09:00
Code Issues Packages Projects Releases Wiki Activity

Avoid a double join alias when loading shared sidebar rooms

Browse Source 
Chaining without_direct_rooms with with_ordered_room joined rooms as
`room` while still ordering on `rooms.name`. Load shared rooms in one
scope instead.

Co-authored-by: Thomas Klemm <github@tklemm.eu>
This commit is contained in:
Cursor Agent
2026-10-05 12:36:42 +00:00
parent fbeb1ae993
commit 88fbeedc75
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/controllers/users/sidebars_controller.rb
+1 -1
View File
@@ -4,7 +4,7 @@ class Users::SidebarsController < ApplicationController
def show
visible_memberships = Current.user.memberships.visible
@direct_memberships = visible_memberships.with_direct_rooms
@other_memberships = visible_memberships.without_direct_rooms.with_ordered_room
@other_memberships = visible_memberships.with_ordered_shared_rooms
@direct_placeholder_users = find_direct_placeholder_users
end