From 955d799d1192fe247bdabaa0f8cd170cbe21122a Mon Sep 17 00:00:00 2001 From: Sam Ruby Date: Sun, 4 Oct 2026 20:06:53 -0400 Subject: [PATCH] Find the Edge install icon under images/external install-edge.svg lives in app/assets/images/external/, alongside the other install icons, but the Edge branch of pwa/_install_instructions asked for it at the top level. Propshaft raises MissingAssetError, so a browser the useragent gem reports as Edge got a 500 on the profile page and anywhere else the partial renders. Co-Authored-By: Claude Opus 5.5 --- app/views/pwa/_install_instructions.html.erb | 2 +- test/controllers/users/profiles_controller_test.rb | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/app/views/pwa/_install_instructions.html.erb b/app/views/pwa/_install_instructions.html.erb index d956053..b82ddb2 100644 --- a/app/views/pwa/_install_instructions.html.erb +++ b/app/views/pwa/_install_instructions.html.erb @@ -9,7 +9,7 @@ <% case when platform.edge? %>
    -
  1. Click <%= image_tag "install-edge.svg", alt: "the app available - install Campfire chat button", size: 16 %>in the address bar.
  2. +
  3. Click <%= image_tag "external/install-edge.svg", alt: "the app available - install Campfire chat button", size: 16 %>in the address bar.
  4. Click Install.
<% when platform.chrome? && platform.android? %> diff --git a/test/controllers/users/profiles_controller_test.rb b/test/controllers/users/profiles_controller_test.rb index 1f14953..0331aaf 100644 --- a/test/controllers/users/profiles_controller_test.rb +++ b/test/controllers/users/profiles_controller_test.rb @@ -11,6 +11,13 @@ class Users::ProfilesControllerTest < ActionDispatch::IntegrationTest assert_response :success end + test "show includes install instructions for Edge" do + get user_profile_url, headers: { "User-Agent" => "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.102 Safari/537.36 Edge/18.18363" } + + assert_response :success + assert_select ".pwa__instructions img[src*='install-edge']" + end + test "update" do put user_profile_url, params: { user: { name: "John Doe", bio: "Acrobat" } }