mirror of
https://github.com/basecamp/once-campfire.git
synced 2026-09-17 05:52:20 +09:00
Disable libvips unfuzzed operations (#226)
and add test coverage for (un)supported file types. The avatar and logo variants move into the models and return nil for content types that are no longer variable, so the controllers fall back to the initials avatar and stock logo icon instead of raising `ActiveStorage::InvariableError`.
This commit is contained in:
@@ -9,8 +9,7 @@ class Users::AvatarsController < ApplicationController
|
||||
if stale?(etag: @user)
|
||||
expires_in 30.minutes, public: true, stale_while_revalidate: 1.week
|
||||
|
||||
if @user.avatar.attached?
|
||||
avatar_variant = @user.avatar.variant(SQUARE_WEBP_VARIANT).processed
|
||||
if (avatar_variant = @user.avatar_variant)
|
||||
send_webp_blob_file avatar_variant.key
|
||||
elsif @user.bot?
|
||||
render_default_bot
|
||||
@@ -26,8 +25,6 @@ class Users::AvatarsController < ApplicationController
|
||||
end
|
||||
|
||||
private
|
||||
SQUARE_WEBP_VARIANT = { resize_to_limit: [ 512, 512 ], format: :webp }
|
||||
|
||||
def send_webp_blob_file(key)
|
||||
send_file ActiveStorage::Blob.service.path_for(key), content_type: "image/webp", disposition: :inline
|
||||
end
|
||||
|
||||
Reference in New Issue
Block a user