public/once-campfire
1
0
Fork 0
mirror of https://github.com/basecamp/once-campfire.git synced 2026-10-08 07:40:08 +09:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #311: Post a message whose attachment can't be previewed instead of failing

Browse Source 
Reviewed and merged by GPT on behalf of DHH.
This commit is contained in:
GPT on behalf of DHH
2026-10-07 10:32:12 +02:00
parent 0f2a1da560 e6de359872
commit cbf52805bd
3 changed files with 36 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/models/message/attachment_test.rb
+21
View File
@@ -19,6 +19,20 @@ class Message::AttachmentTest < ActiveSupport::TestCase
assert_equal message.plain_text_body, "moon.jpg"
end
test "creating a message keeps an image that can't be decoded" do
webp = Vips::Image.new_from_file(file_fixture("moon.jpg").to_s).webpsave_buffer
message = create_unreadable_attachment_message(webp.byteslice(0, webp.bytesize / 2), "broken.webp")
assert_equal "broken.webp", message.reload.attachment.filename.to_s
assert_nil message.attachment.representation(:thumb).image
end
test "creating a message keeps a video that can't be decoded" do
message = create_unreadable_attachment_message(file_fixture("alpha-centuri.mov").binread(64), "broken.mov")
assert_equal "broken.mov", message.reload.attachment.filename.to_s
assert_not message.attachment.preview(format: :webp).image.attached?
end
private
def create_attachment_message(file, content_type)
@@ -27,4 +41,11 @@ class Message::AttachmentTest < ActiveSupport::TestCase
client_message_id: "message",
attachment: fixture_file_upload(file, content_type)
end
def create_unreadable_attachment_message(content, filename)
rooms(:hq).messages.create_with_attachment! \
creator: users(:david),
client_message_id: "message",
attachment: { io: StringIO.new(content), filename: filename }
end
end