public/once-campfire
1
0
Fork 0
mirror of https://github.com/basecamp/once-campfire.git synced 2026-10-09 16:20:09 +09:00
Code Issues Packages Projects Releases Wiki Activity

Merge #336: avoid rewriting already-unread room memberships

Browse Source
This commit is contained in:
GPT on behalf of DHH
2026-10-08 11:33:18 +02:00
parent ec31092919 af4f94c4bd
commit f36b5a2fae
3 changed files with 56 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/models/room.rb
+6 -1
View File
@@ -104,8 +104,13 @@ class Room < ApplicationRecord
end
end
# Rewriting every member on every message is most of what posting to a large room writes,
# so members who are unread already stay as they are. Directs keep touching them all: a
# direct's sidebar row is cached by membership and shows the room's recency.
def unread_memberships(message)
memberships.visible.disconnected.where.not(user: message.creator).update_all(unread_at: message.created_at, updated_at: Time.current)
recipients = memberships.visible.disconnected.where.not(user: message.creator)
recipients = recipients.where(unread_at: nil) unless direct?
recipients.update_all(unread_at: message.created_at, updated_at: Time.current)
end
def push_later(message)