once-campfire

public/once-campfire

Fork 0

mirror of https://github.com/basecamp/once-campfire.git synced 2026-08-07 23:38:45 +09:00

Commit Graph

Author	SHA1	Message	Date
Donal McBreen	c0cade51a1	Address Copilot review: require ipaddr and re-assert the socket port The guard uses IPAddr but relied on something else loading it first; require it explicitly. And the rebinding tests lost their port assertion when the matchers were loosened for newer Net::HTTP keyword args, so check the port alongside the IP again.	2026-07-21 11:53:37 +01:00
Donal McBreen	0de302c977	Fix unfurl rebinding tests for newer Ruby Net::HTTP now passes an open_timeout: option to TCPSocket.open, so the mock that matched exact positional arguments no longer matches. Match on the host instead.	2026-07-20 16:20:15 +01:00
Kevin McConnell	df76a227dc	Hello world First open source release of Campfire 🎉	2025-08-21 09:31:59 +01:00

Author

SHA1

Message

Date

Donal McBreen

c0cade51a1

Address Copilot review: require ipaddr and re-assert the socket port

The guard uses IPAddr but relied on something else loading it first;
require it explicitly. And the rebinding tests lost their port assertion
when the matchers were loosened for newer Net::HTTP keyword args, so
check the port alongside the IP again.

2026-07-21 11:53:37 +01:00

Donal McBreen

0de302c977

Fix unfurl rebinding tests for newer Ruby

Net::HTTP now passes an open_timeout: option to TCPSocket.open, so the mock
that matched exact positional arguments no longer matches. Match on the
host instead.

2026-07-20 16:20:15 +01:00

Kevin McConnell

df76a227dc

Hello world

First open source release of Campfire 🎉

2025-08-21 09:31:59 +01:00

3 Commits