Add ONCE backup and restore hooks

By default, ONCE pauses the application container when taking a backup.
This guarantees a consistent snapshot of the data, but for a large
installation and/or a slow destination path (like a network mount), that
pause could be a bit disruptive to live traffic.

But ONCE also support a pause-free path: if a `pre-backup` hook is
present in the container, ONCE will run that and skip the pause. So by
supplying necessary hooks, we can avoid any disruption from backups.

- `pre-backup` runs the existing script/admin/prepare-backup, which uses
  SQLite's online backup API to get a consistent snapshop. k

- `post-restore` moves our snaphotted file back into place, and removes
  the orphaned sidecar files

.dockerignore

@@ -50,6 +50,3 @@
 
 # Ignore test files
 /test/
-
-# Agent session state — worktrees under .claude/ are whole extra checkouts of this repo
-.claude

.github/dependabot.yml

@@ -20,12 +20,13 @@ updates:
       semver-minor-days: 3
       semver-patch-days: 2
       default-days: 7
-      exclude:
-        - "brakeman"
 
-  # No docker ecosystem. Our base image tag is a build arg
+  - package-ecosystem: docker
-  # (`FROM ruby:$RUBY_VERSION-slim`), which the updater cannot read, so the
+    directory: "/"
-  # entry only ever matched nothing — worse than no entry, because it looked
+    schedule:
-  # like coverage. Ruby base image bumps are a manual, reviewed step here, as
+      interval: weekly
-  # they are across the rest of the fleet. Keep Dockerfile, Dockerfile-export
+    cooldown:
-  # and .ruby-version on the same version by hand.
+      semver-major-days: 7
+      semver-minor-days: 3
+      semver-patch-days: 2
+      default-days: 7

.github/workflows/ci.yml

@@ -16,12 +16,12 @@ jobs:
 
     steps:
       - name: Checkout code
-        uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
+        uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
         with:
           persist-credentials: false
 
       - name: Set up Ruby
-        uses: ruby/setup-ruby@a0102e0972be65f351c307e2d64b9314a57c8073 # v1.324.0
+        uses: ruby/setup-ruby@319994f95fa847cf3fb3cd3dbe89f6dcde9f178f # v1.295.0
         with:
           ruby-version: .ruby-version
           bundler-cache: true
@@ -35,12 +35,12 @@ jobs:
       contents: read
     steps:
       - name: Checkout code
-        uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
+        uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
         with:
           persist-credentials: false
 
       - name: Set up Ruby
-        uses: ruby/setup-ruby@a0102e0972be65f351c307e2d64b9314a57c8073 # v1.324.0
+        uses: ruby/setup-ruby@319994f95fa847cf3fb3cd3dbe89f6dcde9f178f # v1.295.0
         with:
           ruby-version: .ruby-version
           bundler-cache: true
@@ -55,15 +55,15 @@ jobs:
       contents: read
 
     steps:
-      - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
+      - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
         with:
           persist-credentials: false
 
       - name: Run actionlint
-        uses: rhysd/actionlint@914e7df21a07ef503a81201c76d2b11c789d3fca # v1.7.12
+        uses: rhysd/actionlint@393031adb9afb225ee52ae2ccd7a5af5525e03e8 # v1.7.11
 
       - name: Run zizmor
-        uses: zizmorcore/zizmor-action@cc914d7f3750a2d13d75c7f184a1060aa0e9d482 # v0.6.4
+        uses: zizmorcore/zizmor-action@71321a20a9ded102f6e9ce5718a2fcec2c4f70d8 # v0.5.2
         with:
           advanced-security: false
 
@@ -82,12 +82,12 @@ jobs:
         run: sudo apt-get update && sudo apt-get install --no-install-recommends -y libsqlite3-0 libvips curl ffmpeg
 
       - name: Checkout code
-        uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
+        uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
         with:
           persist-credentials: false
 
       - name: Set up Ruby
-        uses: ruby/setup-ruby@a0102e0972be65f351c307e2d64b9314a57c8073 # v1.324.0
+        uses: ruby/setup-ruby@319994f95fa847cf3fb3cd3dbe89f6dcde9f178f # v1.295.0
         env:
           REDIS_URL: redis://localhost:6379/0
         with:
@@ -112,12 +112,12 @@ jobs:
         run: sudo apt-get update && sudo apt-get install --no-install-recommends -y libsqlite3-0 libvips curl ffmpeg
 
       - name: Checkout code
-        uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
+        uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
         with:
           persist-credentials: false
 
       - name: Set up Ruby
-        uses: ruby/setup-ruby@a0102e0972be65f351c307e2d64b9314a57c8073 # v1.324.0
+        uses: ruby/setup-ruby@319994f95fa847cf3fb3cd3dbe89f6dcde9f178f # v1.295.0
         env:
           REDIS_URL: redis://localhost:6379/0
         with:

.github/workflows/publish-image.yml

@@ -44,15 +44,15 @@ jobs:
       IMAGE_NAME: ${{ github.repository }}
     steps:
       - name: Checkout
-        uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
+        uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
         with:
           persist-credentials: false
 
       - name: Set up Docker Buildx
-        uses: docker/setup-buildx-action@f87e5991a6d7451dcb8d9637bfbc97413f497069 # v4.4.1
+        uses: docker/setup-buildx-action@e468171a9de216ec08956ac3ada2f0791b6bd435 # v3.11.1
 
       - name: Log in to GHCR
-        uses: docker/login-action@dbcb813823bdd20940b903addbd779551569679f # v4.6.0
+        uses: docker/login-action@184bdaa0721073962dff0199f1fb9940f07167d1 # v3.5.0
         with:
           registry: ${{ env.REGISTRY }}
           username: ${{ github.actor }}
@@ -80,7 +80,7 @@ jobs:
 
       - name: Extract Docker metadata (tags, labels) with arch suffix
         id: meta
-        uses: docker/metadata-action@dc802804100637a589fabce1cb79ff13a1411302 # v6.2.0
+        uses: docker/metadata-action@c1e51972afc2121e065aed6d45c65596fe445f3f # v5.8.0
         with:
           images: ${{ steps.vars.outputs.canonical }}
           tags: |
@@ -98,7 +98,7 @@ jobs:
 
       - name: Build and push (${{ matrix.platform }})
         id: build
-        uses: docker/build-push-action@c3c9e263c25d99ce0380d002d59b67737d91b0dc # v7.4.0
+        uses: docker/build-push-action@263435318d21b8e681c14492fe198d362a7d2c83 # v6.18.0
         with:
           context: .
           file: Dockerfile
@@ -118,7 +118,7 @@ jobs:
 
       - name: Attest image provenance (per-arch)
         if: github.event_name != 'pull_request'
-        uses: actions/attest-build-provenance@4d101475d8b20a2381f78447822ac1eab6504dd8 # v4.2.2
+        uses: actions/attest-build-provenance@977bb373ede98d70efdf65b84cb5f73e068dcc2a # v3.0.0
         with:
           subject-name: ${{ steps.vars.outputs.canonical }}
           subject-digest: ${{ steps.build.outputs.digest }}
@@ -139,10 +139,10 @@ jobs:
       IMAGE_NAME: ${{ github.repository }}
     steps:
       - name: Set up Docker Buildx (for imagetools)
-        uses: docker/setup-buildx-action@f87e5991a6d7451dcb8d9637bfbc97413f497069 # v4.4.1
+        uses: docker/setup-buildx-action@e468171a9de216ec08956ac3ada2f0791b6bd435 # v3.11.1
 
       - name: Log in to GHCR
-        uses: docker/login-action@dbcb813823bdd20940b903addbd779551569679f # v4.6.0
+        uses: docker/login-action@184bdaa0721073962dff0199f1fb9940f07167d1 # v3.5.0
         with:
           registry: ${{ env.REGISTRY }}
           username: ${{ github.actor }}
@@ -159,7 +159,7 @@ jobs:
 
       - name: Compute base tags (no suffix)
         id: meta
-        uses: docker/metadata-action@dc802804100637a589fabce1cb79ff13a1411302 # v6.2.0
+        uses: docker/metadata-action@c1e51972afc2121e065aed6d45c65596fe445f3f # v5.8.0
         with:
           images: ${{ steps.vars.outputs.canonical }}
           tags: |
@@ -207,7 +207,7 @@ jobs:
           done <<< "$tags"
 
       - name: Install Cosign
-        uses: sigstore/cosign-installer@6f9f17788090df1f26f669e9d70d6ae9567deba6 # v4.1.2
+        uses: sigstore/cosign-installer@d58896d6a1865668819e1d91763c7751a165e159 # v3.9.2
 
       - name: Cosign sign all tags (keyless OIDC)
         shell: bash

.ruby-version

@@ -1 +1 @@
-3.4.10
+3.4.5

Dockerfile

@@ -1,7 +1,7 @@
 # syntax = docker/dockerfile:1
 
 # Make sure it matches the Ruby version in .ruby-version and Gemfile
-ARG RUBY_VERSION=3.4.10
+ARG RUBY_VERSION=3.4.5
 FROM docker.io/library/ruby:$RUBY_VERSION-slim AS base
 
 # Rails app lives here

Dockerfile-export

@@ -1,7 +1,7 @@
 # syntax = docker/dockerfile:1
 
 # Make sure it matches the Ruby version in .ruby-version and Gemfile
-ARG RUBY_VERSION=3.4.10
+ARG RUBY_VERSION=3.4.7
 FROM ruby:$RUBY_VERSION-slim as base
 
 # Install the tools we need

Gemfile

@@ -26,9 +26,6 @@ gem "importmap-rails", github: "rails/importmap-rails"
 gem "turbo-rails", github: "hotwired/turbo-rails"
 gem "stimulus-rails"
 
-# Rich text
-gem "lexxy", "~> 0.9.24"
-
 # Media handling
 gem "image_processing", ">= 1.2"
 
@@ -44,7 +41,6 @@ gem "rails_autolink"
 gem "geared_pagination"
 gem "jbuilder"
 gem "net-http-persistent"
-gem "surfguard", github: "basecamp/surfguard" # The SSRF address policy behind RestrictedHTTP
 gem "kredis"
 gem "platform_agent"
 gem "thruster"

Gemfile.lock

@@ -1,9 +1,3 @@
-GIT
-  remote: https://github.com/basecamp/surfguard.git
-  revision: 59e278c01a537755f22791429051891949231ead
-  specs:
-    surfguard (0.2.0)
-
 GIT
   remote: https://github.com/hotwired/turbo-rails.git
   revision: 30cd8fcc6f82c1ad4edd1ed6069ba878f21f02b3
@@ -143,7 +137,7 @@ GEM
     bcrypt (3.1.22)
     benchmark (0.5.0)
     bigdecimal (3.3.1)
-    brakeman (8.0.6)
+    brakeman (8.0.5)
       racc
     builder (3.3.0)
     bundler-audit (0.9.3)
@@ -174,7 +168,6 @@ GEM
     erubi (1.13.1)
     faker (3.5.2)
       i18n (>= 1.8.11, < 2)
-    ffi (1.17.2)
     ffi (1.17.2-aarch64-linux-gnu)
     ffi (1.17.2-arm64-darwin)
     ffi (1.17.2-x86_64-darwin)
@@ -198,7 +191,7 @@ GEM
     jbuilder (2.14.1)
       actionview (>= 7.0.0)
       activesupport (>= 7.0.0)
-    json (2.21.2)
+    json (2.20.0)
     jwt (3.2.0)
       base64
     kredis (1.8.0)
@@ -206,14 +199,12 @@ GEM
       activesupport (>= 6.0.0)
       redis (>= 4.2, < 6)
     language_server-protocol (3.17.0.5)
-    lexxy (0.9.24)
-      rails (>= 8.0.2)
     lint_roller (1.1.0)
     logger (1.7.0)
     loofah (2.25.2)
       crass (~> 1.0.2)
       nokogiri (>= 1.12.0)
-    mail (2.9.1)
+    mail (2.9.0)
       logger
       mini_mime (>= 0.1.1)
       net-imap
@@ -225,7 +216,7 @@ GEM
       logger
     mini_mime (1.1.5)
     minitest (5.26.2)
-    mocha (3.1.0)
+    mocha (2.7.1)
       ruby2_keywords (>= 0.0.5)
     mono_logger (1.1.2)
     multi_json (1.17.0)
@@ -251,7 +242,7 @@ GEM
       racc (~> 1.4)
     nokogiri (1.19.4-x86_64-linux-gnu)
       racc (~> 1.4)
-    openssl (4.0.2)
+    openssl (3.3.0)
     ostruct (0.6.3)
     parallel (1.27.0)
     parser (3.3.9.0)
@@ -355,7 +346,7 @@ GEM
       ffi (~> 1.12)
       logger
     ruby2_keywords (0.0.5)
-    rubyzip (3.4.0)
+    rubyzip (3.0.2)
     securerandom (0.4.1)
     selenium-webdriver (4.35.0)
       base64 (~> 0.2)
@@ -376,18 +367,18 @@ GEM
       rack-protection (= 4.2.1)
       rack-session (>= 2.0.0, < 3)
       tilt (~> 2.0)
-    sqlite3 (2.9.6-aarch64-linux-gnu)
+    sqlite3 (2.9.5-aarch64-linux-gnu)
-    sqlite3 (2.9.6-arm64-darwin)
+    sqlite3 (2.9.5-arm64-darwin)
-    sqlite3 (2.9.6-x86_64-darwin)
+    sqlite3 (2.9.5-x86_64-darwin)
-    sqlite3 (2.9.6-x86_64-linux-gnu)
+    sqlite3 (2.9.5-x86_64-linux-gnu)
     stimulus-rails (1.3.4)
       railties (>= 6.0.0)
     stringio (3.1.8)
     thor (1.4.0)
-    thruster (0.1.23-aarch64-linux)
+    thruster (0.1.15-aarch64-linux)
-    thruster (0.1.23-arm64-darwin)
+    thruster (0.1.15-arm64-darwin)
-    thruster (0.1.23-x86_64-darwin)
+    thruster (0.1.15-x86_64-darwin)
-    thruster (0.1.23-x86_64-linux)
+    thruster (0.1.15-x86_64-linux)
     tilt (2.6.1)
     timeout (0.6.1)
     tsort (0.2.0)
@@ -398,9 +389,9 @@ GEM
     unicode-emoji (4.2.0)
     uri (1.1.1)
     useragent (0.16.11)
-    web-push (3.1.0)
+    web-push (3.0.2)
       jwt (~> 3.0)
-      openssl (>= 3.0)
+      openssl (~> 3.0)
     webmock (3.25.1)
       addressable (>= 2.8.0)
       crack (>= 0.3.2)
@@ -433,7 +424,6 @@ DEPENDENCIES
   importmap-rails!
   jbuilder
   kredis
-  lexxy (~> 0.9.24)
   mocha
   net-http-persistent
   ostruct
@@ -452,7 +442,6 @@ DEPENDENCIES
   sentry-ruby
   sqlite3
   stimulus-rails
-  surfguard!
   thruster
   turbo-rails!
   web-push

app/assets/stylesheets/actiontext.css

@@ -1,160 +1,165 @@
-/* Resolve Lexxy's palette to Campfire's, in the editor and in rendered messages,
+trix-toolbar {
-   so everything follows Campfire's light/dark color scheme */
+  display: none;
-.lexxy-content {
+  inset: auto 0 0 0;
-  --lexxy-color-canvas: transparent;
+  min-width: 0;
-  --lexxy-color-text: var(--color-text);
+  position: sticky;
-  --lexxy-color-text-subtle: var(--color-text);
+  z-index: 3;
-  --lexxy-color-link: var(--color-link);
-  --lexxy-color-ink: var(--color-text);
-  --lexxy-color-ink-inverted: var(--color-text-reversed);
-  --lexxy-color-ink-medium: var(--color-text);
-  --lexxy-color-ink-lighter: var(--color-border-darker);
-  --lexxy-color-ink-lightest: var(--color-bg);
-  --lexxy-color-selected: var(--color-selected, var(--color-bg));
-  --lexxy-color-code-bg: var(--color-bg);
 
-  /* Campfire's message lines stack without extra block margins */
+  .trix-dialog {
-  --lexxy-content-margin: 0;
+    bottom: 3rem !important;
+    top: auto !important;
+  }
+
+  .trix-button--icon {
+    height: auto !important;
+  }
+
+  .trix-dialog {
+    background-color: var(--color-bg) !important;
+    border-radius: 1rem !important;
+    border: 2px solid var(--color-text) !important;
+    box-shadow: none !important;
+    color: var(--color-text) !important;
+    gap: var(--inline-space);
+    padding: 0 !important;
+    overflow: clip;
+
+    .trix-input {
+      background: transparent !important;
+      border: 0 !important;
+      color: var(--color-text) !important;
+      font-size: max(16px, 1em) !important;
+      padding: var(--input-padding, 0.5em 0.8em) !important;
+    }
+
+    .trix-button {
+      color: var(--color-text) !important;
+    }
+  }
+
+  .trix-dialog--link {
+    .trix-dialog__link-fields {
+      align-items: center;
+      padding-right: 0.3em;
+    }
+
+    [value="Link"],
+    [value="Unlink"] {
+      width: 2.6em;
+      aspect-ratio: 1 / 1;
+      background-position: center center;
+      background-repeat: no-repeat;
+      text-indent: -9999%;
+      padding: 0;
+    }
+
+    [value="Link"] { background-image: url("data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/svg' width='24' height='24' fill='none'%3E%3Cpath fill='%23000' fill-rule='evenodd' d='M18.948 5.258a4.337 4.337 0 0 0-6.108 0L11.217 6.87a.993.993 0 0 0 0 1.41c.392.39 1.027.39 1.418 0l1.623-1.613a2.323 2.323 0 0 1 3.271 0 2.29 2.29 0 0 1 0 3.251l-2.393 2.38a3.021 3.021 0 0 1-4.255 0l-.05-.049a1.007 1.007 0 0 0-1.418 0 .993.993 0 0 0 0 1.41l.05.049a5.036 5.036 0 0 0 7.091 0l2.394-2.38a4.275 4.275 0 0 0 0-6.072Zm-13.683 13.6a4.337 4.337 0 0 0 6.108 0l1.262-1.255a.993.993 0 0 0 0-1.41 1.007 1.007 0 0 0-1.418 0L9.954 17.45a2.323 2.323 0 0 1-3.27 0 2.29 2.29 0 0 1 0-3.251l2.344-2.331a2.579 2.579 0 0 1 3.631 0c.392.39 1.027.39 1.419 0a.993.993 0 0 0 0-1.41 4.593 4.593 0 0 0-6.468 0l-2.345 2.33a4.275 4.275 0 0 0 0 6.072Z' clip-rule='evenodd'/%3E%3C/svg%3E"); }
+
+    [value="Unlink"] {
+      background-image: url("data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/svg' width='24' height='24' fill='none'%3E%3Cpath fill='%23000' fill-rule='evenodd' d='M18.954 5.264a3.58 3.58 0 0 0-5.04 0l-2.157 2.144a.993.993 0 0 0 0 1.41c.392.39 1.027.39 1.418 0l2.157-2.144a1.565 1.565 0 0 1 2.204 0c.607.603.609 1.58.005 2.186l-2.348 2.355a.993.993 0 0 0 .006 1.41 1.007 1.007 0 0 0 1.419-.007l2.347-2.354a3.528 3.528 0 0 0-.01-5ZM5.257 18.852a3.59 3.59 0 0 0 5.041.015l2.6-2.554a.993.993 0 0 0 .01-1.41 1.007 1.007 0 0 0-1.419-.009l-2.6 2.554c-.615.603-1.603.6-2.214-.006a1.554 1.554 0 0 1-.012-2.195l2.539-2.58a.993.993 0 0 0-.016-1.41 1.007 1.007 0 0 0-1.418.015l-2.539 2.58a3.54 3.54 0 0 0 .028 5Z' clip-rule='evenodd'/%3E%3Cpath stroke='%23000' stroke-linecap='round' stroke-width='2' d='M10.233 5.78V3.769M5.968 9.802H4.21M7.343 7.107 5.968 5.781M14.348 17.523v2.013M18.613 13.502h1.758M17.238 16.196l1.375 1.327'/%3E%3C/svg%3E%0A");
+      border-top-right-radius: 1em !important;
+      border-bottom-right-radius: 1em !important;
+    }
+  }
 }
 
-lexxy-editor {
+trix-editor {
   &.input {
-    --lexxy-editor-padding: 0;
-
-    /* One line high when empty. Lexxy derives this from attr(rows lh, 8lh),
-       whose resolution differs between Chrome versions — pin it instead of
-       risking the 8-line fallback */
-    --lexxy-editor-rows: 1lh;
-
-    background: transparent;
-    border: 0;
-    border-radius: 0;
     min-height: 24px;
   }
 
   .attachment--content {
     margin: 0;
     display: inline-flex;
-  }
-}
 
-/* The mentions menu needs a solid surface — the editor's transparent canvas
+    .attachment__toolbar {
-   would let messages show through it */
+      top: 0;
-.lexxy-prompt-menu {
+      z-index: 2;
-  --lexxy-color-canvas: var(--color-bg);
-
-  border: 1px solid var(--color-border-dark);
-}
-
-/* Same for the code block language picker: with a transparent canvas the
-   native dropdown renders white-on-white in dark mode */
-lexxy-editor lexxy-code-language-picker select {
-  background-color: var(--color-bg);
-  color: var(--color-text);
-
-  option {
-    background-color: var(--color-bg);
-    color: var(--color-text);
-  }
-}
-
-/* The toolbar only shows when rich text mode is toggled on (see composer.css) */
-lexxy-toolbar {
-  /* Wide, airy button spacing like the Trix toolbar */
-  --lexxy-toolbar-gap: 1.3em;
-
-  /* Match the compact size of the Trix toolbar buttons */
-  --lexxy-toolbar-button-size: 1.7em;
-  --lexxy-toolbar-icon-size: 1.125em;
-
-  display: none;
-  border-block-end: 0;
-  min-width: 0;
-  z-index: 3;
-
-  /* Tools Campfire doesn't offer, matching the Trix toolbar: underline,
-     color highlights, tables, dividers and undo/redo (history tools were
-     hidden under Trix as well) */
-  button[name="underline"],
-  button[name="table"],
-  button[name="divider"],
-  button[name="undo"],
-  button[name="redo"],
-  lexxy-highlight-dropdown {
-    display: none !important;
-  }
-
-  /* No group separator pipes, like the Trix toolbar */
-  .lexxy-editor__toolbar-button.lexxy-editor__toolbar-group-end::after {
-    display: none;
-  }
-
-  /* Dropdown panels: a solid surface with a uniform radius. Lexxy derives
-     the panel's radius and gap from --lexxy-toolbar-gap, which Campfire
-     repurposes for button spacing */
-  .lexxy-editor__toolbar-dropdown [data-dropdown-panel] {
-    --lexxy-color-canvas: var(--color-bg);
-    --lexxy-color-ink-lightest: var(--color-message-bg);
-    --lexxy-color-selected: var(--color-selected);
-    --lexxy-color-selected-hover: var(--color-message-bg);
-
-    border: 1px solid var(--color-border-dark);
-    border-radius: 0.5em;
-    gap: 0.25em;
-    padding: 0.25em;
-  }
-
-  .lexxy-editor__toolbar-dropdown > .lexxy-editor__toolbar-button[aria-expanded="true"] {
-    border-radius: var(--lexxy-radius);
-  }
-}
-
-/* Attachment markup contains formatting whitespace that must not turn into
-   line breaks under the editor's white-space: pre-wrap */
-lexxy-editor action-text-attachment {
-  white-space: normal;
-}
-
-action-text-attachment[content-type~="application/vnd.campfire.mention"] {
-  display: inline-flex;
-  margin: 0;
-  padding: 0;
-  position: relative;
-}
-
-action-text-attachment[content-type~="application/vnd.actiontext.opengraph-embed"] {
-  lexxy-editor & {
-    display: block;
-    inline-size: fit-content;
-    max-inline-size: 100%;
-  }
-
-  /* No selection background — it peeks through the card's rounded corners.
-     The lexxy-editor prefix out-specifies Lexxy's own selection rule. */
-  lexxy-editor &.node--selected {
-    --lexxy-attachment-bg-color: transparent;
-  }
-
-  /* A prominent remove button on the card's top edge, horizontally
-     centered, like the Trix one. The lexxy-editor prefix out-specifies
-     Lexxy's own placement rules. */
-  lexxy-editor & lexxy-node-delete-button {
-    inset-block-start: 0;
-    inset-inline-start: 50%;
-    inset-inline-end: auto;
-    transform: translate(-50%, -50%);
-
-    .lexxy-floating-controls__group {
-      --button-size: 2.2em;
-
-      background-color: var(--color-negative);
-      border-radius: 50%;
-      color: white;
     }
   }
 }
 
-.lexxy-content {
+.trix-button-group--file-tools,
+.trix-button-group--history-tools {
+  display: none !important;
+}
+
+.trix-button-group,
+.trix-button {
+  border: 0 !important;
+  margin: 0 !important;
+  border-radius: 0.3em !important;
+  box-shadow: none;
+
+  &::before {
+    opacity: 1 !important;
+  }
+
+  @media (prefers-color-scheme: dark) {
+    &::before {
+      filter: invert(100);
+    }
+  }
+
+  &.trix-active {
+    background-color: var(--color-text) !important;
+
+    &::before {
+      filter: invert(100);
+    }
+
+    @media (prefers-color-scheme: dark) {
+      &::before {
+        filter: invert(0);
+      }
+    }
+  }
+
+  &.trix-button--remove {
+    background-color: var(--color-negative);
+    border-radius: 1.8em !important;
+
+    &::before {
+      filter: invert(100);
+      background-size: 70%;
+      background-image: url("minus.svg");
+    }
+  }
+}
+
+[data-trix-content-type~='application/vnd.campfire.mention'] {
+  .trix-button-group {
+    display: inline;
+  }
+}
+
+[data-trix-content-type~="application/vnd.actiontext.opengraph-embed"] {
+  * {
+    text-decoration: none;
+  }
+
+  trix-editor & {
+    display: block;
+    inline-size: fit-content;
+    max-inline-size: 100%;
+  }
+}
+
+.trix-button:not(.trix-button--remove) {
+  @media (any-hover: hover) {
+    &:where(:not(:active):hover) {
+      filter: brightness(0.9);
+      background-color: var(--color-bg);
+    }
+  }
+
+  &:disabled {
+    opacity: 0.33;
+  }
+}
+
+trix-editor,
+.trix-content {
   pre {
     background-color: var(--color-bg) !important;
     border-radius: 0.5em;
@@ -174,13 +179,11 @@ action-text-attachment[content-type~="application/vnd.actiontext.opengraph-embed
   blockquote {
     border: 0 solid var(--color-border-darker) !important;
     border-inline-start-width: var(--blockquote-border) !important;
-    font-style: normal;
     margin: 0 var(--blockquote-margin) !important;
     padding-inline-start: var(--blockquote-padding) !important;
   }
 
   cite {
-    display: block;
     margin-inline-start: calc(var(--blockquote-padding));
     font-style: normal;
     font-size: 0.8rem;
@@ -196,14 +199,13 @@ action-text-attachment[content-type~="application/vnd.actiontext.opengraph-embed
     color: var(--color-link);
   }
 
-  /* The composer's mention menu is a list inside the editor too, and keeps Lexxy's own spacing */
+  ul,
-  ul:not(.lexxy-prompt-menu),
   ol {
     margin: 0 !important;
     padding: 0 !important;
   }
 
-  li:not(.lexxy-prompt-menu__item) {
+  li {
     margin: 0 0 0 var(--inline-space-double) !important;
     padding: 0 !important;
   }

app/assets/stylesheets/autocomplete.css

@@ -33,7 +33,7 @@
   }
 }
 
-action-text-attachment[content-type~='application/vnd.campfire.mention'] {
+[data-trix-content-type~='application/vnd.campfire.mention'] {
   display: inline-flex;
   margin: 0;
   padding: 0;

app/assets/stylesheets/composer.css

@@ -100,42 +100,16 @@
   }
 
   .composer--rich-text {
-    lexxy-toolbar {
+    trix-toolbar {
-      display: flex;
+      display: block;
     }
 
-    lexxy-editor.input {
+    trix-editor.input {
       margin-block-start: var(--block-space-half);
     }
   }
 
-  /* In the message composer the toolbar goes below the text, on the same
+  .composer--edit trix-toolbar {
-     row as the surrounding action buttons, like the Trix toolbar did.
-     The edit composer keeps it on top. */
-  #composer.composer--rich-text lexxy-editor.input {
-    display: flex;
-    flex-direction: column;
-
-    /* Sit the toolbar row on the same baseline as the composer's round
-       buttons, which pull themselves down with negative margins */
-    margin-block-end: -0.25em;
-
-    .lexxy-editor__content {
-      order: -1;
-    }
-
-    lexxy-toolbar {
-      margin-block-start: 0.4em;
-
-      /* Dropdowns open upward — the toolbar sits at the bottom of the screen */
-      [data-dropdown-panel] {
-        inset-block-start: auto;
-        inset-block-end: 100%;
-      }
-    }
-  }
-
-  .composer--edit lexxy-toolbar {
     border-block-end: 1px solid var(--color-border);
     margin-inline: -0.8em;
     padding-inline: 0.3em;
@@ -143,16 +117,6 @@
   }
 }
 
-/* The editor's container-type prevents it from sizing the message bubble by
-   its content, so give the bubble the full available width while editing */
-.message__body:has(.composer--edit) {
-  inline-size: 100%;
-
-  .message__body-content--editing {
-    flex-grow: 1;
-  }
-}
-
 /* Typing indicator */
 .typing-indicator {
   inset-block-start: var(--indicator-position, 0.15rem);

app/assets/stylesheets/embeds.css

@@ -1,5 +1,5 @@
-
+trix-editor,
-.lexxy-content {
+.trix-content {
   .og-embed {
     background: var(--color-bg);
     border: 1px solid var(--color-border-dark);
@@ -15,7 +15,7 @@
       flex-direction: row;
     }
 
-    &.og-embed--twitter-avatar {
+    .cf-twitter-avatar & {
       flex-direction: row;
     }
   }
@@ -35,11 +35,10 @@
 
   .og-embed__title {
     font-weight: 600;
+    text-decoration: underline;
 
-    /* Underline the link itself so the line is link-colored */
     a {
       color: var(--color-link);
-      text-decoration: underline;
     }
   }
 
@@ -54,11 +53,7 @@
       inline-size: 15dvw;
     }
 
-    /* block-size/border-radius guard against Lexxy's 1em round avatar
-       styling for custom attachment images */
     > * {
-      block-size: auto;
-      border-radius: 0;
       object-position: top right;
       inline-size: 100%;
       object-fit: contain;
@@ -68,7 +63,7 @@
       }
     }
 
-    .og-embed--twitter-avatar & {
+    .cf-twitter-avatar & {
       aspect-ratio: 1;
       border-radius: 50%;
       inline-size: 2lh;

app/assets/stylesheets/messages.css

@@ -537,7 +537,7 @@ img.message__attachment {
     padding: var(--content-padding-block) 0 var(--content-padding-block) var(--content-padding-inline);
     text-shadow: 0 0 3px var(--color-text-reversed);
 
-    .lexxy-content {
+    .trix-content {
       font-size: 2.4em;
       line-height: 1.4;
     }

app/channels/concerns/room_streams_are_authorized.rb

@@ -1,13 +0,0 @@
-# Prepended onto Turbo::StreamsChannel. The subscriber names the channel it wants, so
-# authorizing room messages only in RoomMessagesChannel would leave the stock channel as
-# a way around it: same signed stream name, no membership check. Turn those names away
-# here and RoomMessagesChannel becomes the only door.
-module RoomStreamsAreAuthorized
-  def subscribed
-    if RoomMessagesChannel.guarded_stream?(verified_stream_name_from_params)
-      reject
-    else
-      super
-    end
-  end
-end

app/channels/room_messages_channel.rb

@@ -1,55 +0,0 @@
-# Authorizes the room message stream when the subscription is made, so that revoking a
-# membership actually stops delivery.
-#
-# Turbo's stock channel verifies only the signature on the stream name. That name carries
-# no expiry and no binding to a user, so one harvested while a member keeps working after
-# the membership is gone. Reconnecting makes it worse rather than better: revoking a
-# membership disconnects the user with reconnect: true, and the client then replays its
-# subscriptions on the fresh socket.
-#
-# The room is derived from the verified stream name rather than taken as a parameter, so
-# there's nothing for a subscriber to point somewhere else. The subscriber also doesn't
-# get to choose the channel: Turbo::StreamsChannel turns these stream names away, so this
-# is the only way onto them. See config/initializers/turbo_streams_authorization.rb.
-class RoomMessagesChannel < ApplicationCable::Channel
-  extend  Turbo::Streams::StreamName
-  include Turbo::Streams::StreamName::ClassMethods
-
-  STREAM_SUFFIX = "messages"
-
-  class << self
-    # True for the stream names this channel exists to guard, whoever is asking.
-    def guarded_stream?(stream_name)
-      stream_name.to_s.split(":", 2).second == STREAM_SUFFIX
-    end
-
-    def subscribable_room(user, stream_name)
-      gid_param, suffix = stream_name.to_s.split(":", 2)
-
-      if suffix == STREAM_SUFFIX && room = room_from(gid_param)
-        user.rooms.find_by(id: room.id)
-      end
-    end
-
-    private
-      def room_from(gid_param)
-        GlobalID::Locator.locate gid_param, only: Room
-      rescue ActiveRecord::RecordNotFound
-        nil
-      end
-  end
-
-  def subscribed
-    if stream_name = authorized_stream_name
-      stream_from stream_name
-    else
-      reject
-    end
-  end
-
-  private
-    def authorized_stream_name
-      stream_name = verified_stream_name_from_params
-      stream_name if stream_name.present? && self.class.subscribable_room(current_user, stream_name)
-    end
-end

app/channels/unread_rooms_channel.rb

@@ -1,12 +1,5 @@
 class UnreadRoomsChannel < ApplicationCable::Channel
-  # Scoped per user, like ReadRoomsChannel. A single global stream would tell every
-  # authenticated connection when any room on the account is active, including closed
-  # rooms and direct conversations they're not part of.
-  def self.stream_name_for(user_id)
-    "user_#{user_id}_unreads"
-  end
-
   def subscribed
-    stream_from self.class.stream_name_for(current_user.id)
+    stream_from "unread_rooms"
   end
 end

app/controllers/autocompletable/users_controller.rb

@@ -1,26 +1,11 @@
 class Autocompletable::UsersController < ApplicationController
   def index
     set_page_and_extract_portion_from find_autocompletable_users.with_attached_avatar.ordered, per_page: 20
-
-    respond_to do |format|
-      format.html { render layout: false } # <lexxy-prompt-item> elements for the mentions prompt
-      format.json
-    end
   end
 
   private
     def find_autocompletable_users
-      if query.present?
+      params[:query].present? ? users_scope.active.filtered_by(params[:query]) : users_scope.active
-        users_scope.active.filtered_by(query)
-      else
-        users_scope.active
-      end
-    end
-
-    # The rich text editor's mentions prompt filters with `filter`, the
-    # autocomplete inputs with `query`
-    def query
-      params[:filter].presence || params[:query].presence
     end
 
     def users_scope

app/controllers/concerns/active_storage_authentication.rb

@@ -1,9 +0,0 @@
-module ActiveStorageAuthentication
-  extend ActiveSupport::Concern
-  include Authentication::SessionLookup
-
-  private
-    def require_active_storage_authentication
-      head :unauthorized unless find_session_by_cookie
-    end
-end

app/controllers/concerns/authentication.rb

@@ -71,13 +71,6 @@ module Authentication
       Current.session&.destroy!
       reset_session
       remove_authentication_cookie
-      disconnect_remote_connections
-    end
-
-    def disconnect_remote_connections
-      Current.user&.reset_remote_connections
-    rescue => error
-      Rails.logger.warn "Could not disconnect remote connections on sign out: #{error.class}"
     end
 
     def authenticated_as(session)

app/controllers/concerns/raw_request_body.rb

@@ -1,12 +0,0 @@
-module RawRequestBody
-  extend ActiveSupport::Concern
-
-  private
-
-  def raw_request_body
-    request.body.rewind
-    request.body.read.force_encoding("UTF-8")
-  ensure
-    request.body.rewind
-  end
-end

app/controllers/messages/boosts/by_bots_controller.rb

@@ -1,39 +0,0 @@
-class Messages::Boosts::ByBotsController < Messages::BoostsController
-  include RawRequestBody
-
-  allow_bot_access only: %i[ create destroy ]
-
-  before_action :ensure_content_present, only: :create
-
-  def create
-    @boost = @message.boosts.create!(boost_params)
-
-    broadcast_create
-    render :show, status: :created
-  end
-
-  private
-    def set_message
-      if room = Current.user.rooms.find_by(id: params[:room_id])
-        @message = room.messages.find_by(id: params[:message_id])
-      end
-
-      head :not_found unless @message
-    end
-
-    def set_boost
-      super
-    rescue ActiveRecord::RecordNotFound
-      head :not_found
-    end
-
-    def ensure_content_present
-      if raw_request_body.blank?
-        head :unprocessable_content
-      end
-    end
-
-    def boost_params
-      { content: raw_request_body }
-    end
-end

app/controllers/messages/boosts_controller.rb

@@ -1,6 +1,5 @@
 class Messages::BoostsController < ApplicationController
   before_action :set_message
-  before_action :set_boost, only: :destroy
 
   def index
   end
@@ -16,6 +15,7 @@ class Messages::BoostsController < ApplicationController
   end
 
   def destroy
+    @boost = Current.user.boosts.find(params[:id])
     @boost.destroy!
 
     broadcast_remove
@@ -26,10 +26,6 @@ class Messages::BoostsController < ApplicationController
       @message = Current.user.reachable_messages.find(params[:message_id])
     end
 
-    def set_boost
-      @boost = @message.boosts.find_by!(id: params[:id], booster: Current.user)
-    end
-
     def boost_params
       params.require(:boost).permit(:content)
     end

app/controllers/messages/by_bots_controller.rb

@@ -1,64 +1,24 @@
 class Messages::ByBotsController < MessagesController
-  include RawRequestBody
+  allow_bot_access only: :create
-
-  allow_bot_access only: %i[ index create update destroy ]
-
-  before_action :set_room
-  before_action :set_message, only: %i[ update destroy ]
-  before_action :ensure_can_administer, only: %i[ update destroy ]
-  before_action :ensure_body_or_attachment_present, only: :create
-
-  def index
-    @messages = find_paged_messages
-    set_pagination_headers
-  end
 
   def create
     super
     head :created, location: message_url(@message)
   end
 
-  def destroy
-    super
-    head :no_content
-  end
-
   private
-    def set_room
-      @room = Current.user.rooms.find_by(id: params[:room_id])
-
-      head :not_found unless @room
-    end
-
-    def ensure_body_or_attachment_present
-      if params[:attachment].blank? && raw_request_body.blank?
-        head :unprocessable_content
-      end
-    end
-
-    def set_pagination_headers
-      headers["X-Total-Count"] = @room.messages.count.to_s
-
-      if next_page = next_page_params
-        headers["Link"] = %(<#{room_bot_messages_url(@room, params[:bot_key], **next_page)}>; rel="next")
-      end
-    end
-
-    def next_page_params
-      if @messages.any?
-        if params[:after].present?
-          { after: @messages.last.id } if @room.messages.after(@messages.last).exists?
-        else
-          { before: @messages.first.id } if @room.messages.before(@messages.first).exists?
-        end
-      end
-    end
-
     def message_params
       if params[:attachment]
         params.permit(:attachment)
       else
-        { body: raw_request_body }
+        reading(request.body) { |body| { body: body } }
       end
     end
+
+    def reading(io)
+      io.rewind
+      yield io.read.force_encoding("UTF-8")
+    ensure
+      io.rewind
+    end
 end

app/controllers/messages_controller.rb

@@ -37,11 +37,7 @@ class MessagesController < ApplicationController
     @message.update!(message_params)
 
     @message.broadcast_replace_to @room, :messages, target: [ @message, :presentation ], partial: "messages/presentation", attributes: { maintain_scroll: true }
-
+    redirect_to room_message_url(@room, @message)
-    respond_to do |format|
-      format.html { redirect_to room_message_url(@room, @message) }
-      format.json { render :show }
-    end
   end
 
   def destroy

app/controllers/rooms/closeds_controller.rb

@@ -42,12 +42,6 @@ class Rooms::ClosedsController < RoomsController
       @room = @room.becomes!(Rooms::Closed)
     end
 
-    # Open and closed rooms convert into each other, so both are in reach here. Direct
-    # rooms never are: converting one would let its creator revise who's in it.
-    def room_scope
-      Current.user.rooms.without_directs
-    end
-
     def grantees
       User.where(id: grantee_ids)
     end

app/controllers/rooms/directs_controller.rb

@@ -29,13 +29,8 @@ class Rooms::DirectsController < RoomsController
       end
     end
 
-    # All users in a direct room can administer it. Only direct rooms, though: this
+    # All users in a direct room can administer it
-    # relaxation is why room_scope below has to keep every other type out of reach.
     def ensure_can_administer
       true
     end
-
-    def room_scope
-      Current.user.rooms.directs
-    end
 end

app/controllers/rooms/opens_controller.rb

@@ -40,12 +40,6 @@ class Rooms::OpensController < RoomsController
       @room = @room.becomes!(Rooms::Open)
     end
 
-    # Open and closed rooms convert into each other, so both are in reach here. Direct
-    # rooms never are: promoting one would republish its history to the whole account.
-    def room_scope
-      Current.user.rooms.without_directs
-    end
-
     def broadcast_create_room(room)
       broadcast_prepend_to :rooms, target: :shared_rooms, partial: "users/sidebars/rooms/shared", locals: { room: room }
     end

app/controllers/rooms_controller.rb

@@ -20,19 +20,13 @@ class RoomsController < ApplicationController
 
   private
     def set_room
-      if room = room_scope.find_by(id: params[:room_id] || params[:id])
+      if room = Current.user.rooms.find_by(id: params[:room_id] || params[:id])
         @room = room
       else
         redirect_to root_url, alert: "Room not found or inaccessible"
       end
     end
 
-    # Subclasses narrow this to the room types they're allowed to act on, so that one
-    # room namespace can't be used to reach another's rooms.
-    def room_scope
-      Current.user.rooms
-    end
-
     def ensure_can_administer
       head :forbidden unless Current.user.can_administer?(@room)
     end

app/controllers/users/push_subscriptions_controller.rb

@@ -6,17 +6,12 @@ class Users::PushSubscriptionsController < ApplicationController
 
   def create
     if subscription = @push_subscriptions.find_by(push_subscription_params)
-      # Existing endpoints must pass current validations
+      subscription.touch
-      if subscription.valid?
-        subscription.touch
-        head :ok
-      else
-        head :unprocessable_entity
-      end
     else
-      subscription = @push_subscriptions.create push_subscription_params.merge(user_agent: request.user_agent)
+      @push_subscriptions.create! push_subscription_params.merge(user_agent: request.user_agent)
-      head subscription.persisted? ? :ok : :unprocessable_entity
     end
+
+    head :ok
   end
 
   def destroy

app/helpers/content_filters.rb

@@ -1,13 +1,3 @@
 module ContentFilters
-  # Formatting the rich text editor produces that Rails' sanitizers don't
+  TextMessagePresentationFilters = ActionText::Content::Filters.new(RemoveSoloUnfurledLinkText, StyleUnfurledTwitterAvatars, SanitizeTags)
-  # allow by default. A message passes through three sanitization layers on
-  # its way to the screen, and each builds on this list:
-  #
-  #   * SanitizeTags strips disallowed markup from the message body
-  #   * Action Text sanitizes the rendered content (lib/rails_ext/action_text_allowed_tags.rb)
-  #   * auto_link re-sanitizes the final html (MessagesHelper#message_presentation)
-  EDITOR_FORMATTING_TAGS = %w[ s u mark table thead tbody tfoot tr th td ]
-  EDITOR_FORMATTING_ATTRIBUTES = %w[ data-language ]
-
-  TextMessagePresentationFilters = ActionText::Content::Filters.new(RemoveSoloUnfurledLinkText, SanitizeTags, SanitizeAttributes)
 end

app/helpers/content_filters/remove_solo_unfurled_link_text.rb

@@ -1,22 +1,18 @@
 class ContentFilters::RemoveSoloUnfurledLinkText < ActionText::Content::Filter
-  TWITTER_DOMAINS = %w[ x.com twitter.com ]
-  TWITTER_DOMAIN_MAPPING = { "x.com" => "twitter.com" }
-
   def applicable?
     normalize_tweet_url(solo_unfurled_url) == normalize_tweet_url(content.to_plain_text)
   end
 
   def apply
-    if trix_body?
+    fragment.replace("div") { |node| node.tap { |n| n.inner_html = unfurled_links.first.to_s } }
-      remove_link_text_from_wrapping_div
-    else
-      remove_link_paragraphs
-    end
   end
 
   private
+    TWITTER_DOMAINS = %w[ x.com twitter.com ]
+    TWITTER_DOMAIN_MAPPING = { "x.com" => "twitter.com" }
+
     def solo_unfurled_url
-      ActionText::Attachment::OpengraphEmbed.from_node(unfurled_links.first)&.href if unfurled_links.size == 1
+      unfurled_links.first["href"] if unfurled_links.size == 1
     end
 
     def unfurled_links
@@ -39,20 +35,4 @@ class ContentFilters::RemoveSoloUnfurledLinkText < ActionText::Content::Filter
     def twitter_url?(url)
       url.present? && TWITTER_DOMAINS.any? { |domain| url.strip.include?(domain) }
     end
-
-    def trix_body?
-      fragment.find_all("div").any?
-    end
-
-    def remove_link_text_from_wrapping_div
-      fragment.replace("div") { |node| node.tap { |n| n.inner_html = unfurled_links.first.to_s } }
-    end
-
-    def remove_link_paragraphs
-      fragment.replace("p") do |node|
-        if node.at_css("action-text-attachment")
-          node
-        end
-      end
-    end
 end

app/helpers/content_filters/sanitize_attributes.rb

@@ -1,47 +0,0 @@
-class ContentFilters::SanitizeAttributes < ActionText::Content::Filter
-  def applicable?
-    true
-  end
-
-  # Scrub attributes on the tags that SanitizeTags allows, using Rails' safe-list
-  # sanitizer so unsafe URI schemes and event-handler attributes are stripped.
-  # Runs after SanitizeTags, so passing the same allowed tags makes the tag pass
-  # a no-op and only attributes are scrubbed.
-  def apply
-    sanitizer.sanitize fragment.to_html, tags: allowed_tags, attributes: allowed_attributes
-  end
-
-  private
-    # Presentation styling relies on class attributes (e.g. unfurled link embeds),
-    # which the standard ActionText set doesn't include.
-    EXTRA_ALLOWED_ATTRIBUTES = %w[ class ]
-
-    # ActionText::ContentHelper.sanitizer is a single process-wide instance, and
-    # rails-html-sanitizer reuses one mutable permit scrubber that it reconfigures
-    # from the tags/attributes on every #sanitize call. Sharing it here would race
-    # our stricter tag set against ActionText's default rendering on concurrent
-    # requests, so use a dedicated instance of the same sanitizer class to keep the
-    # scrubber isolated.
-    def sanitizer
-      sanitizer_class.new
-    end
-
-    def sanitizer_class
-      ActionText::ContentHelper.sanitizer.class
-    end
-
-    def allowed_tags
-      ContentFilters::SanitizeTags::ALLOWED_TAGS
-    end
-
-    def allowed_attributes
-      standard_allowed_attributes + EXTRA_ALLOWED_ATTRIBUTES
-    end
-
-    # Mirrors ActionText::ContentHelper#sanitizer_allowed_attributes, which isn't
-    # exposed at the module level.
-    def standard_allowed_attributes
-      ActionText::ContentHelper.allowed_attributes ||
-        (sanitizer_class.allowed_attributes + ActionText::Attachment::ATTRIBUTES).to_a
-    end
-end

app/helpers/content_filters/sanitize_tags.rb

@@ -1,8 +1,4 @@
 class ContentFilters::SanitizeTags < ActionText::Content::Filter
-  ALLOWED_TAGS = %w[ a abbr acronym address b big blockquote br cite code dd del dfn div dl dt em h1 h2 h3 h4 h5 h6 hr i ins kbd li ol
-    p pre samp small span strong sub sup time tt ul var ] + ContentFilters::EDITOR_FORMATTING_TAGS +
-    [ ActionText::Attachment.tag_name, "figure", "figcaption" ]
-
   def applicable?
     true
   end
@@ -12,6 +8,9 @@ class ContentFilters::SanitizeTags < ActionText::Content::Filter
   end
 
   private
+    ALLOWED_TAGS = %w[ a abbr acronym address b big blockquote br cite code dd del dfn div dl dt em h1 h2 h3 h4 h5 h6 hr i ins kbd li ol
+      p pre samp small span strong sub sup time tt ul var ] + [ ActionText::Attachment.tag_name, "figure", "figcaption" ]
+
     def not_allowed_tags_css_selector
       ALLOWED_TAGS.map { |tag| ":not(#{tag})" }.join("")
     end

app/helpers/content_filters/style_unfurled_twitter_avatars.rb

@@ -0,0 +1,24 @@
+class ContentFilters::StyleUnfurledTwitterAvatars < ActionText::Content::Filter
+  def applicable?
+    unfurled_twitter_avatars.present?
+  end
+
+  def apply
+    fragment.update do |source|
+      div = source.at_css("div")
+      div["class"] = UNFURLED_TWITTER_AVATAR_CSS_CLASS
+    end
+  end
+
+  private
+    UNFURLED_TWITTER_AVATAR_CSS_CLASS = "cf-twitter-avatar"
+    TWITTER_AVATAR_URL_PREFIX = "https://pbs.twimg.com/profile_images"
+
+    def unfurled_twitter_avatars
+      fragment.find_all("#{opengraph_css_selector}[url*='#{TWITTER_AVATAR_URL_PREFIX}']")
+    end
+
+    def opengraph_css_selector
+      "action-text-attachment[@content-type='#{ActionText::Attachment::OpengraphEmbed::OPENGRAPH_EMBED_CONTENT_TYPE}']"
+    end
+end

app/helpers/messages_helper.rb

@@ -1,9 +1,4 @@
 module MessagesHelper
-  # auto_link re-sanitizes with Rails' default safe list, which lacks the
-  # formatting the rich text editor produces
-  AUTO_LINK_ALLOWED_TAGS = Rails::HTML5::SafeListSanitizer.allowed_tags + ContentFilters::EDITOR_FORMATTING_TAGS
-  AUTO_LINK_ALLOWED_ATTRIBUTES = Rails::HTML5::SafeListSanitizer.allowed_attributes + ContentFilters::EDITOR_FORMATTING_ATTRIBUTES
-
   def message_area_tag(room, &)
     tag.div id: "message-area", class: "message-area", contents: true, data: {
       controller: "messages presence drop-target",
@@ -62,8 +57,7 @@ module MessagesHelper
     when "sound"
       message_sound_presentation(message)
     else
-      auto_link h(ContentFilters::TextMessagePresentationFilters.apply(message.body.body)),
+      auto_link h(ContentFilters::TextMessagePresentationFilters.apply(message.body.body)), html: { target: "_blank" }
-        html: { target: "_blank" }, sanitize_options: { tags: AUTO_LINK_ALLOWED_TAGS, attributes: AUTO_LINK_ALLOWED_ATTRIBUTES }
     end
   rescue Exception => e
     Sentry.capture_exception(e, extra: { message: message })

app/helpers/rich_text_helper.rb

@@ -1,33 +1,11 @@
 module RichTextHelper
   def rich_text_data_actions
-    # submitByKeyboard runs in the capture phase so it can submit on Enter
+    default_actions =
-    # before the editor turns the keystroke into a newline
+      "trix-change->typing-notifications#start keydown->composer#submitByKeyboard"
-    "lexxy:change->typing-notifications#start keydown->composer#submitByKeyboard:capture"
-  end
 
-  def mention_prompt_tag(room)
+    autocomplete_actions =
-    tag.lexxy_prompt trigger: "@", name: "mention", src: autocompletable_users_path(room_id: room.id),
+      "trix-focus->rich-autocomplete#focus trix-change->rich-autocomplete#search trix-blur->rich-autocomplete#blur"
-      "remote-filtering": true, "empty-results": "No matches"
-  end
 
-  # The editor keeps an attachment's content as it finds it, so every
+    [ default_actions, autocomplete_actions ].join(" ")
-  # attachment is rebuilt from its attachable before editing: a Trix-era
-  # embed carries its details as node attributes the editor doesn't
-  # round-trip, a mention edited under Trix carries the generic content type
-  # the editor doesn't permit, and a hand-written embed carries whatever
-  # markup the author put there.
-  def editable_body(message)
-    fragment = ActionText::Fragment.wrap(message.body.body_before_type_cast)
-
-    transformed = fragment.replace(ActionText::Attachment.tag_name) do |node|
-      attachment = ActionText::Attachment.from_node(node)
-
-      node.tap do |n|
-        n["content-type"] = attachment.attachable.attachable_content_type
-        n["content"] = render_action_text_attachment(attachment)
-      end
-    end
-
-    ActionText::RichText.new(body: transformed.to_html)
   end
 end

app/helpers/rooms_helper.rb

@@ -73,12 +73,12 @@ module RoomsHelper
     def composer_data_actions
       drag_and_drop_actions = "drop-target:drop@window->composer#dropFiles"
 
-      attachment_actions =
+      trix_attachment_actions =
-        "lexxy:file-accept->composer#preventAttachment refresh-room:online@window->composer#online"
+        "trix-file-accept->composer#preventAttachment refresh-room:online@window->composer#online"
 
       remaining_actions =
         "typing-notifications#stop paste->composer#pasteFiles turbo:submit-end->composer#submitEnd refresh-room:offline@window->composer#offline"
 
-      [ drop_target_actions, drag_and_drop_actions, attachment_actions, remaining_actions ].join(" ")
+      [ drop_target_actions, drag_and_drop_actions, trix_attachment_actions, remaining_actions ].join(" ")
     end
 end

app/javascript/application.js

@@ -1,4 +1,6 @@
 // Configure your import map in config/importmap.rb. Read more: https://github.com/rails/importmap-rails
 import "@hotwired/turbo-rails"
+import "trix"
+import "@rails/actiontext"
 import "initializers"
 import "controllers"

app/javascript/controllers/composer_controller.js

@@ -1,7 +1,7 @@
 import { Controller } from "@hotwired/stimulus"
 import FileUploader from "models/file_uploader"
 import { onNextEventLoopTick, nextFrame } from "helpers/timing_helpers"
-import { escapeHTML } from "helpers/string_helpers"
+import { escapeHTML } from "helpers/dom_helpers"
 
 export default class extends Controller {
   static classes = ["toolbar"]
@@ -12,21 +12,11 @@ export default class extends Controller {
   #files = []
 
   connect() {
-    this.#restoreDraft()
-
     if (!this.#usingTouchDevice) {
       onNextEventLoopTick(() => this.textTarget.focus())
     }
   }
 
-  saveDraft() {
-    if (this.textTarget.isBlank) {
-      localStorage.removeItem(this.#draftKey)
-    } else {
-      localStorage.setItem(this.#draftKey, this.textTarget.value)
-    }
-  }
-
   submit(event) {
     event.preventDefault()
 
@@ -54,20 +44,21 @@ export default class extends Controller {
   }
 
   replaceMessageContent(content) {
-    this.textTarget.value = content
+    const editor = this.textTarget.editor
-    this.textTarget.focus()
+
-    this.textTarget.selection.placeCursorAtTheEnd()
+    editor.recordUndoEntry("Format reply")
+    editor.setSelectedRange([0, editor.getDocument().toString().length])
+    editor.deleteInDirection("forward")
+    editor.insertHTML(content)
+    editor.setSelectedRange([editor.getDocument().toString().length - 1])
   }
 
   submitByKeyboard(event) {
-    if (event.key != "Enter" || this.textTarget.hasOpenPrompt) return
-
     const toolbarVisible = this.element.classList.contains(this.toolbarClass)
-    const metaEnter = event.metaKey || event.ctrlKey
+    const metaEnter = event.key == "Enter" && (event.metaKey || event.ctrlKey)
-    const plainEnter = !event.shiftKey && !event.isComposing
+    const plainEnter = event.keyCode == 13 && !event.shiftKey && !event.isComposing
 
     if (!this.#usingTouchDevice && (metaEnter || (plainEnter && !toolbarVisible))) {
-      event.stopPropagation()
       this.submit(event)
     }
   }
@@ -117,19 +108,6 @@ export default class extends Controller {
     this.fieldsTarget.disabled = true
   }
 
-  #restoreDraft() {
-    const draft = localStorage.getItem(this.#draftKey)
-
-    if (draft) {
-      this.textTarget.value = draft
-      this.textTarget.selection.placeCursorAtTheEnd()
-    }
-  }
-
-  get #draftKey() {
-    return `composer-draft-${this.roomIdValue}`
-  }
-
   get #usingTouchDevice() {
     return 'ontouchstart' in window || navigator.maxTouchPoints > 0 || navigator.msMaxTouchPoints > 0;
   }
@@ -148,7 +126,7 @@ export default class extends Controller {
   }
 
   #validInput() {
-    return !this.textTarget.isBlank
+    return this.textTarget.textContent.trim().length > 0
   }
 
   async #submitFiles() {
@@ -181,7 +159,6 @@ export default class extends Controller {
 
   #reset() {
     this.textTarget.value = ""
-    localStorage.removeItem(this.#draftKey)
   }
 
   #updateFileList() {

app/javascript/controllers/messages_controller.js

@@ -89,7 +89,7 @@ export default class extends Controller {
   }
 
   async editMyLastMessage() {
-    const editorEmpty = document.querySelector("#composer lexxy-editor").isBlank
+    const editorEmpty = document.querySelector("#composer trix-editor").matches(":empty")
 
     if (editorEmpty && this.#paginator.upToDate) {
       this.#myLastMessage?.querySelector(".message__edit-btn")?.click()

app/javascript/controllers/reply_controller.js

@@ -11,7 +11,7 @@ export default class extends Controller {
   }
 
   reply() {
-    const content = `<blockquote>${this.#bodyContent}</blockquote><cite>${this.authorTarget.innerHTML} ${this.#linkToOriginal}</cite><p><br></p>`
+    const content = `<blockquote>${this.#bodyContent}</blockquote><cite>${this.authorTarget.innerHTML} ${this.#linkToOriginal}</cite><br>`
     this.composerOutlet.replaceMessageContent(content)
   }
 
@@ -23,7 +23,7 @@ export default class extends Controller {
   }
 
   get #bodyContent() {
-    const body = this.bodyTarget.querySelector(".lexxy-content").cloneNode(true)
+    const body = this.bodyTarget.querySelector(".trix-content").cloneNode(true)
     return this.#stripMentionAttachments(this.#stripUnfurledAttachments(body)).innerHTML
   }
 

app/javascript/controllers/rich_autocomplete_controller.js

@@ -0,0 +1,46 @@
+import { Controller } from "@hotwired/stimulus"
+import MentionsAutocompleteHandler from "lib/autocomplete/mentions_autocomplete_handler"
+import { debounce } from "helpers/timing_helpers"
+
+export default class extends Controller {
+  static values = { url: String }
+
+  initialize() {
+    this.handlers = []
+    this.search = debounce(this.search.bind(this), 300)
+  }
+
+  connect() {
+    if (this.element == document.activeElement) {
+      this.#installHandlers()
+    }
+  }
+
+  focus(event) {
+    this.#installHandlers()
+  }
+
+  search(event) {
+    const content = this.editor.getDocument().toString()
+    const position = this.editor.getPosition()
+    this.handlers.forEach(handler => handler.updateWithContentAndPosition(content, position))
+  }
+
+  blur(event) {
+    this.#uninstallHandlers()
+  }
+
+  #installHandlers() {
+    this.#uninstallHandlers()
+    this.handlers = [ new MentionsAutocompleteHandler(this.element, this.urlValue) ]
+  }
+
+  #uninstallHandlers() {
+    this.handlers.forEach(handler => handler.destroy())
+    this.handlers = []
+  }
+
+  get editor() {
+    return this.element.editor
+  }
+}

app/javascript/controllers/unfurl_controller.js

@@ -1,84 +0,0 @@
-import { Controller } from "@hotwired/stimulus"
-import { post } from "@rails/request.js"
-import { escapeHTML, truncateString } from "helpers/string_helpers"
-
-const OPENGRAPH_EMBED_CONTENT_TYPE = "application/vnd.actiontext.opengraph-embed"
-
-const UNFURLED_TWITTER_AVATAR_CSS_CLASS = "og-embed--twitter-avatar"
-const TWITTER_AVATAR_URL_PREFIX = "https://pbs.twimg.com/profile_images"
-
-export default class extends Controller {
-  #abortController
-
-  disconnect() {
-    this.#abortController?.abort()
-  }
-
-  async unfurl(event) {
-    if (!this.element.permitsAttachmentContentType(OPENGRAPH_EMBED_CONTENT_TYPE)) return
-
-    const { url, insertBelowLink } = event.detail
-
-    const metadata = await this.#fetchOpengraphMetadata(url)
-
-    if (metadata) {
-      insertBelowLink(this.#opengraphEmbedHTML(metadata), { attachment: { contentType: OPENGRAPH_EMBED_CONTENT_TYPE } })
-    }
-  }
-
-  async #fetchOpengraphMetadata(url) {
-    this.#abortController?.abort()
-    this.#abortController = new AbortController()
-
-    try {
-      const response = await post("/unfurl_link", {
-        body: { url },
-        contentType: "application/json",
-        signal: this.#abortController.signal
-      })
-
-      if (response.ok && response.statusCode !== 204) {
-        const { title, url: href, image, description } = await response.json
-        if (title && href) return { title, href, image, description }
-      }
-    } catch {
-      // Ignore aborted and failed requests
-    }
-
-    return null
-  }
-
-  #opengraphEmbedHTML({ title, href, image, description }) {
-    return `<actiontext-opengraph-embed>
-      <div class="og-embed gap ${this.#embedClass(image)}">
-        <div class="og-embed__content">
-          <div class="og-embed__title">
-            <a href="${escapeHTML(href)}" rel="noreferrer" target="_blank">${escapeHTML(truncateString(title, 280))}</a>
-          </div>
-          <div class="og-embed__description">${escapeHTML(truncateString(description, 560))}</div>
-        </div>
-        ${this.#imageHTML(image)}
-      </div>
-    </actiontext-opengraph-embed>`
-  }
-
-  #embedClass(image) {
-    if (this.#isTwitterAvatar(image)) {
-      return UNFURLED_TWITTER_AVATAR_CSS_CLASS
-    } else {
-      return ""
-    }
-  }
-
-  #isTwitterAvatar(image) {
-    return Boolean(image) && image.startsWith(TWITTER_AVATAR_URL_PREFIX)
-  }
-
-  #imageHTML(image) {
-    if (image) {
-      return `<div class="og-embed__image"><img src="${escapeHTML(image)}" class="image center" alt="" /></div>`
-    } else {
-      return ""
-    }
-  }
-}

app/javascript/helpers/dom_helpers.js

@@ -4,6 +4,12 @@ export function scrollToBottom(container) {
   container.scrollTop = container.scrollHeight
 }
 
+export function escapeHTML(html) {
+  const div = document.createElement("div")
+  div.textContent = html
+  return div.innerHTML
+}
+
 export function parseHTMLFragment(html) {
   const template = document.createElement("template")
   template.innerHTML = html

app/javascript/helpers/string_helpers.js

@@ -1,5 +1,3 @@
-const HTML_ESCAPES = { "&": "&amp;", "<": "&lt;", ">": "&gt;", "\"": "&quot;", "'": "&#39;" }
-
 export function truncateString(string, length, omission = "…") {
   if (string.length <= length) {
     return string
@@ -7,7 +5,3 @@ export function truncateString(string, length, omission = "…") {
     return string.slice(0, length - omission.length) + omission
   }
 }
-
-export function escapeHTML(string) {
-  return String(string ?? "").replace(/[&<>"']/g, character => HTML_ESCAPES[character])
-}

app/javascript/initializers/rich_text.js

@@ -1,19 +1,10 @@
-import * as Lexxy from "lexxy"
+import Unfurler from "lib/rich_text/unfurl/unfurler"
-import CampfireRichTextExtension from "lib/rich_text/campfire_extension"
 
-Lexxy.configure({
+// Support a `cite` block for attribution links
-  global: {
+Trix.config.blockAttributes.cite = {
-    // Keep the content type of mention attachments (application/vnd.campfire.mention)
+  tagName: "cite",
-    // that Campfire has used since its Trix days
+  inheritable: false,
-    attachmentContentTypeNamespace: "campfire",
+}
-    extensions: [ CampfireRichTextExtension ]
-  },
-  default: {
-    // Campfire sends files as separate messages via the composer's own
-    // attach button, never through the editor
-    toolbar: { attachments: false },
 
-    // Trix offered a single heading level, rendered as h1
+const unfurler = new Unfurler()
-    headings: [ "h1" ]
+unfurler.install()
-  }
-})

app/javascript/lib/autocomplete/mentions_autocomplete_handler.js

@@ -0,0 +1,48 @@
+import BaseAutocompleteHandler from "lib/autocomplete/base_autocomplete_handler"
+import { PUNCTUATION_PATTERN } from "lib/autocomplete/constants"
+
+export default class extends BaseAutocompleteHandler {
+  get pattern() {
+    return new RegExp(`^@(.*?)(${PUNCTUATION_PATTERN.source}*)$`)
+  }
+
+  insertAutocompletable(autocompletable, range, terminator, options = {}) {
+    const attachment = this.#createAttachmentForAutocompletable(autocompletable)
+    this.#insertAttachmentAndTerminatorIntoEditorAtRange(attachment, terminator, range, options)
+  }
+
+  // Override to set selector's position relative to the cursor in the editor
+  getOffsetsAtPosition(position) {
+    return this.#getOffsetsFromEditorAtPosition(this.#editor, position)
+  }
+
+  #createAttachmentForAutocompletable(mentionable) {
+    const mention = `
+      <span class="mention" sgid=${mentionable.sgid}>
+        <img src="${mentionable.avatar_url}" class="avatar" alt="${mentionable.name}">
+        ${mentionable.name}
+      </span>
+    `
+
+    return new Trix.Attachment({
+      content: mention,
+      contentType: "application/vnd.campfire.mention",
+      sgid: mentionable.sgid
+    })
+  }
+
+  #insertAttachmentAndTerminatorIntoEditorAtRange(attachment, terminator, range) {
+    if (range) { this.#editor.setSelectedRange(range) }
+    this.#editor.insertAttachment(attachment)
+    this.#editor.insertString(terminator)
+  }
+
+  get #editor() {
+    return this.element.editor
+  }
+
+  #getOffsetsFromEditorAtPosition(editor, position) {
+    const rect = this.#editor.getClientRectAtPosition(position)
+    return rect ? rect : {}
+  }
+}

app/javascript/lib/rich_text/campfire_extension.js

@@ -1,24 +0,0 @@
-import * as Lexxy from "lexxy"
-import CiteNode from "lib/rich_text/cite_node"
-
-export default class CampfireRichTextExtension extends Lexxy.Extension {
-  get allowedElements() {
-    return [
-      "cite",
-      "figure",
-      "figcaption",
-      "actiontext-opengraph-embed",
-      { tag: "div", attributes: [ "sgid" ] },
-      { tag: "span", attributes: [ "sgid" ] },
-      { tag: "img", attributes: [ "alt" ] },
-      { tag: "a", attributes: [ "rel", "target" ] }
-    ]
-  }
-
-  get lexicalExtension() {
-    return this.defineExtension({
-      name: "campfire/rich-text",
-      nodes: [ CiteNode ]
-    })
-  }
-}

app/javascript/lib/rich_text/cite_node.js

@@ -1,39 +0,0 @@
-import * as Lexxy from "lexxy"
-
-const { ElementNode } = Lexxy.Lexical
-
-export default class CiteNode extends ElementNode {
-  static getType() {
-    return "cite"
-  }
-
-  static clone(node) {
-    return new CiteNode(node.__key)
-  }
-
-  static importJSON(serializedNode) {
-    return new CiteNode().updateFromJSON(serializedNode)
-  }
-
-  static importDOM() {
-    return {
-      cite: () => ({ conversion: () => ({ node: new CiteNode() }), priority: 1 })
-    }
-  }
-
-  exportJSON() {
-    return { ...super.exportJSON(), type: "cite" }
-  }
-
-  createDOM() {
-    return document.createElement("cite")
-  }
-
-  updateDOM() {
-    return false
-  }
-
-  exportDOM() {
-    return { element: document.createElement("cite") }
-  }
-}

app/javascript/lib/rich_text/unfurl/lib/opengraph_embed_operation.js

@@ -0,0 +1,80 @@
+import { post } from "@rails/request.js"
+import { truncateString } from "helpers/string_helpers"
+
+const UNFURLED_TWITTER_AVATAR_CSS_CLASS = "cf-twitter-avatar"
+const TWITTER_AVATAR_URL_PREFIX = "https://pbs.twimg.com/profile_images"
+
+export default class OpengraphEmbedOperation {
+  constructor(paste) {
+    this.paste = paste
+    this.editor = this.paste.editor
+    this.url = this.paste.string
+
+    this.abortController = new AbortController()
+  }
+
+  perform() {
+    return this.#createOpenGraphMetadataRequest()
+      .then(response => response.json)
+      .then(this.#insertOpengraphAttachment.bind(this))
+      .catch(() => null)
+  }
+
+  abort() {
+    this.abortController.abort()
+  }
+
+  #createOpenGraphMetadataRequest() {
+    return post("/unfurl_link", {
+      body: { url: this.url },
+      contentType: "application/json",
+      signal: this.abortController.signal
+    })
+  }
+
+  #insertOpengraphAttachment(response) {
+    if (this.#shouldInsertOpengraphPreview) {
+      const currentRange = this.editor.getSelectedRange()
+      this.editor.setSelectedRange(this.editor.getSelectedRange())
+      this.editor.recordUndoEntry("Insert Opengraph preview for Pasted URL")
+      this.editor.insertAttachment(this.#createOpengraphAttachment(response))
+      this.editor.setSelectedRange(currentRange)
+    }
+  }
+
+  get #shouldInsertOpengraphPreview() {
+    return this.editor.getDocument().toString().includes(this.url)
+  }
+
+  #createOpengraphAttachment(response) {
+    const { title, url, image, description } = response
+    const html = this.#generateOpengraphEmbedHTML({ title, url, image, description })
+
+    return new Trix.Attachment({
+      contentType: "application/vnd.actiontext.opengraph-embed",
+      content: html,
+      filename: title,
+      href: url,
+      url: image,
+      caption: description
+    })
+  }
+
+  #generateOpengraphEmbedHTML(embed) {
+    return `<actiontext-opengraph-embed class="${this.#isTwitterAvatar(embed) ? UNFURLED_TWITTER_AVATAR_CSS_CLASS : ''}">
+      <div class="og-embed">
+        <div class="og-embed__content">
+          <div class="og-embed__title">${truncateString(embed.title, 560)}</div>
+          <div class="og-embed__description">${truncateString(embed.description, 560)}</div>
+        </div>
+        <div class="og-embed__image">
+          <img src="${embed.image}" class="image" alt="" />
+        </div>
+      </div>
+    </actiontext-opengraph-embed>`
+  }
+
+  #isTwitterAvatar(embed) {
+    return embed.image.startsWith(TWITTER_AVATAR_URL_PREFIX)
+  }
+}

app/javascript/lib/rich_text/unfurl/lib/paste.js

@@ -0,0 +1,39 @@
+export default class Paste {
+  constructor(range, editor, document) {
+    this.range = range
+    this.editor = editor
+    this.document = document
+    if (this.document == null) { this.document = this.editor.getDocument() }
+    this.string = this.document.getStringAtRange(this.range)
+  }
+
+  isURL() {
+    return /^(?:[a-z0-9]+:\/\/|www\.)[^\s]+$/.test(this.string)
+  }
+
+  getPathname() {
+    const a = document.createElement("a")
+    a.href = this.string
+    return a.pathname
+  }
+
+  isLinked() {
+    const {href} = this.getCommonAttributes()
+    return (href != null) && (href !== this.string)
+  }
+
+  getCommonAttributes() {
+    return this.document.getCommonAttributesAtRange(this.range)
+  }
+
+  getSignificantPaste() {
+    return new this.constructor(this.getSignificantRange(), this.editor, this.document)
+  }
+
+  getSignificantRange() {
+    const significantString = this.string.trim()
+    const startOffset = this.range[0] + this.string.indexOf(significantString)
+    const endOffset = startOffset + significantString.length
+    return [startOffset, endOffset]
+  }
+}

app/javascript/lib/rich_text/unfurl/unfurler.js

@@ -0,0 +1,59 @@
+import OpengraphEmbedOperation from "lib/rich_text/unfurl/lib/opengraph_embed_operation"
+import Paste from "lib/rich_text/unfurl/lib/paste"
+
+const performOperation = (function() {
+  let operation = null
+  let requestId = null
+
+  return function(operationToPerform) {
+    operation?.abort()
+    cancelAnimationFrame(requestId)
+
+    requestId = requestAnimationFrame(function() {
+      operation = operationToPerform
+      operation.perform().then(() => operation = null)
+    })
+  }
+})()
+
+export default class Unfurler {
+  install() {
+    this.#addEventListeners()
+  }
+
+  #addEventListeners() {
+    addEventListener("trix-initialize", function(event) {
+      if (this.#editorElementPermitsAttribute(event.target, "href")) {
+        return event.target.addEventListener("trix-paste", this.#didPaste.bind(this))
+      }
+    }.bind(this))
+  }
+
+  #didPaste(event) {
+    const {range} = event.paste
+    const {editor} = event.target
+
+    if (range != null) {
+      const paste = new Paste(range, editor).getSignificantPaste()
+
+      if (paste.isURL()) {
+        if (this.#editorElementPermitsOpengraphAttachment(event.target)) {
+          performOperation(new OpengraphEmbedOperation(paste))
+        }
+      }
+    }
+  }
+
+  #editorElementPermitsAttribute(element, attributeName) {
+    if (element.hasAttribute("data-permitted-attributes")) {
+      return Array.from(element.getAttribute("data-permitted-attributes").split(" ")).includes(attributeName)
+    } else {
+      return true
+    }
+  }
+
+  #editorElementPermitsOpengraphAttachment(element) {
+    const permittedAttachmentTypes = element.getAttribute("data-permitted-attachment-types")
+    return permittedAttachmentTypes && permittedAttachmentTypes.includes("application/vnd.actiontext.opengraph-embed")
+  }
+}

app/javascript/models/client_message.js

@@ -18,7 +18,7 @@ export default class ClientMessage {
       body,
       messageTimestamp: Math.floor(now.getTime()),
       messageDatetime: now.toISOString(),
-      messageClasses: this.#messageClassesFromNode(node),
+      messageClasses: this.#containsOnlyEmoji(node.textContent) ? "message--emoji" : "",
     })
   }
 
@@ -52,37 +52,26 @@ export default class ClientMessage {
     }
   }
 
-  #messageClassesFromNode(node) {
-    if (this.#containsOnlyEmoji(this.#plainTextFromNode(node))) {
-      return "message--emoji"
-    } else {
-      return ""
-    }
-  }
-
 
   #isPlayCommand(node) {
     return this.#matchPlayCommand(node)
   }
 
   #matchPlayCommand(node) {
-    return this.#plainTextFromNode(node)?.match(new RegExp(`^/play (${SOUND_NAMES.join("|")})`))?.[1]
+    return this.#stripWrapperElement(node)?.match(new RegExp(`^/play (${SOUND_NAMES.join("|")})`))?.[1]
   }
 
-  #plainTextFromNode(node) {
+  #stripWrapperElement(node) {
-    if (this.#isRichText(node)) {
+    return node.innerHTML?.replace(/<div>(?:<!--[\s\S]*?-->)*([\s\S]*?)<\/div>/i, '$1')
-      return node.toString().trim()
-    } else {
-      return node
-    }
   }
 
+
   #isRichText(node) {
     return typeof(node) != "string"
   }
 
   #richTextContent(node) {
-    return `<div class="lexxy-content">${node.value}</div>`
+    return `<div class="trix-content">${node.innerHTML}</div>`
   }
 
 

app/javascript/models/message_formatter.js

@@ -76,21 +76,7 @@ export default class MessageFormatter {
   }
 
   #highlightCodeBlock(block) {
-    this.#normalizeLineBreaks(block)
+    if (this.#isPlainText(block)) window.hljs.highlightElement(block)
-
-    if (this.#isPlainText(block)) {
-      const language = block.dataset.language
-      if (language && window.hljs.getLanguage(language)) {
-        block.classList.add(`language-${language}`)
-      }
-
-      window.hljs.highlightElement(block)
-    }
-  }
-
-  // Lexxy breaks code block lines with <br>, Trix-era blocks used newlines
-  #normalizeLineBreaks(block) {
-    block.querySelectorAll("br").forEach(br => br.replaceWith("\n"))
   }
 
   #isPlainText(element) {

app/models/message/broadcasts.rb

@@ -1,19 +1,10 @@
 module Message::Broadcasts
   def broadcast_create
     broadcast_append_to room, :messages, target: [ room, :messages ]
-    broadcast_unread_room
+    ActionCable.server.broadcast("unread_rooms", { roomId: room.id })
   end
 
   def broadcast_remove
     broadcast_remove_to room, :messages
   end
-
-  private
-    # Fanned out to the room's members rather than published on one global stream, so
-    # that the timing of activity in a room only reaches people who are in it.
-    def broadcast_unread_room
-      room.memberships.pluck(:user_id).each do |user_id|
-        ActionCable.server.broadcast UnreadRoomsChannel.stream_name_for(user_id), { roomId: room.id }
-      end
-    end
 end

app/models/push/subscription.rb

@@ -1,61 +1,7 @@
-require "restricted_http/private_network_guard"
-
 class Push::Subscription < ApplicationRecord
-  PERMITTED_ENDPOINT_HOSTS = %w[
-    jmt17.google.com
-    fcm.googleapis.com
-    updates.push.services.mozilla.com
-    web.push.apple.com
-    notify.windows.com
-  ].freeze
-
   belongs_to :user
 
-  validates :endpoint, presence: true
-  validate :validate_endpoint_url
-
   def notification(**params)
-    # Defer DNS lookup to the delivery worker to prevent rebinding
+    WebPush::Notification.new(**params, badge: user.memberships.unread.count, endpoint: endpoint, p256dh_key: p256dh_key, auth_key: auth_key)
-    WebPush::Notification.new(**params, badge: user.memberships.unread.count, endpoint: endpoint, endpoint_ip_resolver: method(:resolved_endpoint_ip), p256dh_key: p256dh_key, auth_key: auth_key)
   end
-
-  # Validate at point of use, not just when saved.
-  def resolved_endpoint_ip
-    RestrictedHTTP::PrivateNetworkGuard.resolve(endpoint_uri.host) if permitted_endpoint_uri?
-  rescue RestrictedHTTP::Violation, Surfguard::Unresolvable
-    nil
-  end
-
-  private
-    # Validate endpoint shape. Belt & suspenders.
-    def permitted_endpoint_uri?
-      endpoint_uri&.scheme == "https" && endpoint_uri.port == 443 && permitted_endpoint_host?
-    end
-
-    def endpoint_uri
-      URI.parse(endpoint) if endpoint.present?
-    rescue URI::InvalidURIError
-      nil
-    end
-
-    def validate_endpoint_url
-      if endpoint_uri.nil?
-        errors.add(:endpoint, "is not a valid URL")
-      elsif endpoint_uri.scheme != "https"
-        errors.add(:endpoint, "must use HTTPS")
-      elsif endpoint_uri.port != 443
-        errors.add(:endpoint, "must use the default HTTPS port")
-      elsif !permitted_endpoint_host?
-        errors.add(:endpoint, "is not a permitted push service")
-      elsif resolved_endpoint_ip.nil?
-        errors.add(:endpoint, "resolves to a private or invalid IP address")
-      end
-    end
-
-    def permitted_endpoint_host?
-      host = endpoint_uri&.host&.downcase
-      host.present? && PERMITTED_ENDPOINT_HOSTS.any? do |permitted|
-        host == permitted || host.end_with?(".#{permitted}")
-      end
-    end
 end

app/models/room.rb

@@ -22,8 +22,6 @@ class Room < ApplicationRecord
 
   belongs_to :creator, class_name: "User", default: -> { Current.user }
 
-  validate :direct_rooms_keep_their_type, on: :update
-
   scope :opens,           -> { where(type: "Rooms::Open") }
   scope :closeds,         -> { where(type: "Rooms::Closed") }
   scope :directs,         -> { where(type: "Rooms::Direct") }
@@ -67,15 +65,6 @@ class Room < ApplicationRecord
   end
 
   private
-    # Open and closed rooms convert into each other freely. A direct room can't become
-    # either: its participants agreed to a private conversation, not to one whose
-    # audience someone else gets to widen afterwards.
-    def direct_rooms_keep_their_type
-      if type_changed? && type_was == "Rooms::Direct"
-        errors.add :type, "can't be changed for a direct room"
-      end
-    end
-
     def unread_memberships(message)
       memberships.visible.disconnected.where.not(user: message.creator).update_all(unread_at: message.created_at, updated_at: Time.current)
     end

app/models/user/mentionable.rb

@@ -1,13 +1,11 @@
 module User::Mentionable
   include ActionText::Attachable
 
-  MENTION_CONTENT_TYPE = "application/vnd.campfire.mention"
+  def to_attachable_partial_path
-
+    "users/mention"
-  def attachable_content_type
-    MENTION_CONTENT_TYPE
   end
 
-  def to_attachable_partial_path
+  def to_trix_content_attachment_partial_path
     "users/mention"
   end
 

app/views/action_text/attachables/_opengraph_embed.html.erb

@@ -1,11 +1,11 @@
 <figure class="attachment attachment--content attachment--og">
   <actiontext-opengraph-embed>
-    <div class="og-embed gap <%= "og-embed--twitter-avatar" if opengraph_embed.twitter_avatar? %>">
+    <div class="og-embed gap">
       <div class="og-embed__content">
         <div class="og-embed__title">
-          <%= link_to_if opengraph_embed.href.present?, truncate(opengraph_embed.filename, length: 280, omission: "…"), opengraph_embed.href, rel: "noreferrer", target: "_blank" %>
+          <%= link_to truncate(opengraph_embed.filename, length: 280, omission: "…"), opengraph_embed.href, rel: "noreferrer", target: "_blank" %>
         </div>
-        <div class="og-embed__description"><%= truncate(opengraph_embed.description.to_s, length: 560, omission: "…") %></div>
+        <div class="og-embed__description"><%= truncate(opengraph_embed.caption, length: 560, omission: "…").html_safe %></div>
       </div>
       <% if opengraph_embed.url %>
         <div class="og-embed__image">

app/views/autocompletable/users/_prompt_item.html.erb

@@ -1,11 +0,0 @@
-<lexxy-prompt-item search="<%= user.name %>" sgid="<%= user.attachable_sgid %>">
-  <template type="menu">
-    <span class="autocomplete__item flex align-center gap unpad">
-      <%= avatar_tag user %>
-      <span class="autocompletable__name"><%= user.name %></span>
-    </span>
-  </template>
-  <template type="editor">
-    <%= render "users/mention", user: user %>
-  </template>
-</lexxy-prompt-item>

app/views/autocompletable/users/index.html.erb

@@ -1 +0,0 @@
-<%= render partial: "autocompletable/users/prompt_item", collection: @page.records, as: :user %>

app/views/layouts/action_text/contents/_content.html.erb

@@ -1,3 +1,3 @@
-<div class="lexxy-content">
+<div class="trix-content">
   <%= yield -%>
 </div>

app/views/messages/_message.html.erb

@@ -1,7 +1,6 @@
 <%# Be sure to check/update messages/_template.html.erb when changing this file %>
 
-<%# Bump this version when the message presentation filters change what they emit. Editing this line changes the template digest, which busts BOTH this fragment cache and the collection cache that keys on this partial's digest (helper Ruby changes alone don't). %>
+<% cache message do %>
-<% cache [ message, "presentation-v3" ] do %>
   <%= message_tag message do %>
     <h2 class="message__day-separator"><%= local_datetime_tag message.created_at, style: :date %></h2>
 

app/views/messages/_message.json.jbuilder

@@ -1,18 +0,0 @@
-json.cache! message do
-  json.(message, :id)
-
-  json.created_at message.created_at.utc
-
-  json.body do
-    json.plain_text message.plain_text_body
-    json.html message.body.to_s
-  end
-
-  json.creator message.creator, partial: "users/user", as: :user
-
-  json.room do
-    json.id message.room_id
-  end
-
-  json.url room_message_url(message.room, message)
-end

app/views/messages/boosts/_boost.json.jbuilder

@@ -1,12 +0,0 @@
-json.cache! boost do
-  json.(boost, :id, :content)
-
-  json.created_at boost.created_at.utc
-
-  json.booster boost.booster, partial: "users/user", as: :user
-
-  json.message do
-    json.id boost.message_id
-    json.url room_message_url(boost.message.room, boost.message)
-  end
-end

app/views/messages/boosts/by_bots/show.json.jbuilder

@@ -1 +0,0 @@
-json.partial! "messages/boosts/boost", boost: @boost

app/views/messages/by_bots/index.json.jbuilder

@@ -1 +0,0 @@
-json.array! @messages, partial: "messages/message", as: :message

app/views/messages/by_bots/show.json.jbuilder

@@ -1 +0,0 @@
-json.partial! "messages/message", message: @message

app/views/messages/edit.html.erb

@@ -14,18 +14,17 @@
       <% else %>
         <div class="composer--edit composer--rich-text">
           <%= form_with model: @message, url: room_message_path(@room, @message), id: dom_id(@message, :form), data: {
-                controller: "form", action: "lexxy:file-accept->form#preventAttachment keydown.esc->form#cancel keydown.ctrl+enter->form#submit:prevent keydown.meta+enter->form#submit:prevent" } do |form| %>
+                controller: "form", action: "trix-file-accept->form#preventAttachment keydown.esc->form#cancel keydown.ctrl+enter->form#submit:prevent keydown.meta+enter->form#submit:prevent" } do |form| %>
             <div class="full-width input input--actor min-width fill-white">
               <%= form.rich_text_area :body,
-                    value: editable_body(@message),
                     rows: 1,
-                    class: "input lexxy-content",
+                    class: "input",
                     aria: { multiline: "true", label: "Edit message" },
                     autofocus: true,
-                    "permitted-attachment-types": "application/vnd.campfire.mention application/vnd.actiontext.opengraph-embed",
+                    data: {
-                    data: { action: rich_text_data_actions } do %>
+                      controller: "rich-autocomplete",
-                <%= mention_prompt_tag @room %>
+                      action: rich_text_data_actions,
-              <% end %>
+                      rich_autocomplete_url_value: autocompletable_users_path(room_id: @room.id) } %>
             </div>
 
             <%= link_to "Close editor and discard changes", room_message_path(@room, @message), data: { form_target: "cancel" }, hidden: true %>

app/views/rooms/show.html.erb

@@ -17,7 +17,7 @@
     <%= render partial: "messages/message", collection: @messages, cached: true %>
   <% end %>
 
-  <%= turbo_stream_from @room, :messages, channel: "RoomMessagesChannel" %>
+  <%= turbo_stream_from @room, :messages %>
   <%= button_to_jump_to_newest_message %>
 <% end %>
 

app/views/rooms/show/_composer.html.erb

@@ -19,16 +19,15 @@
                 <div class="flex flex-column flex-item-grow min-width gap">
                   <%= form.rich_text_area :body,
                         rows: 1,
-                        class: "input lexxy-content",
+                        class: "input",
                         style: "order: -1",
                         aria: { multiline: "true", label: "Write a message" },
-                        "permitted-attachment-types": "application/vnd.campfire.mention application/vnd.actiontext.opengraph-embed",
                         data: {
-                          controller: "unfurl",
+                          controller: "rich-autocomplete",
-                          action: "#{rich_text_data_actions} lexxy:change->composer#saveDraft lexxy:insert-link->unfurl#unfurl",
+                          action: rich_text_data_actions,
-                          composer_target: "text" } do %>
+                          rich_autocomplete_url_value: autocompletable_users_path(room_id: room.id),
-                    <%= mention_prompt_tag room %>
+                          permitted_attachment_types: "application/vnd.actiontext.opengraph-embed",
-                  <% end %>
+                          composer_target: "text" } %>
                 </div>
 
                 <label class="btn btn--borderless txt-small flex-item-no-shrink composer__attachment-btn input--file">

app/views/users/_mention.html.erb

@@ -1,4 +1,4 @@
-<%# A span rather than a div: mentions render inline inside the <p> paragraphs
+<div class="mention" sgid="<%= user.attachable_sgid %>">
-    the editor produces, and block elements would make the browser split the
+  <%= avatar_tag user %>
-    paragraph when parsing %>
+  <%= user.name %>
-<span class="mention" sgid="<%= user.attachable_sgid %>"><%= avatar_tag user %> <%= user.name %></span>
+</div>

app/views/users/_user.json.jbuilder

@@ -1,5 +0,0 @@
-json.cache! user do
-  json.(user, :id, :name, :role)
-
-  json.avatar_url fresh_user_avatar_url(user)
-end

bin/brakeman

@@ -2,6 +2,6 @@
 require "rubygems"
 require "bundler/setup"
 
-ARGV.unshift("--ensure-latest", "15")
+ARGV.unshift("--ensure-latest")
 
 load Gem.bin_path("brakeman", "brakeman")

bin/release

@@ -15,11 +15,9 @@ include SSHKit::DSL
 ARCH = "linux/amd64,linux/arm64"
 BUILDER_NAME = "campfire-builder"
 GIT_SHA = `git rev-parse HEAD`.strip
-MANUAL_NOTES = ARGV.delete("--notes")
 VERSION = ARGV[0]
 
-DOCKER_REGISTRY = "registry.once.com"
+DOCKER_IMAGE_NAME = "registry.once.com/campfire"
-DOCKER_IMAGE_NAME = "#{DOCKER_REGISTRY}/campfire"
 DOCKER_LATEST_IMAGE_NAME = [ DOCKER_IMAGE_NAME, :latest ].join(":")
 DOCKER_TAGGED_IMAGE_NAME = [ DOCKER_IMAGE_NAME, GIT_SHA ].join(":")
 
@@ -30,7 +28,7 @@ EXPORT_REMOTE_USER = "app"
 EXPORT_DEPLOY_HOSTS = %w[ once-store-app-101 once-store-app-102 ]
 EXPORT_DEPLOY_LOCATION = "/local/app/product_releases/"
 
-abort "You must specify a version, e.g. `bin/release 1.0.0` (pass --notes to write release notes manually)" unless VERSION
+abort "You must specify a version, e.g. `bin/release 1.0.0`" unless VERSION
 
 current_branch = `git rev-parse --abbrev-ref HEAD`.strip
 if current_branch != "main"
@@ -48,18 +46,6 @@ def announcing(message)
   yield
 end
 
-announcing "Checking #{DOCKER_REGISTRY} login..." do
-  unless system "docker", "manifest", "inspect", DOCKER_LATEST_IMAGE_NAME, out: File::NULL, err: File::NULL
-    abort <<~MESSAGE
-      Not logged in to #{DOCKER_REGISTRY}. Run:
-
-        docker login #{DOCKER_REGISTRY}
-
-      The credentials are in the "chatinabox" entry in 1Password.
-    MESSAGE
-  end
-end
-
 on(:local) do
   builder_found = test :docker, :buildx, :inspect, BUILDER_NAME
 
@@ -71,25 +57,19 @@ on(:local) do
 end
 
 announcing "Creating GitHub release v#{VERSION}..." do
+  notes_file = "tmp/release_notes.md"
+
   on(:local) do
-    if MANUAL_NOTES
+    execute :mkdir, "-p", "tmp"
-      notes_file = "tmp/release_notes.md"
 
-      execute :mkdir, "-p", "tmp"
+    File.write(notes_file, "# What's Changed\n\n- \n")
+    system ENV["EDITOR"] || "vim", notes_file
 
-      File.write(notes_file, "# What's Changed\n\n- \n")
+    unless system "gh", "release", "create", "v#{VERSION}", "--title", "v#{VERSION}", "--notes-file", notes_file
-      system ENV["EDITOR"] || "vim", notes_file
+      abort "Failed to create release; check that the version doesn't already exist"
-
-      unless system "gh", "release", "create", "v#{VERSION}", "--title", "v#{VERSION}", "--notes-file", notes_file
-        abort "Failed to create release; check that the version doesn't already exist"
-      end
-
-      execute :rm, notes_file
-    else
-      unless system "gh", "release", "create", "v#{VERSION}", "--title", "v#{VERSION}", "--generate-notes"
-        abort "Failed to create release; check that the version doesn't already exist"
-      end
     end
+
+    execute :rm, notes_file
   end
 end
 

config/cable.yml

@@ -1,6 +1,6 @@
 default: &default
   adapter: redis
-  url: <%= ENV.fetch("REDIS_URL") { "redis://localhost:6379" } %>
+  url: redis://localhost:6379
 
 development:
   <<: *default

config/environments/production.rb

@@ -1,6 +1,5 @@
 require "active_support/core_ext/integer/time"
 require "active_support/core_ext/numeric/bytes"
-require_relative "../../lib/rails_ext/log_scrubbing_formatter"
 
 Rails.application.configure do
   # Settings specified here will take precedence over those in config/application.rb.
@@ -51,7 +50,7 @@ Rails.application.configure do
 
   # Log to STDOUT by default
   config.logger = ActiveSupport::Logger.new(STDOUT)
-    .tap  { |logger| logger.formatter = LogScrubbingFormatter.new }
+    .tap  { |logger| logger.formatter = ::Logger::Formatter.new }
     .then { |logger| ActiveSupport::TaggedLogging.new(logger) }
 
   # Prepend all log lines with the following tags.

config/importmap.rb

@@ -5,7 +5,8 @@ pin "@hotwired/stimulus-loading", to: "stimulus-loading.js"
 pin "@hotwired/turbo-rails", to: "turbo.js"
 pin "@rails/actioncable", to: "actioncable.esm.js"
 pin "@rails/request.js", to: "@rails--request.js" # @0.0.8
-pin "lexxy", to: "lexxy.js"
+pin "trix", to: "trix.esm.min.js" # @2.1.19
+pin "@rails/actiontext", to: "actiontext.js"
 pin "highlight.js", to: "highlight.js/core.js"
 
 pin_all_from "app/javascript/initializers", under: "initializers"

config/initializers/active_storage_authentication.rb

@@ -1,15 +0,0 @@
-# Active Storage mounts its direct-upload write endpoints
-# (POST /rails/active_storage/direct_uploads and the disk-service PUT) on
-# framework controllers that inherit from ActiveStorage::BaseController, so
-# they never pass through ApplicationController's require_authentication.
-# Campfire uploads attachments through MessagesController instead and does not
-# use direct uploads at all, leaving these endpoints reachable by anyone who
-# can read the public login page. Require a valid Campfire session before an
-# anonymous caller can allocate a Blob or persist bytes to disk.
-Rails.application.config.to_prepare do
-  ActiveStorage::DirectUploadsController.include ActiveStorageAuthentication
-  ActiveStorage::DirectUploadsController.before_action :require_active_storage_authentication
-
-  ActiveStorage::DiskController.include ActiveStorageAuthentication
-  ActiveStorage::DiskController.before_action :require_active_storage_authentication, only: :update
-end

config/initializers/resque.rb

@@ -1 +0,0 @@
-Resque.redis = ENV.fetch("REDIS_URL") { "redis://localhost:6379" }

config/initializers/turbo_streams_authorization.rb

@@ -1,3 +0,0 @@
-Rails.application.config.to_prepare do
-  Turbo::StreamsChannel.prepend RoomStreamsAreAuthorized
-end

config/initializers/web_push.rb

@@ -17,25 +17,7 @@ end
 
 module WebPush::PersistentRequest
   def perform
-    if endpoint_ip = @options[:endpoint_ip]
+    if @options[:connection]
-      # Pin the connection to the public IP resolved (and guarded) by
-      # Push::Subscription so delivery can't be rebound to a private address
-      # between resolution and connect. Bypasses the shared persistent pool,
-      # which would re-resolve the host itself.
-      #
-      # The explicit nil proxy address disables proxy discovery from
-      # http_proxy/https_proxy. An egress proxy would open the TCP connection
-      # itself and re-resolve the endpoint host, so http.ipaddr would no longer
-      # pin the destination and the DNS-rebinding guarantee would be lost. This
-      # path is already committed to a direct connection (it bypasses the pool);
-      # push delivery to public vendor endpoints goes direct.
-      http = Net::HTTP.new(uri.host, uri.port, nil)
-      http.ipaddr = endpoint_ip
-      http.use_ssl = true
-      http.ssl_timeout = @options[:ssl_timeout] unless @options[:ssl_timeout].nil?
-      http.open_timeout = @options[:open_timeout] unless @options[:open_timeout].nil?
-      http.read_timeout = @options[:read_timeout] unless @options[:read_timeout].nil?
-    elsif @options[:connection]
       http = @options[:connection]
     else
       http = Net::HTTP.new(uri.host, uri.port, *proxy_options)

config/routes.rb

@@ -62,13 +62,7 @@ Rails.application.routes.draw do
   resources :rooms do
     resources :messages
 
-    nested do
+    post ":bot_key/messages", to: "messages/by_bots#create", as: :bot_messages
-      scope path: ":bot_key", as: :bot, defaults: { format: :json } do
-        resources :messages, controller: "messages/by_bots", only: %i[ index create update destroy ] do
-          resources :boosts, controller: "messages/boosts/by_bots", only: %i[ create destroy ]
-        end
-      end
-    end
 
     scope module: "rooms" do
       resource :refresh, only: :show

lib/rails_ext/action_text_allowed_tags.rb

@@ -1,11 +0,0 @@
-# The rich text editor produces formatting that Rails' default Action Text
-# sanitizer strips on render. The additions are declared once in
-# ContentFilters, shared by every sanitization layer.
-Rails.application.config.to_prepare do
-  defaults = Class.new.include(ActionText::ContentHelper).new
-
-  ActionText::ContentHelper.allowed_tags =
-    (ActionText::ContentHelper.allowed_tags || defaults.sanitizer_allowed_tags) | ContentFilters::EDITOR_FORMATTING_TAGS
-  ActionText::ContentHelper.allowed_attributes =
-    (ActionText::ContentHelper.allowed_attributes || defaults.sanitizer_allowed_attributes) | ContentFilters::EDITOR_FORMATTING_ATTRIBUTES
-end

lib/rails_ext/actiontext_opengraph_embeds.rb

@@ -2,7 +2,6 @@ class ActionText::Attachment::OpengraphEmbed
   include ActiveModel::Model
 
   OPENGRAPH_EMBED_CONTENT_TYPE = "application/vnd.actiontext.opengraph-embed"
-  TWITTER_AVATAR_URL_PREFIX = "https://pbs.twimg.com/profile_images"
 
   class << self
     def from_node(node)
@@ -15,85 +14,18 @@ class ActionText::Attachment::OpengraphEmbed
     end
 
     private
-      # Trix serialized the embed's details as attributes of the
-      # <action-text-attachment> node. Lexxy only serializes the sgid, content
-      # and content-type, so newer attachments carry the details in their
-      # content markup instead.
       def attributes_from_node(node)
-        if node["filename"].present?
-          {
-            href: web_url(node["href"]),
-            url: web_url(node["url"]),
-            filename: node["filename"],
-            description: node["caption"]
-          }
-        else
-          attributes_from_content(node["content"].to_s)
-        end
-      end
-
-      def attributes_from_content(content)
-        fragment = Nokogiri::HTML.fragment(content)
-        title = fragment.at_css(".og-embed__title")
-        link = title&.at_css("a")
-
         {
-          href: web_url(link&.[]("href")),
+          href: node["href"],
-          url: web_url(fragment.at_css(".og-embed__image img")&.[]("src")),
+          url: node["url"],
-          filename: (link || title)&.text&.strip,
+          filename: node["filename"],
-          description: fragment.at_css(".og-embed__description")&.text&.strip
+          description: node["caption"]
         }
       end
-
-      # A link preview points at what we unfurled: an absolute http or https URL
-      # on some other host. Drop anything else a message body asks for, so it
-      # can't aim the preview's link or its image at this Campfire and have every
-      # reader's browser fetch it with their session attached.
-      def web_url(value)
-        return if value.blank?
-
-        parsed = URI.parse(value)
-        value if parsed.is_a?(URI::HTTP) && elsewhere?(parsed.host)
-      rescue URI::InvalidURIError
-        nil
-      end
-
-      # "https:/rooms/1" parses as HTTPS with no host at all, and a browser
-      # resolves both that and our own hostname against the origin Campfire is
-      # served from. A percent-escape hides our hostname from this comparison
-      # while a browser still unescapes it back to us, so an escaped host is out
-      # too, and neither case is anything an unfurl could have produced.
-      def elsewhere?(host)
-        return false unless named_host?(host)
-
-        canonical_host(host) != canonical_host(Current.request_host.to_s)
-      end
-
-      # A preview names a page on the public internet, so its host is a domain
-      # name, written plainly. A bare address is not one, and a browser rewrites
-      # the many spellings of an address ("2130706433", "0x7f.0.0.1") into a
-      # single one before it fetches, which is a race a comparison here loses.
-      def named_host?(host)
-        host.present? && host.exclude?("%") && host.include?(".") && domain_ending?(host.split(".").last)
-      end
-
-      # What keeps a name from reading as an address is its last label, which is
-      # a word: never a number, and never the hexadecimal spelling of one.
-      def domain_ending?(label)
-        label.match?(/[a-z]/i) && !label.match?(/\A0x/i)
-      end
-
-      def canonical_host(host)
-        host.downcase.delete_suffix(".")
-      end
   end
 
   attr_accessor :href, :url, :filename, :description
 
-  def twitter_avatar?
-    url.to_s.start_with?(TWITTER_AVATAR_URL_PREFIX)
-  end
-
   def attachable_content_type
     OPENGRAPH_EMBED_CONTENT_TYPE
   end
@@ -105,4 +37,8 @@ class ActionText::Attachment::OpengraphEmbed
   def to_partial_path
     "action_text/attachables/opengraph_embed"
   end
+
+  def to_trix_content_attachment_partial_path
+    "action_text/attachables/opengraph_embed"
+  end
 end

lib/rails_ext/log_scrubbing_formatter.rb

@@ -1,16 +0,0 @@
-# Bot requests carry the bot key as a URL path segment (/rooms/:room_id/:bot_key/...).
-# config.filter_parameters redacts query and form parameters but never path segments,
-# so the key would otherwise be written verbatim to the request log. Redact it wherever
-# it appears in a formatted log line.
-class LogScrubbingFormatter < ::Logger::Formatter
-  BOT_KEY_IN_PATH = %r{(/rooms/\d+/)\d+-[A-Za-z0-9]+}
-
-  def call(severity, time, progname, message)
-    scrub(super)
-  end
-
-  private
-    def scrub(line)
-      line.gsub(BOT_KEY_IN_PATH, '\1[FILTERED]')
-    end
-end

lib/restricted_http/private_network_guard.rb

@@ -1,29 +1,76 @@
-require "surfguard"
+require "ipaddr"
+require "resolv"
 
 module RestrictedHTTP
   class Violation < StandardError; end
 
-  # The address policy lives in the surfguard gem so this app, Basecamp, HEY and
-  # Fizzy classify "internal" the same way instead of each keeping a copy that
-  # drifts. The callers here hand a bare hostname in and pin the address that
-  # comes back, so this stays a hostname-in, address-out shim.
   module PrivateNetworkGuard
     extend self
 
-    # A hostname that resolves to nothing (NXDOMAIN, timeout, empty answer)
+    # IPv4 special-use ranges (RFC 5735/6890) not already covered by the
-    # raises Surfguard::Unresolvable, which we let propagate as a lookup failure
+    # private?/loopback?/link_local? predicates in #disallowed_ipv4?.
-    # -- the same way the old Resolv.getaddress guard raised Resolv::ResolvError,
+    DISALLOWED_IPV4 = %w[
-    # and the callers here already treat it as a fetch failure. The Violation is
+      0.0.0.0/8 100.64.0.0/10 192.0.0.0/24 192.0.2.0/24 192.88.99.0/24
-    # reserved for a host that resolves to a blocked address (an empty list back
+      198.18.0.0/15 198.51.100.0/24 203.0.113.0/24 224.0.0.0/4 240.0.0.0/4
-    # from resolve_public_ips), so a transient DNS miss is never misreported as
+    ].map { |cidr| IPAddr.new(cidr) }.freeze
-    # an SSRF attempt.
+
+    # IPv6 special-use ranges not caught by the predicates. 6to4 (2002::/16) and
+    # Teredo (2001::/32) are deprecated transition mechanisms with no legitimate
+    # fetch target, so they are blocked outright. ULA (fc00::/7, incl. the AWS
+    # IMDSv6 address fd00:ec2::254), link-local, and loopback are covered by the
+    # predicates in #disallowed_ipv6?.
+    DISALLOWED_IPV6 = %w[
+      ::/128 100::/64 2001::/32 2001:2::/48 2001:db8::/32 2002::/16
+      fec0::/10 ff00::/8
+    ].map { |cidr| IPAddr.new(cidr) }.freeze
+
+    # NAT64 prefixes: the well-known prefix (RFC 6052/6146) and the local-use
+    # prefix (RFC 8215). An address here embeds an IPv4 target in its low 32
+    # bits; we extract it and re-check against the IPv4 rules so NAT64 to a
+    # public address still resolves while NAT64 to an internal address is
+    # blocked.
+    NAT64_PREFIXES = [
+      IPAddr.new("64:ff9b::/96"),
+      IPAddr.new("64:ff9b:1::/48")
+    ].freeze
+
     def resolve(hostname)
-      Surfguard.resolve_public_ips(hostname).first or
+      Resolv.getaddress(hostname).tap do |ip|
-        raise Violation.new("Attempt to access private IP via #{hostname}")
+        raise Violation.new("Attempt to access private IP via #{hostname}") if ip && private_ip?(ip)
+      end
     end
 
     def private_ip?(ip)
-      Surfguard.blocked_address?(ip)
+      ipaddr = IPAddr.new(ip)
+
+      # DNS never legitimately returns these embedded forms, so block them all
+      # regardless of the address they wrap.
+      if ipaddr.ipv4_mapped? || ipaddr.ipv4_compat?
+        true
+      elsif ipaddr.ipv4?
+        disallowed_ipv4?(ipaddr)
+      elsif NAT64_PREFIXES.any? { |prefix| prefix.include?(ipaddr) }
+        disallowed_ipv4?(embedded_ipv4(ipaddr))
+      else
+        disallowed_ipv6?(ipaddr)
+      end
+    rescue IPAddr::InvalidAddressError
+      true
     end
+
+    private
+      def disallowed_ipv4?(ipaddr)
+        ipaddr.private? || ipaddr.loopback? || ipaddr.link_local? ||
+          DISALLOWED_IPV4.any? { |range| range.include?(ipaddr) }
+      end
+
+      def disallowed_ipv6?(ipaddr)
+        ipaddr.private? || ipaddr.loopback? || ipaddr.link_local? ||
+          DISALLOWED_IPV6.any? { |range| range.include?(ipaddr) }
+      end
+
+      def embedded_ipv4(ipaddr)
+        IPAddr.new([ ipaddr.to_i & 0xffffffff ].pack("N").unpack("C4").join("."))
+      end
   end
 end

lib/web_push/notification.rb

@@ -1,18 +1,16 @@
 class WebPush::Notification
-  def initialize(title:, body:, path:, badge:, endpoint:, endpoint_ip_resolver:, p256dh_key:, auth_key:)
+  def initialize(title:, body:, path:, badge:, endpoint:, p256dh_key:, auth_key:)
     @title, @body, @path, @badge = title, body, path, badge
-    @endpoint, @endpoint_ip_resolver, @p256dh_key, @auth_key = endpoint, endpoint_ip_resolver, p256dh_key, auth_key
+    @endpoint, @p256dh_key, @auth_key = endpoint, p256dh_key, auth_key
   end
 
   def deliver(connection: nil)
-    if endpoint_ip = @endpoint_ip_resolver.call
+    WebPush.payload_send \
-      WebPush.payload_send \
+      message: encoded_message,
-        message: encoded_message,
+      endpoint: @endpoint, p256dh: @p256dh_key, auth: @auth_key,
-        endpoint: @endpoint, endpoint_ip: endpoint_ip, p256dh: @p256dh_key, auth: @auth_key,
+      vapid: vapid_identification,
-        vapid: vapid_identification,
+      connection: connection,
-        connection: connection,
+      urgency: "high"
-        urgency: "high"
-    end
   end
 
   private

lib/web_push/pool.rb

@@ -3,7 +3,7 @@ class WebPush::Pool
   attr_reader :delivery_pool, :invalidation_pool, :connection, :invalid_subscription_handler
 
   def initialize(invalid_subscription_handler:)
-    @delivery_pool = Concurrent::ThreadPoolExecutor.new(max_threads: 50, max_queue: 10000)
+    @delivery_pool = Concurrent::ThreadPoolExecutor.new(max_threads: 50, queue_size: 10000)
     @invalidation_pool = Concurrent::FixedThreadPool.new(1)
     @connection = Net::HTTP::Persistent.new(name: "web_push", pool_size: 150)
     @invalid_subscription_handler = invalid_subscription_handler

test/application_system_test_case.rb

@@ -6,5 +6,4 @@ class ApplicationSystemTestCase < ActionDispatch::SystemTestCase
   driven_by :selenium, using: :headless_chrome, screen_size: [ 1400, 1400 ]
 
   include SystemTestHelper
-  include RichTextEditorHelper
 end

test/channels/room_messages_channel_test.rb

@@ -1,86 +0,0 @@
-require "test_helper"
-
-class RoomMessagesChannelTest < ActionCable::Channel::TestCase
-  tests RoomMessagesChannel
-
-  setup do
-    @room = rooms(:designers)
-    @signed_stream_name = Turbo::StreamsChannel.signed_stream_name [ @room, :messages ]
-  end
-
-  test "a member may subscribe to a room's message stream" do
-    stub_connection(current_user: users(:kevin))
-
-    subscribe signed_stream_name: @signed_stream_name
-
-    assert subscription.confirmed?
-    assert_has_stream Turbo.signed_stream_verifier.verified(@signed_stream_name)
-  end
-
-  test "a user who was never a member may not subscribe" do
-    stub_connection(current_user: users(:bender))
-
-    subscribe signed_stream_name: @signed_stream_name
-
-    assert subscription.rejected?
-  end
-
-  test "a revoked member may not re-subscribe with a stream name harvested while a member" do
-    stub_connection(current_user: users(:kevin))
-
-    subscribe signed_stream_name: @signed_stream_name
-    assert subscription.confirmed?, "kevin must start out able to subscribe"
-
-    @room.memberships.revoke_from users(:kevin)
-
-    subscribe signed_stream_name: @signed_stream_name
-
-    assert subscription.rejected?
-  end
-
-  test "an unsigned stream name is rejected" do
-    stub_connection(current_user: users(:kevin))
-
-    subscribe signed_stream_name: Turbo.signed_stream_verifier.verified(@signed_stream_name)
-
-    assert subscription.rejected?
-  end
-
-  test "a missing stream name is rejected" do
-    stub_connection(current_user: users(:kevin))
-
-    subscribe
-
-    assert subscription.rejected?
-  end
-
-  test "a validly signed stream name for another room the user isn't in is rejected" do
-    stub_connection(current_user: users(:bender))
-
-    subscribe signed_stream_name: Turbo::StreamsChannel.signed_stream_name([ rooms(:hq), :messages ])
-
-    assert subscription.rejected?
-  end
-end
-
-class RoomMessagesViaStockTurboChannelTest < ActionCable::Channel::TestCase
-  tests Turbo::StreamsChannel
-
-  # The subscriber picks the channel, so the stock channel has to turn these names away
-  # too. Otherwise a revoked member just names Turbo::StreamsChannel instead.
-  test "the stock turbo channel refuses to serve a room message stream" do
-    stub_connection(current_user: users(:kevin))
-
-    subscribe signed_stream_name: Turbo::StreamsChannel.signed_stream_name([ rooms(:designers), :messages ])
-
-    assert subscription.rejected?
-  end
-
-  test "the stock turbo channel still serves the room list stream" do
-    stub_connection(current_user: users(:kevin))
-
-    subscribe signed_stream_name: Turbo::StreamsChannel.signed_stream_name([ :rooms ])
-
-    assert subscription.confirmed?
-  end
-end

test/channels/unread_rooms_channel_test.rb

@@ -1,47 +0,0 @@
-require "test_helper"
-
-class UnreadRoomsChannelTest < ActionCable::Channel::TestCase
-  test "streams only the subscriber's own unread stream" do
-    stub_connection(current_user: users(:jz))
-
-    subscribe
-
-    assert subscription.confirmed?
-    assert_has_stream "user_#{users(:jz).id}_unreads"
-    assert_not_includes subscription.streams, "unread_rooms"
-  end
-
-  test "an outsider is not told about activity in a room they can't see" do
-    direct = rooms(:bender_and_kevin)
-    assert_not direct.users.include?(users(:jz)), "jz must be an outsider for this test to mean anything"
-
-    broadcasts = capture_unread_broadcasts_for(users(:jz)) do
-      direct.messages.create!(body: "Private", creator: users(:kevin), client_message_id: "outsider").broadcast_create
-    end
-
-    assert_empty broadcasts
-  end
-
-  test "a member is told about activity in their own room" do
-    direct = rooms(:bender_and_kevin)
-
-    broadcasts = capture_unread_broadcasts_for(users(:kevin)) do
-      direct.messages.create!(body: "Private", creator: users(:bender), client_message_id: "member").broadcast_create
-    end
-
-    assert_equal [ direct.id ], broadcasts.collect { |broadcast| broadcast["roomId"] }
-  end
-
-  private
-    def capture_unread_broadcasts_for(user)
-      stub_connection(current_user: user)
-      subscribe
-
-      stream = subscription.streams.sole
-      before = ActionCable.server.pubsub.broadcasts(stream).size
-
-      yield
-
-      ActionCable.server.pubsub.broadcasts(stream).drop(before).collect { |broadcast| JSON.parse(broadcast) }
-    end
-end

test/controllers/active_storage_authentication_test.rb

@@ -1,73 +0,0 @@
-require "test_helper"
-
-class ActiveStorageAuthenticationTest < ActionDispatch::IntegrationTest
-  setup do
-    host! "once.campfire.test"
-  end
-
-  test "direct upload metadata endpoint rejects anonymous callers" do
-    get new_session_url
-    assert_response :success
-
-    assert_no_difference -> { ActiveStorage::Blob.count } do
-      post rails_direct_uploads_url, params: blob_params, as: :json
-    end
-
-    assert_response :unauthorized
-  end
-
-  test "direct upload metadata endpoint allows authenticated users" do
-    sign_in :david
-
-    assert_difference -> { ActiveStorage::Blob.count }, 1 do
-      post rails_direct_uploads_url, params: blob_params, as: :json
-    end
-
-    assert_response :success
-  end
-
-  test "disk service upload endpoint rejects anonymous callers" do
-    sign_in :david
-    post rails_direct_uploads_url, params: blob_params, as: :json
-    assert_response :success
-    upload_path = URI.parse(response.parsed_body.dig("direct_upload", "url")).request_uri
-
-    anonymous = open_session
-    anonymous.host! "once.campfire.test"
-    anonymous.put upload_path,
-      params: attachment_bytes,
-      headers: { "Content-Type" => "application/octet-stream" }
-
-    assert_equal 401, anonymous.status
-  end
-
-  test "disk service download endpoint stays public" do
-    ActiveStorage::Current.url_options = { host: "once.campfire.test", protocol: "https" }
-    blob = ActiveStorage::Blob.create_and_upload! \
-      io: StringIO.new(attachment_bytes), filename: "hi.txt", content_type: "text/plain"
-    download_path = URI.parse(blob.url).request_uri
-
-    anonymous = open_session
-    anonymous.host! "once.campfire.test"
-    anonymous.get download_path
-
-    assert_equal 200, anonymous.status
-    assert_equal attachment_bytes, anonymous.response.body
-  ensure
-    blob&.purge
-  end
-
-  private
-    def attachment_bytes
-      "hello!"
-    end
-
-    def blob_params
-      { blob: {
-        filename: "quota.bin",
-        byte_size: attachment_bytes.bytesize,
-        checksum: Digest::MD5.base64digest(attachment_bytes),
-        content_type: "application/octet-stream"
-      } }
-    end
-end

test/controllers/messages/boosts/by_bots_controller_test.rb

@@ -1,112 +0,0 @@
-require "test_helper"
-
-class Messages::Boosts::ByBotsControllerTest < ActionDispatch::IntegrationTest
-  setup do
-    @room = rooms(:watercooler)
-    @message = messages(:fourth)
-    @bot = users(:bender)
-  end
-
-  test "create adds a boost to the message and returns it" do
-    assert_difference -> { @message.boosts.count }, +1 do
-      post room_bot_message_boosts_url(@room, @bot.bot_key, @message), params: +"👀"
-      assert_response :created
-    end
-
-    boost = @message.boosts.last
-    assert_equal "👀", boost.content
-    assert_equal @bot, boost.booster
-
-    json = JSON.parse(response.body)
-    assert_equal boost.id, json["id"]
-    assert_equal "👀", json["content"]
-    assert_equal @bot.id, json["booster"]["id"]
-    assert_equal @message.id, json["message"]["id"]
-    assert_equal room_message_url(@room, @message), json["message"]["url"]
-  end
-
-  test "create with text content" do
-    assert_difference -> { Boost.count }, +1 do
-      post room_bot_message_boosts_url(@room, @bot.bot_key, @message), params: +"Nice!"
-      assert_response :created
-    end
-
-    assert_equal "Nice!", @message.boosts.last.content
-  end
-
-  test "create broadcasts the boost" do
-    assert_turbo_stream_broadcasts [ @message.room, :messages ], count: 1 do
-      post room_bot_message_boosts_url(@room, @bot.bot_key, @message), params: +"👍"
-    end
-  end
-
-  test "create without content" do
-    assert_no_difference -> { Boost.count } do
-      post room_bot_message_boosts_url(@room, @bot.bot_key, @message)
-      assert_response :unprocessable_content
-
-      post room_bot_message_boosts_url(@room, @bot.bot_key, @message), params: +"   "
-      assert_response :unprocessable_content
-    end
-  end
-
-  test "create requires a valid bot key" do
-    assert_no_difference -> { Boost.count } do
-      post room_bot_message_boosts_url(@room, "invalid-bot-key", @message), params: +"👀"
-    end
-    assert_response :redirect
-  end
-
-  test "create is not found for a room the bot is not a member of" do
-    assert_no_difference -> { Boost.count } do
-      post room_bot_message_boosts_url(rooms(:designers), @bot.bot_key, messages(:first)), params: +"👀"
-    end
-    assert_response :not_found
-  end
-
-  test "create is not found for a message outside the room" do
-    assert_no_difference -> { Boost.count } do
-      post room_bot_message_boosts_url(@room, @bot.bot_key, messages(:first)), params: +"👀"
-    end
-    assert_response :not_found
-  end
-
-  test "create can't be abused to post boosts as a regular user" do
-    bot_key = "#{users(:kevin).id}-"
-
-    assert_no_difference -> { Boost.count } do
-      post room_bot_message_boosts_url(@room, bot_key, @message), params: +"👀"
-    end
-    assert_response :redirect
-  end
-
-  test "destroy removes the bot's own boost" do
-    assert_difference -> { Boost.count }, -1 do
-      delete room_bot_message_boost_url(@room, @bot.bot_key, @message, boosts(:fourth_by_bender))
-    end
-
-    assert_response :no_content
-  end
-
-  test "destroy broadcasts the removal" do
-    assert_turbo_stream_broadcasts [ @message.room, :messages ], count: 1 do
-      delete room_bot_message_boost_url(@room, @bot.bot_key, @message, boosts(:fourth_by_bender))
-    end
-  end
-
-  test "destroy can't touch a boost the bot did not make" do
-    assert_no_difference -> { Boost.count } do
-      delete room_bot_message_boost_url(@room, @bot.bot_key, messages(:thirteenth), boosts(:thirteenth))
-    end
-
-    assert_response :not_found
-  end
-
-  test "destroy requires a valid bot key" do
-    assert_no_difference -> { Boost.count } do
-      delete room_bot_message_boost_url(@room, "invalid-bot-key", @message, boosts(:fourth_by_bender))
-    end
-
-    assert_response :redirect
-  end
-end

test/controllers/messages/by_bots_controller_test.rb

@@ -1,6 +1,6 @@
 require "test_helper"
 
-class Messages::ByBotsControllerTest < ActionDispatch::IntegrationTest
+class Messages::ByBotsControlleTest < ActionDispatch::IntegrationTest
   setup do
     @room = rooms(:watercooler)
   end
@@ -40,16 +40,6 @@ class Messages::ByBotsControllerTest < ActionDispatch::IntegrationTest
     end
   end
 
-  test "create without a body or attachment" do
-    assert_no_difference -> { Message.count } do
-      post room_bot_messages_url(@room, users(:bender).bot_key)
-      assert_response :unprocessable_content
-
-      post room_bot_messages_url(@room, users(:bender).bot_key), params: +"   "
-      assert_response :unprocessable_content
-    end
-  end
-
   test "create can't be abused to post messages as any user" do
     user = users(:kevin)
     bot_key = "#{user.id}-"
@@ -61,175 +51,8 @@ class Messages::ByBotsControllerTest < ActionDispatch::IntegrationTest
     assert_response :redirect
   end
 
-  test "index returns the room's messages in the order they were sent" do
+  test "denied index" do
-    get room_bot_messages_url(@room, users(:bender).bot_key)
+    get room_messages_url(@room, bot_key: users(:bender).bot_key, format: :json)
-    assert_response :success
-
-    json = JSON.parse(response.body)
-    assert_equal @room.messages.ordered.map(&:id), json.map { it["id"] }
-  end
-
-  test "index includes message details" do
-    post room_bot_messages_url(@room, users(:bender).bot_key), params: +"Hello from Bender!"
-
-    get room_bot_messages_url(@room, users(:bender).bot_key)
-    assert_response :success
-
-    message = Message.last
-    json_message = JSON.parse(response.body).last
-    assert_equal message.id, json_message["id"]
-    assert_equal "Hello from Bender!", json_message["body"]["plain_text"]
-    assert_includes json_message["body"]["html"], "Hello from Bender!"
-    assert_equal message.created_at.utc.iso8601(3), json_message["created_at"]
-    assert_equal users(:bender).id, json_message["creator"]["id"]
-    assert_equal "Bender Bot", json_message["creator"]["name"]
-    assert_equal "bot", json_message["creator"]["role"]
-    assert_equal @room.id, json_message["room"]["id"]
-    assert_equal room_message_url(@room, message), json_message["url"]
-  end
-
-  test "index pages through older messages with the Link header" do
-    (Message::PAGE_SIZE - @room.messages.count + 1).times do |i|
-      @room.messages.create!(body: "Filler #{i}", creator: users(:jason), client_message_id: "filler-#{i}")
-    end
-
-    get room_bot_messages_url(@room, users(:bender).bot_key)
-    assert_response :success
-
-    json = JSON.parse(response.body)
-    assert_equal Message::PAGE_SIZE, json.size
-    assert_equal "41", response.headers["X-Total-Count"]
-    assert_not_includes json.map { it["id"] }, messages(:fourth).id
-
-    get response.headers["Link"][/<(.*)>/, 1]
-    assert_response :success
-
-    json = JSON.parse(response.body)
-    assert_equal [ messages(:fourth).id ], json.map { it["id"] }
-    assert_nil response.headers["Link"]
-  end
-
-  test "index pages newer messages with after" do
-    get room_bot_messages_url(@room, users(:bender).bot_key, after: messages(:tenth).id)
-    assert_response :success
-
-    json = JSON.parse(response.body)
-    assert_equal %i[ eleventh twelfth thirteenth ].map { messages(it).id }, json.map { it["id"] }
-    assert_nil response.headers["Link"]
-  end
-
-  test "index in a room with no messages" do
-    get room_bot_messages_url(rooms(:bender_and_kevin), users(:bender).bot_key)
-    assert_response :success
-
-    assert_equal [], JSON.parse(response.body)
-    assert_equal "0", response.headers["X-Total-Count"]
-    assert_nil response.headers["Link"]
-  end
-
-  test "index requires a valid bot key" do
-    get room_bot_messages_url(@room, "invalid-bot-key")
-    assert_response :redirect
-  end
-
-  test "index is not found for a room the bot is not a member of" do
-    get room_bot_messages_url(rooms(:designers), users(:bender).bot_key)
-    assert_response :not_found
-  end
-
-  test "create is not found for a room the bot is not a member of" do
-    assert_no_difference -> { Message.count } do
-      post room_bot_messages_url(rooms(:designers), users(:bender).bot_key), params: +"Hello!"
-    end
-    assert_response :not_found
-  end
-
-  test "regular messages index remains denied for bots" do
-    get room_messages_url(@room, bot_key: users(:bender).bot_key)
     assert_response :forbidden
   end
-
-  test "update" do
-    message = post_bot_message "Deploying..."
-
-    assert_no_difference -> { Message.count } do
-      patch room_bot_message_url(@room, users(:bender).bot_key, message), params: +"Deployed."
-    end
-
-    assert_response :ok
-    assert_equal "Deployed.", message.reload.plain_text_body
-
-    json = JSON.parse(response.body)
-    assert_equal message.id, json["id"]
-    assert_equal "Deployed.", json["body"]["plain_text"]
-    assert_equal users(:bender).id, json["creator"]["id"]
-    assert_equal room_message_url(@room, message), json["url"]
-  end
-
-  test "update with UTF-8 content" do
-    message = post_bot_message "Deploying..."
-
-    patch room_bot_message_url(@room, users(:bender).bot_key, message), params: +"Deployed 🚀!"
-
-    assert_response :ok
-    assert_equal "Deployed 🚀!", message.reload.plain_text_body
-    assert_equal "Deployed 🚀!", JSON.parse(response.body)["body"]["plain_text"]
-  end
-
-  test "update can't touch a message the bot did not create" do
-    message = messages(:fourth)
-    original = message.plain_text_body
-
-    patch room_bot_message_url(@room, users(:bender).bot_key, message), params: +"Hijacked!"
-
-    assert_response :forbidden
-    assert_equal original, message.reload.plain_text_body
-  end
-
-  test "update is not found for a room the bot is not a member of" do
-    message = messages(:first)
-    original = message.plain_text_body
-
-    patch room_bot_message_url(rooms(:designers), users(:bender).bot_key, message), params: +"Hijacked!"
-
-    assert_response :not_found
-    assert_equal original, message.reload.plain_text_body
-  end
-
-  test "update can't be abused to edit messages as any user" do
-    message = messages(:fourth)
-    bot_key = "#{users(:jz).id}-"
-    original = message.plain_text_body
-
-    patch room_bot_message_url(@room, bot_key, message), params: +"Hijacked!"
-
-    assert_response :redirect
-    assert_equal original, message.reload.plain_text_body
-  end
-
-  test "destroy" do
-    message = post_bot_message "Deploying..."
-
-    assert_difference -> { Message.count }, -1 do
-      delete room_bot_message_url(@room, users(:bender).bot_key, message)
-    end
-
-    assert_response :no_content
-  end
-
-  test "destroy can't touch a message the bot did not create" do
-    message = messages(:fourth)
-
-    assert_no_difference -> { Message.count } do
-      delete room_bot_message_url(@room, users(:bender).bot_key, message)
-    end
-
-    assert_response :forbidden
-  end
-
-  private
-    def post_bot_message(body)
-      post room_bot_messages_url(@room, users(:bender).bot_key), params: +body
-      Message.last
-    end
 end

test/controllers/messages_controller_test.rb

@@ -57,22 +57,9 @@ class MessagesControllerTest < ActionDispatch::IntegrationTest
     end
   end
 
-  test "creating a message broadcasts unread room to each member" do
+  test "creating a message broadcasts unread room" do
-    @room.users.each do |member|
+    assert_broadcasts "unread_rooms", 1 do
-      assert_broadcasts UnreadRoomsChannel.stream_name_for(member.id), 1 do
+      post room_messages_url(@room, format: :turbo_stream), params: { message: { body: "New one", client_message_id: 999 } }
-        post room_messages_url(@room, format: :turbo_stream), params: { message: { body: "New one #{member.id}", client_message_id: member.id } }
-      end
-    end
-  end
-
-  test "creating a message doesn't broadcast unread room to non-members" do
-    outsiders = User.where.not(id: @room.users.map(&:id))
-    assert outsiders.any?, "need someone outside the room for this test to mean anything"
-
-    outsiders.each do |outsider|
-      assert_no_broadcasts UnreadRoomsChannel.stream_name_for(outsider.id) do
-        post room_messages_url(@room, format: :turbo_stream), params: { message: { body: "New one", client_message_id: 999 } }
-      end
     end
   end
 

test/controllers/rooms/closeds_controller_test.rb

@@ -66,18 +66,6 @@ class Rooms::ClosedsControllerTest < ActionDispatch::IntegrationTest
     assert rooms(:designers).reload.name, "Designers"
   end
 
-  test "a direct room can't be converted to closed and have its participants revised" do
-    sign_in :kevin
-    direct = rooms(:bender_and_kevin)
-
-    put rooms_closed_url(direct), params: {
-      room: { name: "Watercooler" }, user_ids: [ users(:kevin).id, users(:jz).id ]
-    }
-
-    assert_equal "Rooms::Direct", Room.find(direct.id).type
-    assert_equal [ users(:bender).id, users(:kevin).id ].sort, Room.find(direct.id).user_ids.sort
-  end
-
   test "remove yourself" do
     assert_difference -> { users(:david).rooms.count }, -1 do
       put rooms_closed_url(rooms(:designers), params: { room: { name: "Designers" }, user_ids: [ users(:jason).id, users(:jz).id ] })

test/controllers/rooms/directs_controller_test.rb

@@ -29,34 +29,4 @@ class Rooms::DirectsControllerTest < ActionDispatch::IntegrationTest
       assert_redirected_to root_url
     end
   end
-
-  test "destroy can't reach a closed room the member didn't create" do
-    sign_in :kevin
-
-    assert_no_difference -> { Room.count } do
-      delete rooms_direct_url(rooms(:designers))
-    end
-
-    assert rooms(:designers).reload.persisted?
-  end
-
-  test "destroy can't reach an open room the member didn't create" do
-    sign_in :kevin
-
-    assert_no_difference -> { Room.count } do
-      delete rooms_direct_url(rooms(:hq))
-    end
-
-    assert rooms(:hq).reload.persisted?
-  end
-
-  test "destroy can't reach a room the member isn't in at all" do
-    sign_in :jz
-
-    assert_no_difference -> { Room.count } do
-      delete rooms_direct_url(rooms(:david_and_kevin))
-    end
-
-    assert rooms(:david_and_kevin).reload.persisted?
-  end
 end

test/controllers/rooms/opens_controller_test.rb

@@ -57,23 +57,4 @@ class Rooms::OpensControllerTest < ActionDispatch::IntegrationTest
     put rooms_open_url(rooms(:designers)), params: { room: { name: "Doesn't matter" } }
     assert_equal rooms(:designers).memberships.count, User.count
   end
-
-  test "a direct room can't be promoted to open by its creator" do
-    sign_in :kevin
-    direct = rooms(:bender_and_kevin)
-
-    put rooms_open_url(direct), params: { room: { name: "Watercooler" } }
-
-    assert_equal "Rooms::Direct", Room.find(direct.id).type
-    assert_equal [ users(:bender).id, users(:kevin).id ].sort, Room.find(direct.id).user_ids.sort
-  end
-
-  test "a direct room can't be promoted to open by an administrator either" do
-    direct = rooms(:david_and_kevin)
-
-    put rooms_open_url(direct), params: { room: { name: "Watercooler" } }
-
-    assert_equal "Rooms::Direct", Room.find(direct.id).type
-    assert_equal [ users(:david).id, users(:kevin).id ].sort, Room.find(direct.id).user_ids.sort
-  end
 end