mirror of
https://github.com/basecamp/once-campfire.git
synced 2026-10-27 16:06:48 +09:00
Jeremy Daer
19319a1cff
A password change ends every session, but a sign-in or sign-in link checked against the old password just before the change could still save its session just after, and that session outlived the change. The session now checks, as it's saved, that the user's password is still the one the request loaded. The save's transaction holds SQLite's write lock from the start, so a change commits either before the check, which fails it, or after the insert, and ends this session with the others. Sessions start through the user's association so the check sees the user that was authenticated, and a refused sign-in is answered like a wrong password.
29 lines
989 B
Ruby
29 lines
989 B
Ruby
class Session < ApplicationRecord
|
|
ACTIVITY_REFRESH_RATE = 1.hour
|
|
|
|
has_secure_token
|
|
|
|
belongs_to :user
|
|
|
|
before_create { self.last_active_at ||= Time.now }
|
|
|
|
validate :user_password_unchanged, on: :create
|
|
|
|
def resume(user_agent:, ip_address:)
|
|
if last_active_at.before?(ACTIVITY_REFRESH_RATE.ago)
|
|
update! user_agent: user_agent, ip_address: ip_address, last_active_at: Time.now
|
|
end
|
|
end
|
|
|
|
private
|
|
# A password change ends every session, so one can't start on a password checked before the change. Validated in
|
|
# the save's transaction, which holds the database's write lock from the start, so a change commits either before
|
|
# this check, and fails it, or after the insert, and ends this session with the others. Compared here rather than in
|
|
# the query, which logs its values.
|
|
def user_password_unchanged
|
|
unless User.where(id: user_id).pick(:password_digest) == user.password_digest
|
|
errors.add :user, :invalid
|
|
end
|
|
end
|
|
end
|