mirror of
https://github.com/basecamp/once-campfire.git
synced 2026-10-09 00:00:12 +09:00
506c2771fe
Now that the unread fanout runs in a job, it can run after a member has already opened the room and moved on to another one. Their sidebar would then mark the room unread for a message they have seen. The job now notifies only members who still have the room unread or are in it now. Room#receive marks members who aren't in the room unread, and opening the room clears it, so a member who caught up in the meantime is skipped. When the job runs right away this is the same set of people as before, except members who have hidden the room, whose sidebar doesn't list it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JVFo3Lt9T8M5NR7KxVvsZ2
196 lines
6.7 KiB
Ruby
196 lines
6.7 KiB
Ruby
require "test_helper"
|
|
|
|
class MessagesControllerTest < ActionDispatch::IntegrationTest
|
|
setup do
|
|
host! "once.campfire.test"
|
|
|
|
sign_in :david
|
|
@room = rooms(:watercooler)
|
|
@messages = @room.messages.ordered.to_a
|
|
end
|
|
|
|
test "index returns the last page by default" do
|
|
get room_messages_url(@room)
|
|
|
|
assert_response :success
|
|
ensure_messages_present @messages.last
|
|
end
|
|
|
|
test "index returns a page before the specified message" do
|
|
get room_messages_url(@room, before: @messages.third)
|
|
|
|
assert_response :success
|
|
ensure_messages_present @messages.first, @messages.second
|
|
ensure_messages_not_present @messages.third, @messages.fourth, @messages.fifth
|
|
end
|
|
|
|
test "index returns a page after the specified message" do
|
|
get room_messages_url(@room, after: @messages.third)
|
|
|
|
assert_response :success
|
|
ensure_messages_present @messages.fourth, @messages.fifth
|
|
ensure_messages_not_present @messages.first, @messages.second, @messages.third
|
|
end
|
|
|
|
test "index returns no_content when there are no messages" do
|
|
@room.messages.destroy_all
|
|
|
|
get room_messages_url(@room)
|
|
|
|
assert_response :no_content
|
|
end
|
|
|
|
test "get renders a single message belonging to the user" do
|
|
message = @room.messages.where(creator: users(:david)).first
|
|
|
|
get room_message_url(@room, message)
|
|
|
|
assert_response :success
|
|
end
|
|
|
|
test "creating a message broadcasts the message to the room" do
|
|
post room_messages_url(@room, format: :turbo_stream), params: { message: { body: "New one", client_message_id: 999 } }
|
|
|
|
assert_rendered_turbo_stream_broadcast @room, :messages, action: "append", target: [ @room, :messages ] do
|
|
assert_select ".message__body", text: /New one/
|
|
assert_copy_link_button room_at_message_url(@room, Message.last, host: "once.campfire.test")
|
|
end
|
|
end
|
|
|
|
test "creating a message broadcasts unread room to each member" do
|
|
memberships(:david_watercooler).present # the poster is in the room
|
|
|
|
@room.users.each do |member|
|
|
assert_broadcasts UnreadRoomsChannel.stream_name_for(member.id), 1 do
|
|
perform_enqueued_jobs only: Message::BroadcastUnreadRoomJob do
|
|
post room_messages_url(@room, format: :turbo_stream), params: { message: { body: "New one #{member.id}", client_message_id: member.id } }
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
test "creating a message leaves the unread fanout to a job" do
|
|
member = @room.users.excluding(users(:david)).first
|
|
|
|
assert_no_broadcasts UnreadRoomsChannel.stream_name_for(member.id) do
|
|
post room_messages_url(@room, format: :turbo_stream), params: { message: { body: "New one", client_message_id: 999 } }
|
|
end
|
|
|
|
assert_enqueued_with job: Message::BroadcastUnreadRoomJob, args: [ Message.last ]
|
|
end
|
|
|
|
test "the unread fanout skips a member who has opened the room since" do
|
|
membership = memberships(:jason_watercooler)
|
|
|
|
post room_messages_url(@room, format: :turbo_stream), params: { message: { body: "New one", client_message_id: 999 } }
|
|
assert membership.reload.unread?
|
|
|
|
membership.present
|
|
membership.reload.disconnected
|
|
|
|
assert_no_broadcasts UnreadRoomsChannel.stream_name_for(membership.user_id) do
|
|
perform_enqueued_jobs only: Message::BroadcastUnreadRoomJob
|
|
end
|
|
end
|
|
|
|
test "creating a message doesn't broadcast unread room to non-members" do
|
|
outsiders = User.where.not(id: @room.users.map(&:id))
|
|
assert outsiders.any?, "need someone outside the room for this test to mean anything"
|
|
|
|
outsiders.each do |outsider|
|
|
assert_no_broadcasts UnreadRoomsChannel.stream_name_for(outsider.id) do
|
|
perform_enqueued_jobs only: Message::BroadcastUnreadRoomJob do
|
|
post room_messages_url(@room, format: :turbo_stream), params: { message: { body: "New one", client_message_id: 999 } }
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
test "update updates a message belonging to the user" do
|
|
message = @room.messages.where(creator: users(:david)).first
|
|
|
|
Turbo::StreamsChannel.expects(:broadcast_replace_to).once
|
|
put room_message_url(@room, message), params: { message: { body: "Updated body" } }
|
|
|
|
assert_redirected_to room_message_url(@room, message)
|
|
assert_equal "Updated body", message.reload.plain_text_body
|
|
end
|
|
|
|
test "admin updates a message belonging to another user" do
|
|
message = @room.messages.where(creator: users(:jason)).first
|
|
|
|
Turbo::StreamsChannel.expects(:broadcast_replace_to).once
|
|
put room_message_url(@room, message), params: { message: { body: "Updated body" } }
|
|
|
|
assert_redirected_to room_message_url(@room, message)
|
|
assert_equal "Updated body", message.reload.plain_text_body
|
|
end
|
|
|
|
test "destroy destroys a message belonging to the user" do
|
|
message = @room.messages.where(creator: users(:david)).first
|
|
|
|
assert_difference -> { Message.count }, -1 do
|
|
Turbo::StreamsChannel.expects(:broadcast_remove_to).once
|
|
delete room_message_url(@room, message, format: :turbo_stream)
|
|
assert_response :success
|
|
end
|
|
end
|
|
|
|
test "admin destroy destroys a message belonging to another user" do
|
|
assert users(:david).administrator?
|
|
message = @room.messages.where(creator: users(:jason)).first
|
|
|
|
assert_difference -> { Message.count }, -1 do
|
|
Turbo::StreamsChannel.expects(:broadcast_remove_to).once
|
|
delete room_message_url(@room, message, format: :turbo_stream)
|
|
assert_response :success
|
|
end
|
|
end
|
|
|
|
test "ensure non-admin can't update a message belonging to another user" do
|
|
sign_in :jz
|
|
assert_not users(:jz).administrator?
|
|
|
|
room = rooms(:designers)
|
|
message = room.messages.where(creator: users(:jason)).first
|
|
|
|
put room_message_url(room, message), params: { message: { body: "Updated body" } }
|
|
assert_response :forbidden
|
|
end
|
|
|
|
test "ensure non-admin can't destroy a message belonging to another user" do
|
|
sign_in :jz
|
|
assert_not users(:jz).administrator?
|
|
|
|
room = rooms(:designers)
|
|
message = room.messages.where(creator: users(:jason)).first
|
|
|
|
delete room_message_url(room, message, format: :turbo_stream)
|
|
assert_response :forbidden
|
|
end
|
|
|
|
test "mentioning a bot triggers a webhook" do
|
|
WebMock.stub_request(:post, webhooks(:bender).url).to_return(status: 200)
|
|
|
|
assert_enqueued_jobs 1, only: Bot::WebhookJob do
|
|
post room_messages_url(@room, format: :turbo_stream), params: { message: {
|
|
body: "<div>Hey #{mention_attachment_for(:bender)}</div>", client_message_id: 999 } }
|
|
end
|
|
end
|
|
|
|
private
|
|
def ensure_messages_present(*messages, count: 1)
|
|
messages.each do |message|
|
|
assert_select "#" + dom_id(message), count:
|
|
end
|
|
end
|
|
|
|
def ensure_messages_not_present(*messages)
|
|
ensure_messages_present *messages, count: 0
|
|
end
|
|
|
|
def assert_copy_link_button(url)
|
|
assert_select ".btn[title='Copy link'][data-copy-to-clipboard-content-value='#{url}']"
|
|
end
|
|
end
|