mirror of
https://github.com/basecamp/once-campfire.git
synced 2026-09-27 10:36:37 +09:00
6acad0549d
The editor keeps an attachment's content as it finds it, so a hand-written embed with a url but no href reached the editor with its markup unvalidated, and a mention saved under Trix's editor carried the generic octet-stream content type the editor doesn't permit and was dropped on save. Rebuilding each attachment from its attachable renders the hardened preview partial and restores the mention content type.
183 lines
5.7 KiB
Ruby
183 lines
5.7 KiB
Ruby
require "application_system_test_case"
|
|
|
|
class ComposerTest < ApplicationSystemTestCase
|
|
setup do
|
|
sign_in "jz@37signals.com"
|
|
join_room rooms(:designers)
|
|
end
|
|
|
|
test "enter sends the message when the toolbar is collapsed" do
|
|
type_in_composer "A quick reply"
|
|
press_in_composer :enter
|
|
|
|
assert_message_text "A quick reply"
|
|
assert_composer_empty
|
|
end
|
|
|
|
test "enter adds a newline in rich text mode and meta+enter sends" do
|
|
toggle_rich_text_toolbar
|
|
|
|
type_in_composer "line one"
|
|
press_in_composer :enter
|
|
type_in_composer "line two"
|
|
|
|
assert_no_message_text "line one"
|
|
|
|
press_in_composer [ :control, :enter ]
|
|
|
|
assert_message_text /line one\s*line two/
|
|
assert_composer_empty
|
|
end
|
|
|
|
test "markdown strikethrough survives sanitization" do
|
|
type_in_composer "Hello ~~Claude~~ World"
|
|
press_in_composer :enter
|
|
|
|
assert_selector last_message_selector("s"), text: "Claude"
|
|
assert_message_text "Hello Claude World"
|
|
end
|
|
|
|
test "mentioning a user with @ inserts a mention attachment" do
|
|
type_in_composer "Hey @Jas"
|
|
pick_mention "Jason"
|
|
click_send_button
|
|
|
|
assert_selector last_message_selector(".mention"), text: "Jason"
|
|
|
|
message = wait_for_persisted_message
|
|
assert_includes message.body.body.to_html, "application/vnd.campfire.mention"
|
|
assert_equal [ users(:jason) ], message.mentionees
|
|
end
|
|
|
|
test "editing a message with a mention keeps the mention" do
|
|
type_in_composer "Hey @Jas"
|
|
pick_mention "Jason"
|
|
click_send_button
|
|
|
|
assert_selector last_message_selector(".mention"), text: "Jason"
|
|
message = wait_for_persisted_message
|
|
|
|
within_message message do
|
|
reveal_message_actions
|
|
find(".message__edit-btn").click
|
|
assert_edit_editor_text "Jason"
|
|
click_on "Save changes"
|
|
end
|
|
|
|
assert_selector last_message_selector(".mention"), text: "Jason"
|
|
assert_equal [ users(:jason) ], message.reload.mentionees
|
|
end
|
|
|
|
test "editing a legacy trix message keeps its mention and embed" do
|
|
body = %(<div>Hey #{mention_attachment_for(:jason)} check <action-text-attachment content-type="application/vnd.actiontext.opengraph-embed" url="https://example.com/image.png" href="https://example.com/" filename="Example title" caption="Example description"></action-text-attachment></div>)
|
|
message = Message.create! room: rooms(:designers), body: body, client_message_id: "legacy", creator: users(:jz)
|
|
|
|
join_room rooms(:designers)
|
|
|
|
within_message message do
|
|
reveal_message_actions
|
|
find(".message__edit-btn").click
|
|
assert_edit_editor_text "Jason"
|
|
click_on "Save changes"
|
|
end
|
|
|
|
assert_selector last_message_selector(".mention"), text: "Jason"
|
|
assert_selector last_message_selector(%(.og-embed__title a[href="https://example.com/"])), text: "Example title"
|
|
assert_equal [ users(:jason) ], message.reload.mentionees
|
|
end
|
|
|
|
test "editing a message whose mention was saved under Trix keeps the mention" do
|
|
body = %(<div>Hey <action-text-attachment sgid="#{users(:jason).attachable_sgid}" content-type="application/octet-stream"></action-text-attachment></div>)
|
|
message = Message.create! room: rooms(:designers), body: body, client_message_id: "trix-edited", creator: users(:jz)
|
|
|
|
join_room rooms(:designers)
|
|
|
|
within_message message do
|
|
reveal_message_actions
|
|
find(".message__edit-btn").click
|
|
assert_edit_editor_text "Jason"
|
|
click_on "Save changes"
|
|
end
|
|
|
|
assert_selector last_message_selector(".mention"), text: "Jason"
|
|
assert_equal [ users(:jason) ], message.reload.mentionees
|
|
end
|
|
|
|
test "pasting a table keeps its text" do
|
|
paste_in_composer "Name Points\nJason 10", html: "<table><tr><th>Name</th><th>Points</th></tr><tr><td>Jason</td><td>10</td></tr></table>"
|
|
|
|
assert_selector "#composer lexxy-editor table"
|
|
|
|
click_send_button
|
|
|
|
assert_message_text /Name Points\s*Jason 10/
|
|
assert_no_selector last_message_selector("table")
|
|
end
|
|
|
|
test "replying quotes the original message with attribution" do
|
|
within_message messages(:third) do
|
|
reveal_message_actions
|
|
find("[aria-label='Reply']").click
|
|
end
|
|
|
|
assert_composer_text "Third time's a charm."
|
|
|
|
click_send_button
|
|
|
|
assert_selector last_message_selector("blockquote"), text: "Third time's a charm."
|
|
assert_selector last_message_selector("cite"), text: "JZ"
|
|
end
|
|
|
|
test "arrow up edits my last message when the composer is empty" do
|
|
composer_editor.click
|
|
press_in_composer :up
|
|
|
|
assert_selector ".message__body-content--editing"
|
|
assert_edit_editor_text "Third time's a charm."
|
|
end
|
|
|
|
test "pasting a URL unfurls an opengraph preview" do
|
|
metadata = Opengraph::Metadata.new(
|
|
title: "Example Site",
|
|
url: "https://example.com/article",
|
|
description: "An example article",
|
|
image: ""
|
|
)
|
|
Opengraph::Metadata.stubs(:from_url).returns(metadata)
|
|
|
|
paste_in_composer "https://example.com/article"
|
|
|
|
within "#composer" do
|
|
assert_selector ".og-embed__title", text: "Example Site", wait: 10
|
|
end
|
|
|
|
click_send_button
|
|
|
|
assert_selector last_message_selector(".og-embed__title"), text: "Example Site"
|
|
end
|
|
|
|
private
|
|
def click_send_button
|
|
find("#composer [data-action='composer#submit']").click
|
|
end
|
|
|
|
def last_message_selector(inner)
|
|
".message:last-of-type .message__body #{inner}"
|
|
end
|
|
|
|
def assert_no_message_text(text)
|
|
assert_no_selector ".message__body", text: text
|
|
end
|
|
|
|
# The message insert races with the form POST, so give the server a moment
|
|
def wait_for_persisted_message(room: rooms(:designers), since: 1.minute.ago)
|
|
message = nil
|
|
20.times do
|
|
message = room.messages.ordered.last
|
|
break if message.created_at > since
|
|
sleep 0.25
|
|
end
|
|
message
|
|
end
|
|
end
|