mirror of
https://github.com/basecamp/once-campfire.git
synced 2026-10-28 00:16:48 +09:00
Jeremy Daer
48da2b4e4e
A password change ends every session, but a sign-in or sign-in link checked
against the old password just before the change could still save its session
just after, and that session outlived the change.
The session now checks, as it's saved, that the user's password is still the
one the request loaded. The save's transaction holds SQLite's write lock from
the start, so a change commits either before the check, which fails it, or
after the insert, and ends this session with the others. Sessions start
through the user's association so the check sees the user that was
authenticated, and a refused sign-in is answered like a wrong password.
(cherry picked from commit 19319a1cff)
49 lines
1.6 KiB
Ruby
49 lines
1.6 KiB
Ruby
require "test_helper"
|
|
|
|
class Sessions::TransfersControllerTest < ActionDispatch::IntegrationTest
|
|
test "show renders when not signed in" do
|
|
get session_transfer_url("some-token")
|
|
|
|
assert_response :success
|
|
assert_select "form[data-controller='auto-submit']", count: 1
|
|
assert_select "input[name='_method'][value='put']", count: 1
|
|
assert_equal response.body.scan(/<form\b/).size, response.body.scan("</form>").size
|
|
assert_match(/<form\b[^>]*data-controller="auto-submit"[^>]*>(?:\s*<input\b[^>]*>)*\s*<\/form>/, response.body)
|
|
end
|
|
|
|
test "update establishes a session when the code is valid" do
|
|
user = users(:david)
|
|
|
|
put session_transfer_url(user.transfer_id)
|
|
|
|
assert_redirected_to root_url
|
|
assert parsed_cookies.signed[:session_token]
|
|
end
|
|
|
|
test "update rejects a link made before the password changed" do
|
|
user = users(:david)
|
|
transfer_id = user.transfer_id
|
|
user.update!(password: "a new secret123456")
|
|
|
|
put session_transfer_url(transfer_id)
|
|
|
|
assert_response :bad_request
|
|
assert_nil parsed_cookies.signed[:session_token]
|
|
end
|
|
|
|
test "update is refused when the password changes after the link was checked" do
|
|
user = users(:david)
|
|
transfer_id = user.transfer_id
|
|
stale = User.find(user.id)
|
|
User.find(user.id).update!(password: "a new secret123456")
|
|
User.stubs(:find_by_transfer_id).with(transfer_id).returns(stale)
|
|
|
|
assert_no_difference -> { Session.count } do
|
|
put session_transfer_url(transfer_id)
|
|
end
|
|
|
|
assert_response :bad_request
|
|
assert_nil parsed_cookies.signed[:session_token]
|
|
end
|
|
end
|