mirror of
https://github.com/basecamp/once-campfire.git
synced 2026-10-09 00:00:12 +09:00
Marcello Costagliola
c48083dcfe
Showing an image's preview when its variant had already been made tied the cached message to state that changes without touching it: a variant made after the message was cached would never show. It also cost a query per embedded image, since Action Text loads the embeds without their variant records. Nothing in the app makes those variants, so the partial no longer looks at them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Bj8KnxpTf9sj2Ysa8aLAVa
65 lines
3.1 KiB
Ruby
65 lines
3.1 KiB
Ruby
require "test_helper"
|
|
|
|
class MessagesHelperTest < ActionView::TestCase
|
|
include ActiveRecord::Assertions::QueryAssertions
|
|
|
|
test "message_presentation neutralizes unsafe URI schemes in links" do
|
|
message = Message.create! room: rooms(:pets), body: '<div><a href="javascript:alert(1)">x</a></div>', client_message_id: "0015", creator: users(:jason)
|
|
|
|
presentation = view.message_presentation(message)
|
|
assert_no_match /javascript:/, presentation
|
|
assert_match /<a>x<\/a>/, presentation
|
|
end
|
|
|
|
test "message_presentation strips event handler attributes from allowed tags" do
|
|
message = Message.create! room: rooms(:pets), body: '<div><a href="/x" onmouseover="alert(1)">x</a></div>', client_message_id: "0015", creator: users(:jason)
|
|
|
|
presentation = view.message_presentation(message)
|
|
assert_no_match /onmouseover/, presentation
|
|
assert_match /<a href="\/x">x<\/a>/, presentation
|
|
end
|
|
|
|
test "message_presentation preserves safe links and formatting" do
|
|
message = Message.create! room: rooms(:pets), body: '<div><a href="https://example.com">example</a> <strong>bold</strong></div>', client_message_id: "0015", creator: users(:jason)
|
|
|
|
presentation = view.message_presentation(message)
|
|
assert_match /<a href="https:\/\/example\.com"[^>]*>example<\/a>/, presentation
|
|
assert_match /<strong>bold<\/strong>/, presentation
|
|
end
|
|
|
|
test "message_presentation shows an image in the rich text as a file, rather than making its preview on view" do
|
|
message = Message.with_attachment_details.find(message_with_file_in_rich_text("moon.jpg", "image/jpeg").id)
|
|
|
|
presentation = nil
|
|
assert_no_queries_match(/active_storage_variant_records/) { presentation = view.message_presentation(message) }
|
|
|
|
assert_no_match %r{/representations/}, presentation
|
|
assert_match %r{<span class="attachment__name">moon\.jpg</span>}, presentation
|
|
end
|
|
|
|
test "message_presentation shows an image in the rich text as a file even when its preview was made" do
|
|
message = message_with_file_in_rich_text("moon.jpg", "image/jpeg")
|
|
message.body.embeds.first.blob.variant(resize_to_limit: [ 1024, 768 ]).processed
|
|
|
|
presentation = view.message_presentation(message.reload)
|
|
|
|
assert_no_match %r{/representations/}, presentation
|
|
assert_match %r{<span class="attachment__name">moon\.jpg</span>}, presentation
|
|
end
|
|
|
|
test "message_presentation shows a video in the rich text as a file" do
|
|
presentation = view.message_presentation(message_with_file_in_rich_text("alpha-centuri.mov", "video/quicktime"))
|
|
|
|
assert_no_match %r{/representations/}, presentation
|
|
assert_match %r{<span class="attachment__name">alpha-centuri\.mov</span>}, presentation
|
|
end
|
|
|
|
private
|
|
def message_with_file_in_rich_text(file, content_type)
|
|
blob = ActiveStorage::Blob.create_and_upload!(io: file_fixture(file).open, filename: file, content_type: content_type)
|
|
body = %(<div>Here: <action-text-attachment sgid="#{blob.attachable_sgid}"></action-text-attachment></div>)
|
|
|
|
Message.create! room: rooms(:pets), body: body, client_message_id: "0015", creator: users(:jason)
|
|
end
|
|
end
|