mirror of
https://github.com/go-gitea/gitea.git
synced 2026-11-19 15:14:40 +09:00
Several entry points change users, credentials or 2FA without writing an audit event, while the equivalent web or service path does. This records the existing actions on those paths: - `user:create` for self sign-up, OAuth2 auto-registration, link-account registration and `gitea admin user create` - `user:accesstoken:add` for `gitea admin user generate-access-token` and `user create --access-token`; `user:accesstoken:remove` for `DELETE /api/v1/token` - `user:twofactor:disable` for the admin "reset 2FA" option and `gitea admin user disable-2fa` - `user:key:ssh:add`, `user:key:gpg:add/remove` for the API - `user:email:primary`, `user:email:activate`, `user:status:active` for settings, the activation page/links and OAuth2 source sync deactivation - `user:oauth2application:grant` when a grant's scope changes, `user:externallogin:add` on registration via an external login - `user:authentication:fail:twofactor` for wrong recovery codes, failed WebAuthn assertions and 2FA during password reset Should be backported to v28. --------- Co-authored-by: silverwind <me@silverwind.io>
158 lines
7.4 KiB
Go
158 lines
7.4 KiB
Go
// Copyright 2023 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package cmd
|
|
|
|
import (
|
|
"fmt"
|
|
"strings"
|
|
"testing"
|
|
|
|
audit_model "gitea.dev/models/audit"
|
|
auth_model "gitea.dev/models/auth"
|
|
"gitea.dev/models/db"
|
|
"gitea.dev/models/unittest"
|
|
user_model "gitea.dev/models/user"
|
|
"gitea.dev/modules/setting"
|
|
"gitea.dev/modules/test"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestAdminUserCreate(t *testing.T) {
|
|
reset := func() {
|
|
require.NoError(t, db.TruncateBeans(t.Context(), &user_model.User{}))
|
|
require.NoError(t, db.TruncateBeans(t.Context(), &user_model.EmailAddress{}))
|
|
require.NoError(t, db.TruncateBeans(t.Context(), &auth_model.AccessToken{}))
|
|
}
|
|
|
|
t.Run("MustChangePassword", func(t *testing.T) {
|
|
type check struct {
|
|
IsAdmin bool
|
|
MustChangePassword bool
|
|
}
|
|
|
|
createCheck := func(name, args string) check {
|
|
require.NoError(t, microcmdUserCreate().Run(t.Context(), strings.Fields(fmt.Sprintf("create --username %s --email %s@gitea.local %s --password foobar", name, name, args))))
|
|
u := unittest.AssertExistsAndLoadBean(t, &user_model.User{LowerName: name})
|
|
return check{IsAdmin: u.IsAdmin, MustChangePassword: u.MustChangePassword}
|
|
}
|
|
reset()
|
|
assert.Equal(t, check{IsAdmin: false, MustChangePassword: false}, createCheck("u", ""), "first non-admin user doesn't need to change password")
|
|
|
|
reset()
|
|
assert.Equal(t, check{IsAdmin: true, MustChangePassword: false}, createCheck("u", "--admin"), "first admin user doesn't need to change password")
|
|
|
|
reset()
|
|
assert.Equal(t, check{IsAdmin: true, MustChangePassword: true}, createCheck("u", "--admin --must-change-password"))
|
|
assert.Equal(t, check{IsAdmin: true, MustChangePassword: true}, createCheck("u2", "--admin"))
|
|
assert.Equal(t, check{IsAdmin: true, MustChangePassword: false}, createCheck("u3", "--admin --must-change-password=false"))
|
|
assert.Equal(t, check{IsAdmin: false, MustChangePassword: true}, createCheck("u4", ""))
|
|
assert.Equal(t, check{IsAdmin: false, MustChangePassword: false}, createCheck("u5", "--must-change-password=false"))
|
|
})
|
|
|
|
createUser := func(name string, args ...string) error {
|
|
return microcmdUserCreate().Run(t.Context(), append([]string{"create", "--username", name, "--email", name + "@gitea.local"}, args...))
|
|
}
|
|
|
|
t.Run("UserType", func(t *testing.T) {
|
|
reset()
|
|
assert.ErrorContains(t, createUser("u", "--user-type", "invalid"), "invalid user type")
|
|
assert.ErrorContains(t, createUser("u", "--user-type", "bot", "--password", "123"), "can only be set for user accounts")
|
|
assert.ErrorContains(t, createUser("u", "--user-type", "bot", "--must-change-password"), "can only be set for user accounts")
|
|
assert.ErrorContains(t, createUser("u", "--user-type", "bot", "--admin"), "bot user can not be a site administrator")
|
|
|
|
assert.NoError(t, createUser("u", "--user-type", "bot"))
|
|
u := unittest.AssertExistsAndLoadBean(t, &user_model.User{LowerName: "u"})
|
|
assert.Equal(t, user_model.UserTypeBot, u.Type)
|
|
assert.Empty(t, u.Passwd)
|
|
assert.False(t, u.MustChangePassword, "bot users should not be forced to change password")
|
|
|
|
changeType := func(userType string) error {
|
|
return microcmdUserChangeType().Run(t.Context(), []string{"change-type", "--username", "u", "--user-type", userType})
|
|
}
|
|
assert.NoError(t, changeType("User"))
|
|
assert.True(t, unittest.AssertExistsAndLoadBean(t, &user_model.User{LowerName: "u"}).IsIndividual())
|
|
})
|
|
|
|
t.Run("AccessToken", func(t *testing.T) {
|
|
// no generated access token
|
|
reset()
|
|
assert.NoError(t, createUser("u", "--random-password"))
|
|
assert.Equal(t, 1, unittest.GetCount(t, &user_model.User{}))
|
|
assert.Equal(t, 0, unittest.GetCount(t, &auth_model.AccessToken{}))
|
|
|
|
// using "--access-token" only means "all" access
|
|
reset()
|
|
assert.NoError(t, createUser("u", "--random-password", "--access-token"))
|
|
assert.Equal(t, 1, unittest.GetCount(t, &user_model.User{}))
|
|
assert.Equal(t, 1, unittest.GetCount(t, &auth_model.AccessToken{}))
|
|
accessToken := unittest.AssertExistsAndLoadBean(t, &auth_model.AccessToken{Name: "gitea-admin"})
|
|
hasScopes, err := accessToken.Scope.HasScope(auth_model.AccessTokenScopeWriteAdmin, auth_model.AccessTokenScopeWriteRepository)
|
|
assert.NoError(t, err)
|
|
assert.True(t, hasScopes)
|
|
|
|
// using "--access-token" with name & scopes
|
|
reset()
|
|
assert.NoError(t, createUser("u", "--random-password", "--access-token", "--access-token-name", "new-token-name", "--access-token-scopes", "read:issue,read:user"))
|
|
assert.Equal(t, 1, unittest.GetCount(t, &user_model.User{}))
|
|
assert.Equal(t, 1, unittest.GetCount(t, &auth_model.AccessToken{}))
|
|
accessToken = unittest.AssertExistsAndLoadBean(t, &auth_model.AccessToken{Name: "new-token-name"})
|
|
hasScopes, err = accessToken.Scope.HasScope(auth_model.AccessTokenScopeReadIssue, auth_model.AccessTokenScopeReadUser)
|
|
assert.NoError(t, err)
|
|
assert.True(t, hasScopes)
|
|
hasScopes, err = accessToken.Scope.HasScope(auth_model.AccessTokenScopeWriteAdmin, auth_model.AccessTokenScopeWriteRepository)
|
|
assert.NoError(t, err)
|
|
assert.False(t, hasScopes)
|
|
|
|
// using "--access-token-name" without "--access-token"
|
|
reset()
|
|
err = createUser("u", "--random-password", "--access-token-name", "new-token-name")
|
|
assert.Equal(t, 0, unittest.GetCount(t, &user_model.User{}))
|
|
assert.Equal(t, 0, unittest.GetCount(t, &auth_model.AccessToken{}))
|
|
assert.ErrorContains(t, err, "access-token-name and access-token-scopes flags are only valid when access-token flag is set")
|
|
|
|
// using "--access-token-scopes" without "--access-token"
|
|
reset()
|
|
err = createUser("u", "--random-password", "--access-token-scopes", "read:issue")
|
|
assert.Equal(t, 0, unittest.GetCount(t, &user_model.User{}))
|
|
assert.Equal(t, 0, unittest.GetCount(t, &auth_model.AccessToken{}))
|
|
assert.ErrorContains(t, err, "access-token-name and access-token-scopes flags are only valid when access-token flag is set")
|
|
|
|
// empty permission
|
|
reset()
|
|
err = createUser("u", "--random-password", "--access-token", "--access-token-scopes", "public-only")
|
|
assert.Equal(t, 0, unittest.GetCount(t, &user_model.User{}))
|
|
assert.Equal(t, 0, unittest.GetCount(t, &auth_model.AccessToken{}))
|
|
assert.ErrorContains(t, err, "access token does not have any permission")
|
|
})
|
|
|
|
t.Run("UserFields", func(t *testing.T) {
|
|
reset()
|
|
assert.NoError(t, createUser("u-FullNameWithSpace", "--random-password", "--fullname", "First O'Middle Last"))
|
|
unittest.AssertExistsAndLoadBean(t, &user_model.User{
|
|
Name: "u-FullNameWithSpace",
|
|
LowerName: "u-fullnamewithspace",
|
|
FullName: "First O'Middle Last",
|
|
Email: "u-FullNameWithSpace@gitea.local",
|
|
})
|
|
|
|
assert.NoError(t, createUser("u-FullNameEmpty", "--random-password", "--fullname", ""))
|
|
u := unittest.AssertExistsAndLoadBean(t, &user_model.User{LowerName: "u-fullnameempty"})
|
|
assert.Empty(t, u.FullName)
|
|
})
|
|
|
|
t.Run("AuditEvents", func(t *testing.T) {
|
|
defer test.MockVariableValue(&setting.Audit.RecordOutput, setting.AuditRecordOutputDatabase)()
|
|
reset()
|
|
require.NoError(t, db.TruncateBeans(t.Context(), &audit_model.Event{}))
|
|
|
|
require.NoError(t, createUser("u", "--random-password", "--access-token"))
|
|
require.NoError(t, newUserGenerateAccessTokenCommand().Run(t.Context(), []string{"generate-access-token", "--username", "u", "--token-name", "cli-token", "--scopes", "read:user", "--raw"}))
|
|
|
|
unittest.AssertExistsAndLoadBean(t, &audit_model.Event{Action: audit_model.UserCreate, ScopeName: "u"})
|
|
unittest.AssertCount(t, &audit_model.Event{Action: audit_model.UserAccessTokenAdd, ScopeName: "u"}, 2)
|
|
})
|
|
}
|