mirror of
https://github.com/go-gitea/gitea.git
synced 2026-10-26 06:16:56 +09:00
`make lint-go` ran `go install` and then a bare `golangci-lint` from `PATH`, which fails when `GOBIN` is not in `PATH` and overwrites any `golangci-lint` installed there. It now uses `go run -exec 'env GOOS=<target>'`, which builds golangci-lint for the host and passes the lint target `GOOS` only to golangci-lint. `deps-tools` prebuilds the tools with `go run -exec true` instead of `go install`, because `go install` does not fill the executable cache that `go run` uses. Also drops the unused `TAGS` env and the redundant OS name in `--build-tags`.
127 lines
3.4 KiB
Go
127 lines
3.4 KiB
Go
// Copyright 2026 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package main
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"io"
|
|
"io/fs"
|
|
"os"
|
|
"os/exec"
|
|
"path/filepath"
|
|
"regexp"
|
|
"slices"
|
|
"strings"
|
|
|
|
"golang.org/x/mod/modfile"
|
|
)
|
|
|
|
// goModIgnoredDirs returns the go.mod "ignore" directories, which the go tool skips but a filesystem walk does not.
|
|
func goModIgnoredDirs() (map[string]bool, error) {
|
|
data, err := os.ReadFile("go.mod")
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
mod, err := modfile.Parse("go.mod", data, nil)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
dirs := make(map[string]bool, len(mod.Ignore))
|
|
for _, ignore := range mod.Ignore {
|
|
dirs[filepath.ToSlash(filepath.Clean(ignore.Path))] = true
|
|
}
|
|
return dirs, nil
|
|
}
|
|
|
|
func lintGoHeader() bool {
|
|
headerRE := regexp.MustCompile(`^(// (Copyright [^\n]+|All rights reserved\.)\n)*// Copyright \d{4} (The Gogs Authors|The Gitea Authors|Gitea Authors|Gitea)\.( All rights reserved\.)?\n(// (Copyright [^\n]+|All rights reserved\.)\n)*// SPDX-License-Identifier: [\w.-]+`)
|
|
generatedRE := regexp.MustCompile(`(?m)^// (Code|This file is) [Gg]enerated.*DO NOT EDIT`)
|
|
skipDirs, err := goModIgnoredDirs()
|
|
if err != nil {
|
|
_, _ = fmt.Fprintln(os.Stderr, err)
|
|
return false
|
|
}
|
|
root, bad := ".", 0
|
|
err = filepath.WalkDir(root, func(path string, d fs.DirEntry, err error) error {
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if d.IsDir() {
|
|
if path == root {
|
|
return nil
|
|
}
|
|
if skipDirs[filepath.ToSlash(path)] || strings.HasPrefix(d.Name(), ".") {
|
|
return fs.SkipDir
|
|
}
|
|
return nil
|
|
}
|
|
if !strings.HasSuffix(path, ".go") {
|
|
return nil
|
|
}
|
|
f, err := os.Open(path)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
data, err := io.ReadAll(io.LimitReader(f, 512))
|
|
_ = f.Close()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if generatedRE.Match(data) {
|
|
return nil
|
|
}
|
|
if !headerRE.Match(data) {
|
|
_, _ = fmt.Fprintf(os.Stderr, "%s: missing or invalid copyright header\n", path)
|
|
bad++
|
|
}
|
|
return nil
|
|
})
|
|
if err != nil {
|
|
_, _ = fmt.Fprintln(os.Stderr, err)
|
|
}
|
|
return err == nil && bad == 0
|
|
}
|
|
|
|
func main() {
|
|
_, _ = os.Unsetenv("GOOS"), os.Unsetenv("GOARCH")
|
|
|
|
envGolangciLintPackage := os.Getenv("GOLANGCI_LINT_PACKAGE")
|
|
envGo := os.Getenv("GO")
|
|
if envGo == "" || envGolangciLintPackage == "" {
|
|
_, _ = fmt.Fprintln(os.Stderr, "Environment variables GO and GOLANGCI_LINT_PACKAGE must be set")
|
|
os.Exit(1)
|
|
}
|
|
golangciLint := func(goos string, args ...string) bool {
|
|
cmd := exec.Command(envGo, slices.Concat([]string{"run", "-exec", "env GOOS=" + goos, envGolangciLintPackage, "run"}, args, os.Args[1:])...)
|
|
cmd.Stdout, cmd.Stderr = os.Stdout, os.Stderr
|
|
err := cmd.Run()
|
|
if _, isExit := errors.AsType[*exec.ExitError](err); err != nil && !isExit {
|
|
_, _ = fmt.Fprintln(os.Stderr, err)
|
|
}
|
|
return err == nil
|
|
}
|
|
|
|
_, _ = fmt.Fprintln(os.Stdout, "lint go header ...")
|
|
succeed := lintGoHeader()
|
|
|
|
_, _ = fmt.Fprintln(os.Stdout, "lint for linux ...")
|
|
lintTagsLinux := ""
|
|
if os.Getenv("CI") != "" || strings.Contains(os.Getenv("TAGS"), "bindata") {
|
|
// also lint with bindata tag if we are in CI or the "bindata" is explicitly set in the env TAGS
|
|
lintTagsLinux = "bindata"
|
|
}
|
|
succeed = golangciLint("linux", "--build-tags="+lintTagsLinux) && succeed
|
|
|
|
if os.Getenv("CI") != "" {
|
|
// only lint for other platforms when in CI, to keep local lint fast
|
|
_, _ = fmt.Fprintln(os.Stdout, "lint for windows ...")
|
|
succeed = golangciLint("windows") && succeed
|
|
}
|
|
|
|
if !succeed {
|
|
os.Exit(1)
|
|
}
|
|
}
|