mirror of
https://github.com/go-gitea/gitea.git
synced 2026-11-05 00:09:33 +09:00
666e6e2d17
Clearing "Full Name" in the profile settings shows success but keeps the old value: since #31959 it is only updated when non-empty, because the input is disabled (not submitted) when `change_full_name` is disabled. Use `*string` for the field, so a missing field keeps the value and an empty one clears it. With `change_full_name` disabled, any submitted value (including empty) is now rejected. Not `optional.Option[string]`, because `MaxSize` would count slice elements instead of characters. Fixes #40185 --- AI disclosure: written with Claude Code (claude-opus-5-5) and tested locally. --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: silverwind <me@silverwind.io>
86 lines
1.9 KiB
Go
86 lines
1.9 KiB
Go
// Copyright 2024 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package optional
|
|
|
|
import "strconv"
|
|
|
|
// Option is a generic type that can hold a value of type T or be empty (None).
|
|
//
|
|
// It must use the slice type to work with "chi" form values binding:
|
|
// * non-existing value are represented as an empty slice (None)
|
|
// * existing value is represented as a slice with one element (Some)
|
|
// * multiple values are represented as a slice with multiple elements (Some), the Value is the first element (not well-defined in this case)
|
|
//
|
|
// Attention: Option[T] doesn't work with some web middleware binding rules like "MaxSize" at the moment.
|
|
type Option[T any] []T
|
|
|
|
func None[T any]() Option[T] {
|
|
return nil
|
|
}
|
|
|
|
func Some[T any](v T) Option[T] {
|
|
return Option[T]{v}
|
|
}
|
|
|
|
func FromPtr[T any](v *T) Option[T] {
|
|
if v == nil {
|
|
return None[T]()
|
|
}
|
|
return Some(*v)
|
|
}
|
|
|
|
func FromMapLookup[K comparable, V any](m map[K]V, k K) Option[V] {
|
|
if v, ok := m[k]; ok {
|
|
return Some(v)
|
|
}
|
|
return None[V]()
|
|
}
|
|
|
|
func FromNonDefault[T comparable](v T) Option[T] {
|
|
var zero T
|
|
if v == zero {
|
|
return None[T]()
|
|
}
|
|
return Some(v)
|
|
}
|
|
|
|
func (o Option[T]) Has() bool {
|
|
return o != nil
|
|
}
|
|
|
|
func (o Option[T]) Value() T {
|
|
var zero T
|
|
return o.ValueOrDefault(zero)
|
|
}
|
|
|
|
func (o Option[T]) ValueOrDefault(v T) T {
|
|
if o.Has() {
|
|
return o[0]
|
|
}
|
|
return v
|
|
}
|
|
|
|
// ParseBool get the corresponding optional.Option[bool] of a string using strconv.ParseBool
|
|
func ParseBool(s string) Option[bool] {
|
|
v, e := strconv.ParseBool(s)
|
|
if e != nil {
|
|
return None[bool]()
|
|
}
|
|
return Some(v)
|
|
}
|
|
|
|
func AssignPtrValue[T comparable](changed *bool, target, src *T) {
|
|
if src != nil && *src != *target {
|
|
*target = *src
|
|
*changed = true
|
|
}
|
|
}
|
|
|
|
func AssignPtrString[TO, FROM ~string](changed *bool, target *TO, src *FROM) {
|
|
if src != nil && string(*src) != string(*target) {
|
|
*target = TO(*src)
|
|
*changed = true
|
|
}
|
|
}
|