Commit Graph
4902 Commits
Author SHA1 Message Date
Kristoffer Dalby 070fe4c9bd db, types: add a column for auto-approved routes
It starts empty: the current policy cannot tell which earlier approvals
were automatic, so all of them stay as an admin's.
2026-10-28 14:42:02 +00:00
Kristoffer Dalby 3c0f6e8120 state: auto-approve on registration only when the node key rotates
Registration runs the approval itself, once the policy manager knows the
node's owner, for a new node key or a change to the announced routes.
2026-10-28 14:42:01 +00:00
Kristoffer Dalby 822c8779a5 auth: store a client's earlier expiry and expire a tagged node at logout
A client may bring its expiry forward, which turns expiry on for a node
without one, but still cannot push it back. Logout expires tagged nodes
too.
2026-10-28 14:42:00 +00:00
Kristoffer Dalby 309cfbb342 auth, state: answer an expired node's same-key login with NodeKeyExpired
The client then rotates its node key and logs in again, so no key is
judged under the expired one. The machine stays authorised.
2026-10-28 14:41:47 +00:00
Kristoffer Dalby 7625a5ec90 state: forget a node's SSH check approvals when it is expired 2026-10-28 14:41:46 +00:00
Kristoffer Dalby e43ee22b01 state: honour SSH check approvals only while the source keeps its owner 2026-10-28 14:41:02 +00:00
Kristoffer Dalby bf1ff1665b state: let a pre-auth key that is no longer valid only wake its node
A login that keeps its node key leaves a live node's expiry alone, even
with a valid key, and a wake-up is not refused for the tags it requests.
2026-10-28 14:40:49 +00:00
Kristoffer Dalby c1e4c56848 state: serialise registrations presenting an unused single-use key 2026-10-28 14:40:32 +00:00
Kristoffer Dalby a0893b43ff state: auto-approve routes in the NodeStore writer, not on reload
Registration approval runs on the node the writer replaces. A policy
reload approves nothing, and a map request only when its announced
routes change, so neither re-grants a route an admin revoked.
2026-10-28 14:39:41 +00:00
Kristoffer Dalby 69c69d35e2 state: undo a failed re-registration without reverting newer writes 2026-10-28 14:39:40 +00:00
Kristoffer Dalby cff67806cb state: write node rows from the NodeStore under persistMu 2026-10-28 14:39:25 +00:00
Kristoffer Dalby 3cf284917d state: apply map requests only under the node key that authorised them 2026-10-28 14:38:12 +00:00
Kristoffer Dalby b36f9d443f policy: offer exit routes only to viewers whose rules reach the internet
Every destination overlaps /0, so any rule offered a peer's exit routes.
They now need a rule to the internet, the test exit-node visibility
uses; via steering defers them to a regular grant only on that test.
2026-10-28 14:38:11 +00:00
Kristoffer Dalby a188777784 mapper: send a router all of its own routes
Its AllowedIPs held only the primaries the policy let it reach. It now
holds every approved route, and PrimaryRoutes the ones it serves.
2026-10-28 14:38:10 +00:00
Kristoffer Dalby 013ec0b59f policy: reduce merged destination prefixes to the node's own addresses
Adjacent node addresses merge into one prefix, and each node's filter
kept all of it. A prefix made only of node addresses now shrinks to the
node's own; a prefix the policy wrote, or one the node routes, stays.
2026-10-28 14:38:10 +00:00
Kristoffer Dalby 306a3d0f25 api, policy/v2: refuse route prefixes with host bits
Routes are matched as written, so such a prefix never equals the one a
client announces. The approval APIs answer 400 and autoApprovers refuses
it at load and write, with Tailscale's text.
2026-10-28 14:38:09 +00:00
Kristoffer Dalby d648cf6b95 policy, state: log only the routes auto-approval adds 2026-10-28 14:38:08 +00:00
Kristoffer Dalby 7123adc5a9 poll: hold the map session's node as a view 2026-10-28 14:38:07 +00:00
Kristoffer Dalby de7e77cf3d policy/matcher, types: compare a node's routes to matchers as ranges 2026-10-28 14:38:06 +00:00
Kristoffer Dalby 6420fb4600 policy/matcher: binary-search ranges in overlap checks 2026-10-28 14:38:05 +00:00
Kristoffer Dalby 772db35e8f policy: look up approved routes in a set when auto-approving
Avoid scanning the growing approval list for every announcement.
Use the sorted current routes when identifying additions.
2026-10-28 14:38:04 +00:00
Kristoffer Dalby 619b731c18 types, state: reduce a node's routes against the matchers once
Reuse matcher membership and approved subnets across the route list.
Preserve route order and HA co-router visibility.
2026-10-28 14:38:03 +00:00
Kristoffer Dalby 2c76879d0e types: derive subnet and exit routes in one pass
Emit each approved route once, in announcement order.
Skip derivation when no routes are approved.
2026-10-28 14:37:47 +00:00
Kristoffer Dalby 235e6b62c7 state: skip route comparison for writes that leave routes alone
Reuse immutable route inputs when classifying NodeStore writes.
Only derive routes when an announcement or approval changes.
2026-10-28 14:37:37 +00:00
Kristoffer Dalby 04cbb8549d state, policy/v2: stop treating announced-only routes as policy changes
Policy evaluation reads only announced-and-approved routes.
Keep publishing Hostinfo updates without rebuilding peer adjacency.
2026-10-28 14:37:30 +00:00
Kristoffer Dalby 6b99ca0ad1 policy/v2, state: elect primaries by oldest control session
A router that reconnects joins as a standby; one that kept its session
takes its routes back once available again, as on Tailscale. Both the
global and the via election use it, in place of anti-flap stickiness.
2026-10-28 14:37:29 +00:00
Kristoffer Dalby afac928e2e types: add when a node's run of control sessions began 2026-10-28 14:37:28 +00:00
Kristoffer Dalby 97d4310caa state: keep a prefix mapped when no router is available
Peers keep the routes of an offline or expired router, as on Tailscale.
The previous primary keeps the prefix, else the lowest-ID approver;
never one the prober declared unreachable.
2026-10-28 14:37:27 +00:00
Kristoffer Dalby 111ed512fb policy/v2, state: elect via primaries among online, healthy routers
Availability tests expiry itself, not only the online flag.
A health change on a via target now triggers a peer recompute.
2026-10-28 14:37:26 +00:00
Kristoffer Dalby 67b88fe3b2 state: withhold HA probe results only for routers tied to a deferred one 2026-10-28 14:37:25 +00:00
Kristoffer Dalby 95b44713c1 state: keep probing a lone advertiser while it is unhealthy 2026-10-28 14:37:24 +00:00
Kristoffer Dalby 37cf9fdb12 hscontrol, types: strip trailing slashes from server_url 2026-10-28 14:37:23 +00:00
Kristoffer Dalby f9e533060c db: bound the wait for a legacy hash verification slot 2026-10-28 14:37:22 +00:00
Kristoffer Dalby 8a6b22dfe9 db: reload the credential row after a legacy hash verification 2026-10-28 14:37:22 +00:00
Kristoffer Dalby 4c074d312b db: disable GORM's prepared statement cache on SQLite
database.gorm.prepare_stmt is now ignored, with a startup warning.
2026-10-28 14:37:21 +00:00
Kristoffer Dalby b7e061f09c policy/v2: refuse check SSH rules with tag sources
A check asks the source's user to log in again, and a tagged node has
none. Tailscale SaaS refuses the rule; headscale accepted it.
2026-10-28 14:37:20 +00:00
Kristoffer Dalby 10a4daf544 policy/v2: limit the destination and port pairs a policy declares
A grant lists dst and ip apart, so its filter grows with their product.
Refuse a policy over 100,000 pairs, on every parse.
2026-10-28 14:37:19 +00:00
Kristoffer Dalby 0556d3f76b policy/v2: refuse a port list in a grant ip entry
Tailscale SaaS takes one port range per ip entry; a list was accepted
and expanded. Write each range as an entry of its own.
2026-10-28 14:37:18 +00:00
Kristoffer Dalby f311c75836 policy/v2: evaluate policy tests before taking the write lock
SetPolicy ran the policy's tests under the lock every map response and
node write needs. Run them on a snapshot of users and nodes first.
2026-10-28 14:37:18 +00:00
Kristoffer Dalby d249ec70b3 policy/v2: index compiled SSH rules by source for sshTests
Each check scanned every rule and parsed every principal per login name,
destination and source address. Compile once per run, key each
destination's rules by principal address, and evaluate a name once.
2026-10-28 14:37:17 +00:00
Kristoffer Dalby 5a2f3c6ad3 policy/v2: parse the compiled filter once per tests run
The tests evaluator parsed every SrcIPs and DstPorts entry again for
each assertion, source prefix and rule. Parse the filter once per run.
2026-10-28 14:37:16 +00:00
Kristoffer Dalby 8ebe643826 policy/v2: need every dst node for a tests accept, no range sources
An accept passes only when each node behind the dst is reached, as on
Tailscale SaaS; a deny keeps its rule. A CIDR, "*" or autogroup:tagged
src names no user or host, so its test fails.
2026-10-28 14:37:15 +00:00
Kristoffer Dalby 54257c9231 policy/v2: label sshTests failures with the dst alias
The report goes back to the policy author: name src and dst as written,
one line per dst occurrence, and a dst with no node as not reached.
2026-10-28 14:37:14 +00:00
Kristoffer Dalby f85060946a policy/v2: bound the tests and sshTests failure report
The report printed every failure with the full labels, so its size was
labels times failures. Print 100 lines of 256-byte labels, then a count.
2026-10-28 14:37:13 +00:00
Kristoffer Dalby ea2f9c5bf4 policy/v2: refuse autogroup:member as an sshTests destination
Tailscale SaaS refuses it when parsing; headscale evaluated it.
2026-10-28 14:37:13 +00:00
Kristoffer Dalby 94c410e1db policy/v2: refuse address ranges as sshTests sources
A CIDR, or a hosts entry holding one, as an sshTests src is refused,
as on Tailscale SaaS. Destinations share the range check.
2026-10-28 14:37:12 +00:00
Kristoffer Dalby 7ef3d56a50 policy/v2: map login 0 to no local user in SSH rules
Every rule that maps root now carries "0": "", as Tailscale SaaS writes
it, also when the policy lists "0".
2026-10-28 14:37:11 +00:00
Kristoffer Dalby 98c2e56794 policy/v2: write an ACL's repeated destination once
An ACL that names a destination and port twice wrote the pair twice.
Grants keep their repeats, as on Tailscale SaaS.
2026-10-28 14:37:10 +00:00
Kristoffer Dalby 6f30e2ddbe policy/v2: write a single-address via destination bare
Via rules wrote every destination with its prefix bits; ACL and grant
rules already drop them for a single address. Both use one formatter.
2026-10-28 14:37:09 +00:00
Kristoffer Dalby 524ccc46aa db: keep only the current policy
Every write inserted a row and nothing deleted one, while every reader
takes only the newest. Writers store and install under one lock, so an
uncommitted insert cannot outlive the newer row that pruned the rest.
2026-10-28 14:37:08 +00:00