Kristoffer Dalby
214c761fda
api/v2: stop echoing request values in error responses
...
huma sets an unexpected property's value to the whole request object.
A refused policy, or another 400, now carries its reason in message,
and a failed test run one data entry per failing test naming its src.
2026-10-28 07:15:55 +00:00
Kristoffer Dalby
9424501e31
api/v2: bound every request body
...
huma gives RawBody no limit, and validates a whole body before
the handler runs. The token form is parsed before the secret check.
2026-10-28 07:15:55 +00:00
Kristoffer Dalby
698d013ad0
api/v2: keep a tagged all-scope client's tokens inside its tags
...
Only an untagged all-scope client may mint tokens for any tag, so a
tagged token may not create one.
2026-10-28 07:15:55 +00:00
Kristoffer Dalby
bbe1ad6e25
debug: refuse requests addressed to unknown host names
2026-10-28 07:15:55 +00:00
Kristoffer Dalby
a0031cea03
types: accept only lowercase hex in auth IDs
2026-10-28 07:15:55 +00:00
Kristoffer Dalby
698c8cd2d0
oidc: show requested tags on the registration confirmation page
2026-10-28 07:15:55 +00:00
Kristoffer Dalby
ed18b33e00
oidc: show on the confirmation page whether the device is registered
2026-10-28 07:15:55 +00:00
Kristoffer Dalby
7e43ff529a
oidc: approve SSH checks on the confirmation page, not in the callback
...
Require an explicit click before recording the SSH verdict.
Recheck source ownership on the callback, confirmation page, and POST.
2026-10-28 07:15:55 +00:00
Kristoffer Dalby
463b060a90
policy/v2: match no user for a bare "@" token
2026-10-28 07:15:55 +00:00
Kristoffer Dalby
e2fd68e48e
policy/v2: match no one for an ambiguous user outside policy writes
...
A change to user identifiers must not block startup or later logins.
Keep policy writes strict; log ambiguous references on load and refresh.
2026-10-28 07:15:55 +00:00
Kristoffer Dalby
769015779f
policy/v2: prefer the user owning an email over a username match
2026-10-28 07:15:55 +00:00
Kristoffer Dalby
b558031804
policy/v2: check grant and nodeAttrs user references on write
...
Validation now refuses every input that reached the SetPolicy compile
failure, so restoring the previous policy there is defensive only.
2026-10-28 07:15:55 +00:00
Kristoffer Dalby
bed34995a7
cli: validate offline policy set like policy check
2026-10-28 07:15:55 +00:00
Kristoffer Dalby
1d06c0b566
types: reject non-boolean values for boolean settings
2026-10-28 07:15:55 +00:00
Kristoffer Dalby
6e892eeed6
oidc: send the change from the user update in the callback
2026-10-28 07:15:55 +00:00
Kristoffer Dalby
0f822aa1bb
state: refresh the NodeStore copies of a user in UpdateUser
2026-10-28 07:15:55 +00:00
Kristoffer Dalby
b86f0042bb
types: drop a stored OIDC email the login no longer vouches for
2026-10-28 07:15:55 +00:00
Kristoffer Dalby
2075fc8838
state: write every user column in UpdateUser
2026-10-28 07:15:55 +00:00
Kristoffer Dalby
372d3ba6d9
oidc: refuse logins whose subject the provider identifier would alter
2026-10-28 07:15:55 +00:00
Kristoffer Dalby
04a15d59e1
oidc: keep email_verified with the address it came with
2026-10-28 07:15:55 +00:00
Kristoffer Dalby
1dbcf982c8
state: announce a node online only after it was offline
...
A stream back within the reconnect grace sent peers an online patch,
a router's sent every node a policy response, and a relogin on
unchanged keys sent a key patch; nothing had changed.
2026-10-28 07:15:55 +00:00
Kristoffer Dalby
b394cc16b8
change: do not echo a node's own report back to it
...
An endpoint or DERP report came back to the node as a self update;
SaaS sends it to the node's peers only.
2026-10-28 07:15:55 +00:00
Kristoffer Dalby
491951533f
mapper: add device_id to the NextDNS query
...
SaaS sends the node's stable ID with the other device metadata.
2026-10-28 07:15:55 +00:00
Kristoffer Dalby
2b45a32248
policy/v2: warn once at load about malformed nextdns attrs
...
SaaS loads them and its resolver skips them, as headscale does, but the
mapper also logged a warning per node on every DNS build.
2026-10-28 07:15:55 +00:00
Kristoffer Dalby
39ab36a2f8
mapper: test that a hidden peer's policy change still sends filters
2026-10-28 07:15:55 +00:00
Kristoffer Dalby
3f30945056
state, change: send a deleted node's removal only to its peers
...
The removal went to every node, also those the policy hid the node from.
The delete now returns the node's peers from the snapshot it replaces.
2026-10-28 07:15:55 +00:00
Kristoffer Dalby
e5055eb34b
mapper: stop an older initial map removing peers newer streams hold
...
AddNode diffed its map against tracking after sending it, when a newer
stream may have recorded its own; it now sends the node a full instead.
2026-10-28 07:15:55 +00:00
Kristoffer Dalby
77017327fa
mapper: bound how long one node can block a batcher worker
...
A node that drained slower than it was sent to held the worker for its
whole bundle; once its sends have waited 50ms, the rest waits a tick.
2026-10-28 07:15:55 +00:00
Kristoffer Dalby
feeece29ae
mapper: send nothing while any stream awaits its initial map
...
Sent to the ready streams alone, a change counted as delivered and
never reached the new stream; the worker retries it once the map is out.
2026-10-28 07:15:55 +00:00
Kristoffer Dalby
b12f7dfdf4
mapper: cap concurrent map sessions per node
...
A node chose how many map streams it held, each pinning a session.
The fifth replaces the oldest; same shape as #3468 's mapper commit.
2026-10-28 07:15:55 +00:00
Kristoffer Dalby
ccf2250331
change: coalesce policy recomputes that carry an origin node
...
The recompute render ignores the origin and always carries the node's
own entry, so a burst of tag writes cost every node one per write.
2026-10-28 07:15:55 +00:00
Kristoffer Dalby
6a06960ece
state: say a taken name is already taken
2026-10-28 07:15:55 +00:00
Kristoffer Dalby
1b810dea31
db: succeed on a repeated revoke of an auth key
...
A repeated v2 DELETE of an auth key now answers 200, as Tailscale does.
2026-10-28 07:15:54 +00:00
Kristoffer Dalby
0a64d7a7bd
auth: answer a logout that deletes an ephemeral node as authorised
2026-10-28 07:15:54 +00:00
Kristoffer Dalby
8bae4d00c2
cli: show a node's own ephemeral flag instead of its key's
2026-10-28 07:15:54 +00:00
Kristoffer Dalby
13a4de4d95
gen/client/v1: regenerate for the node ephemeral flag
2026-10-28 07:15:54 +00:00
Kristoffer Dalby
5ddc442ec3
db, state: keep the ephemeral flag a node was created with
...
The flag moves from the key to the node, so a login with another key no
longer changes it. A user claiming a tagged node still clears it. v1
nodes carry the flag.
2026-10-28 07:15:54 +00:00
Kristoffer Dalby
e747f01b49
db, types: add a nodes column for the ephemeral flag
...
The migration fills it from the key each node references.
2026-10-28 07:15:54 +00:00
Kristoffer Dalby
3b842dc8a9
db: remove unused RenameNode
2026-10-28 07:15:54 +00:00
Kristoffer Dalby
3d85f5838f
state: bump duplicate node names loaded from the database
2026-10-28 07:15:54 +00:00
Kristoffer Dalby
fda89650da
state: cut a label so its -N suffix fits in 63 bytes
2026-10-28 07:15:54 +00:00
Kristoffer Dalby
df58b6d134
state: treat extra DNS record names as taken node names
2026-10-28 07:15:54 +00:00
Kristoffer Dalby
784b8b1618
state: save the name NodeStore picks for a new node
...
The row is committed before the name UPDATE, so a failed UPDATE still
returns the node and registration arms ephemeral cleanup.
2026-10-28 07:15:54 +00:00
Kristoffer Dalby
01322ea9e0
db, api/v1: revoke rather than delete an ephemeral pre-auth key in use
...
The v1 list now hides revoked keys, so keys revoked through v2 also drop
out of `headscale preauthkeys list`.
2026-10-28 07:15:54 +00:00
Kristoffer Dalby
1f462b53f6
hscontrol: arm the ephemeral GC at pre-auth key registration
2026-10-28 07:15:54 +00:00
Kristoffer Dalby
f1d50a1968
hscontrol: skip garbage collecting a node that is no longer ephemeral
2026-10-28 07:15:54 +00:00
Kristoffer Dalby
c4b1dc0134
db: wrap the sequential IP allocator so freed addresses are reused
2026-10-28 07:15:54 +00:00
Kristoffer Dalby
a318083a84
state: test that a persist racing a delete cannot resurrect the node
...
DeleteNode's early persistMu unlock is safe only while node persists
stay UPDATE-only; say so where the lock is declared.
2026-10-28 07:15:54 +00:00
Kristoffer Dalby
ca05853e43
db, state: let only the delete that removed a node free its addresses
2026-10-28 07:15:54 +00:00
Kristoffer Dalby
e588cf8304
state: drop registration locks once unused
...
The lock is taken before any credential check, so client-chosen machine
keys grew the map forever. Ref-count entries; delete at zero.
2026-10-28 07:15:54 +00:00