public/headscale
1
0 Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-11-04 12:39:25 +09:00
Code Issues Packages Projects Releases Wiki Activity
4,793 Commits 106 Branches 177 Tags
2bb2dc1a4784cbb32bf43b86c2a453da227a028c
Commit Graph
4793 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Kristoffer Dalby 2bb2dc1a47 servertest: join replayed routers with their routes 
A route update sent after the join could be overtaken by the stream's
first request and dropped; the probe joined with the routes set.
 2026-10-27 21:30:36 +00:00
Kristoffer Dalby f1a1a8eb8e servertest, hscontrol: add ephemeral, expiry, pending login golden data 
Ephemeral devices through logout, deletes, re-auth and collection;
expired routers and nodes, a client's own expiry and logout; a login
waiting across restarts, replayed exchange by exchange.
 2026-10-27 21:30:36 +00:00
Kristoffer Dalby d0fe3563cb servertest: add login flag, endpoint, disco rotation and expiry helpers 
WithLoginFlags and WithEndpoints shape what a client sends; RotateDisco
logs in again on a new disco key and leaves an auth URL waiting;
SetExpirySooner asks for an earlier key expiry.
 2026-10-27 21:30:36 +00:00
Kristoffer Dalby cc65dbd8db hscontrol, servertest: add v2 OAuth and policy API golden data 
OAuth clients, tokens, keys and tag writes by principal, and policy
writes over a baseline, replayed through v1 and v2; a deleted parent
client's key joins real clients.
 2026-10-27 21:30:36 +00:00
Kristoffer Dalby 2686253df7 servertest, policy/v2: add re-authentication golden data 
Expired, live, ephemeral and admin-tagged devices logging in again with
spent, revoked, valid and other users' keys, by key and by login;
tag ownership through tags per policy function.
 2026-10-27 21:30:36 +00:00
Kristoffer Dalby 6ced7950df servertest: add login, profile, restart and register log helpers 
TryNewClient returns a refused login; Login covers profile switches and
interactive logins approved through ApproveAuth; RegisterAttempts reads
the client's register log.
 2026-10-27 21:30:36 +00:00
Kristoffer Dalby 1076706198 servertest: add route approval lifecycle golden data 
Owner changes, re-auth, revokes, policy pushes, withdraw and logout
replayed step by step against SaaS approvals and served routes.
 2026-10-27 21:30:36 +00:00
Kristoffer Dalby 68883ead0b prek: exempt step captures from the large file check 
They keep a netmap per node per step and must stay as recorded.
 2026-10-27 21:30:36 +00:00
Kristoffer Dalby c4c1fc0048 servertest: add relogin and auth key helpers 
Relogin builds a new Direct on the same machine key and persisted
node key, as tailscaled does on up --auth-key; force rotates the key.
 2026-10-27 21:30:36 +00:00
Kristoffer Dalby 4c354f0c61 policy/v2, servertest: add via port captures 
A port-limited ACL entry beside a via grant, and a via tag with no
advertiser. Via HA replays now compare router filters by address.
 2026-10-27 21:30:36 +00:00
Kristoffer Dalby 0a2689ae3f policy/v2, servertest: add multi-route router captures 
A seven-route router and an exit node under six policies; replayed
through policy, peer map and map stream. Peer map now checked against
SaaS peers.
 2026-10-27 21:30:36 +00:00
Kristoffer Dalby 076281e909 policy/v2, servertest, hscontrol: add tailnet overlap route captures 
Routers announcing tailnet addresses, approved by policy, admin key and
devices:routes token; replayed through policy, map stream and v1/v2
APIs.
 2026-10-27 21:30:36 +00:00
Kristoffer Dalby 31e7105008 policy/v2, mapper: add nextdns attr captures 
SaaS accepts malformed nextdns profiles and keeps them in the CapMap;
its resolver skips them. DoH addresses compare per node: path, query,
ID.
 2026-10-27 21:30:36 +00:00
Kristoffer Dalby 1d4bd1d453 policy/v2: add user token captures 
SaaS answers for unknown users, a short name and a bare "@" at every
site. Each capture also runs under headscale-only user rows, at boot and
runtime; SaaS nodes must not change and overlay nodes get nothing.
 2026-10-27 21:30:36 +00:00
Kristoffer Dalby 49899da5ac policy/v2, servertest: add via source loss captures 
Repeated via destinations, a user via source, and an empty one.
A rename that empties the via source must reach open streams as v67.
 2026-10-27 21:30:36 +00:00
Kristoffer Dalby e03665990e policy/v2, servertest: add validation matrix and grant shape captures 
SaaS answers for sshTests sources, tests semantics, failure reports,
duplicate destinations, empty and allow-all policies, and refusals.
ACL and SSH compat checks are keyed per check; differences listed.
 2026-10-27 21:30:36 +00:00
Kristoffer Dalby 13c79cf508 policy/v2: recapture tester rows with failure detail 
Re-runs keep SaaS's error data and validate answer. Tester compat checks
verdict, message, failure breakdown and node labels.
 2026-10-27 21:30:35 +00:00
Kristoffer Dalby 43a6034304 servertest: check refused policies leave the live policy unchanged 
Posts every policy SaaS refused through v2; filter, SSH, body and ETag
must stay as before. Policies headscale accepts are skip entries.
 2026-10-27 21:30:35 +00:00
Kristoffer Dalby d8a31890e0 servertest: compare router self routes with captures 
Replays ten routes captures through the mapper too; SaaS's address
ranges for "*" now resolve. Known gaps are skip entries per node.
 2026-10-27 14:15:01 +00:00
Kristoffer Dalby e6df6eb9a9 servertest: compare user profiles in via captures 
Self and peer profiles, by login and display name. A tagged self gets
its own profile in SaaS; listed as a skip entry until headscale matches.
 2026-10-27 14:15:01 +00:00
Kristoffer Dalby 8db053c978 policy/v2: build tester nodes from the capture topology 
The fixed node list had other addresses than the captures, so address
and range tests ran against nodes SaaS never saw.
 2026-10-27 14:15:01 +00:00
Kristoffer Dalby f1a3f39df6 servertest: list passing via captures 
Fourteen committed via captures already match at map level; run them.
 2026-10-27 14:15:01 +00:00
Kristoffer Dalby 412303dd29 policy/v2: compare compat captures through the policy manager 
ACL, grant and SSH captures now also check FilterForNode and SSHPolicy,
which add the global merge and caches the per-node compile skips.
 2026-10-27 14:15:01 +00:00
Kristoffer Dalby d11b876ea1 testcapture: record multi-step captures and API error detail 
Optional Steps, NodeIDs, error data and login state; v1 files unchanged.
Register log and raw map frame parsers; Write refuses auth keys and
login URLs.
 2026-10-27 14:15:01 +00:00
Kristoffer Dalby 2d220b2eb8 mkdocs: set the current release to 0.29.6 2026-10-24 15:43:39 +02:00
Kristoffer Dalby f3fc915b71 CHANGELOG: set the 0.29.6 release date 2026-10-24 15:43:39 +02:00
Kristoffer Dalby 33544f62cb CHANGELOG: document the 0.29.6 security and patch release 
Updates #3579 and #3549.
 2026-10-24 11:15:20 +02:00
Kristoffer Dalby 30ff8df93c integration: ignore disconnected recipients when checking map state 
Disconnected streams retain historical maps and cannot receive peer updates.
 2026-10-23 18:23:53 +02:00
Kristoffer Dalby e195ce9675 CHANGELOG: map session and churn fixes 2026-10-23 18:23:53 +02:00
Kristoffer Dalby eed5c8c80a mapper: count folded patches when bounding pending 
A fold keeps every patch it merges, so counting changes hid the
backlog: the cap never fired and each fold recopied the patches.
 2026-10-23 18:23:53 +02:00
Kristoffer Dalby daad12e964 mapper: retry slow sessions from current state 
A full session channel after the send window evicted live but busy clients.
Requeue and regenerate; evict after no progress for connectionStallTimeout.
Retire blocked reconnect siblings once the newest stream accepts the frame.

Updates #3129.
 2026-10-23 18:23:53 +02:00
Kristoffer Dalby f46ea3d1df mapper: skip responses left empty by visibility filtering 
A peer change hidden from a recipient still produced a frame carrying only
ControlTime, one per sender per recipient. Drop it once the response is final.
 2026-10-23 18:23:53 +02:00
Kristoffer Dalby 2047ef35b8 hscontrol: wait for map session cleanup during shutdown 
Batcher shutdown cuts reconnect grace short to keep shutdown prompt.
Wait for each session's Disconnect to persist LastSeen before the database closes.
 2026-10-23 18:23:53 +02:00
Kristoffer Dalby cd62031b98 state: stop the auth cache TTL sweeper on Close 
The expirable LRU ran its sweeper forever, one goroutine per State. Purge
first so pending waiters get ErrRegistrationExpired instead of hanging.
The OIDC state cache is closed at server shutdown for the same reason.
 2026-10-23 18:23:53 +02:00
Kristoffer Dalby 5f39a68b39 go.mod: pin golang-lru/v2 to main for expirable.Close 
v2.0.7 is the last tag; the TTL sweeper got Close only on main.
 2026-10-23 18:23:53 +02:00
Kristoffer Dalby 2905dbfe86 ci: run race tests through a flake check 2026-10-23 18:23:53 +02:00
Kristoffer Dalby 51b420865e state: own request memory before storing nodes 
A reused RegisterRequest.Hostinfo was written and stored while NodeStore readers cloned it.
 2026-10-23 18:23:53 +02:00
Kristoffer Dalby 6d9fc8ac34 AGENTS, README, flake: drop unused golines 
.golangci.yaml never enabled golines and lll is off; Go formatting is
gofumpt, gci and goimports. Remove golines from the dev shell too.
 2026-10-23 18:23:53 +02:00
Kristoffer Dalby 8a7921ae45 mapper: fold a node's pending backlog while its bundle is in flight 
Behind workers, pending grew by every change until the next drain; under
ci-churn that held ~900 MB of queued changes.
 2026-10-23 18:23:53 +02:00
Kristoffer Dalby 73dd39982b poll: let a stopped session's write in flight finish 
Expiring the deadline at once still reset streams whose last write
was in flight; a grace keeps the bound on clients that stopped reading.
 2026-10-23 18:23:53 +02:00
Kristoffer Dalby 552356a2ee state: skip the caller's policy refresh once the writer applied it 
The writer refreshes the policy manager before publishing its batch, so
the caller's SetNodes with the published snapshot recompiled it back.
 2026-10-23 18:23:53 +02:00
Kristoffer Dalby a5d5e8384a change: fold a tick's node deletions into one removal 
Under delete churn each removal still rendered its own frame and split
the coalesced peer runs.
 2026-10-23 18:23:53 +02:00
Kristoffer Dalby dd6e288aa1 policy/v2: index nodes by tag once per compile 
Each tag alias scanned every node, so with many tags a compile, run on
every NodeStore batch, was mostly HasTag.
 2026-10-23 18:23:53 +02:00
Kristoffer Dalby 7a2335dc2b mapper: render each tick's peer deltas as one response 
One frame per change let a join storm overflow the session channel in a
single tick, and the batcher then dropped live clients as stale.
 2026-10-23 18:23:53 +02:00
Kristoffer Dalby 4933bb83d2 policyutil: match DstPorts as ranges when reducing filters 
Every node re-parsed every entry into an IPSet on every policy change;
under churn that was most of the batcher's CPU.
 2026-10-23 18:23:53 +02:00
Kristoffer Dalby fb015933ca mapper: drop pending changes for nodes without a connection 
Disconnected nodes keep their batcher entry, and every broadcast was
rendered for them only for send to discard it.
 2026-10-23 18:23:53 +02:00
Kristoffer Dalby 5d21186f22 state: release persistMu before the NodeStore delete 
Holding it serialised concurrent deletes into one NodeStore batch and
peer map build each, capping deletion at one batch tick per node.
 2026-10-23 18:23:53 +02:00
Kristoffer Dalby 371674de95 poll: expire the write deadline only for a write in flight 
An expired deadline resets the HTTP/2 stream with INTERNAL_ERROR, so
every batcher stop (delete, logout) looked like a server error.
 2026-10-23 18:23:53 +02:00
Kristoffer Dalby 1b184cd2c7 hscontrol: cancel ephemeral GC timer when a node is deleted 
API and logout deletes left the disconnect timer armed; it fired later
and logged a bogus ERR for the missing node.
 2026-10-23 18:23:53 +02:00
Michael LopezandClaude Fable 5.1 494e2a6808 db: quote postgres connection parameters (#3477) 
* db: quote postgres connection parameters

The DSN was built by string concatenation, so a password containing a
space, quote or backslash truncated it or injected extra parameters.
Build it with libpq keyword/value quoting and keep the password out of
the startup log line.

* db: mark the DSN test fixture password as not a credential

gosec G101 flags the literal assigned to Pass in TestBuildPostgresDSN.
The value exists to exercise quoting of spaces, quotes and backslashes
and is not a secret.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* types, db: build the postgres DSN as a URL from PostgresConfig

Review feedback: move the DSN construction onto types.PostgresConfig as
DSN(), so the database layer calls cfg.Postgres.DSN() and logs
redacted.DSN(), and build it as a postgres:// URL with net/url instead
of hand-rolled libpq quoting. Unix socket directories travel as the
host query parameter; bare IPv6 literals are bracketed. Tests parse the
URL back and check each component rather than the encoded string.

* types: silence gosec on the whole DSN test fixtures

gosec reports G101 on the composite literal that holds a Pass value, not
on the Pass line itself, so the previous nolint did not cover it. Place
the directive before each fixture element.

* db: drop imports left unused by the merge with main

The merge of main reintroduced the slices and strconv imports in db.go,
but the postgres DSN is now built by PostgresConfig.DSN and nothing in
the file uses them, so the package failed to compile and every CI check
failed on typecheck.

Also link the CHANGELOG entry to the PR.

* db: restore tests and formatting lost in the rebase onto main

Resolving the rebase conflicts in db_test.go kept this branch's side and
dropped the credential tests main had added, including the
requireCredentialConstraints helper another test still calls, so the db
test package no longer compiled. Restore the file from main; this branch
does not change it.

The resolution also indented the package clause in db.go and removed the
blank line between the standard library and module imports.

---------

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
 2026-10-22 22:36:04 +02:00