Kristoffer Dalby
3719b4db0d
policy, state: log only the routes auto-approval adds
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
bcc951ec54
poll: hold the map session's node as a view
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
05a5c11a20
policy/matcher, types: compare a node's routes to matchers as ranges
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
926998d553
policy/matcher: binary-search ranges in overlap checks
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
3c62eb17bb
policy: look up approved routes in a set when auto-approving
...
Avoid scanning the growing approval list for every announcement.
Use the sorted current routes when identifying additions.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
5314508846
types, state: reduce a node's routes against the matchers once
...
Reuse matcher membership and approved subnets across the route list.
Preserve route order and HA co-router visibility.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
9093e0108b
types: derive subnet and exit routes in one pass
...
Emit each approved route once, in announcement order.
Skip derivation when no routes are approved.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
2dc2dfc8cd
state: skip route comparison for writes that leave routes alone
...
Reuse immutable route inputs when classifying NodeStore writes.
Only derive routes when an announcement or approval changes.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
8735976f26
state, policy/v2: stop treating announced-only routes as policy changes
...
Policy evaluation reads only announced-and-approved routes.
Keep publishing Hostinfo updates without rebuilding peer adjacency.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
2377e060f2
policy/v2, state: elect primaries by oldest control session
...
A router that reconnects joins as a standby; one that kept its session
takes its routes back once available again, as on Tailscale. Both the
global and the via election use it, in place of anti-flap stickiness.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
41dc97401b
types: add when a node's run of control sessions began
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
160302e920
state: keep a prefix mapped when no router is available
...
Peers keep the routes of an offline or expired router, as on Tailscale.
The previous primary keeps the prefix, else the lowest-ID approver;
never one the prober declared unreachable.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
af6babc4fa
policy/v2, state: elect via primaries among online, healthy routers
...
Availability tests expiry itself, not only the online flag.
A health change on a via target now triggers a peer recompute.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
a1ab489eb2
state: withhold HA probe results only for routers tied to a deferred one
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
8571c2e989
state: keep probing a lone advertiser while it is unhealthy
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
2c265e1300
hscontrol, types: strip trailing slashes from server_url
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
08f600f045
db: bound the wait for a legacy hash verification slot
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
8c7d5e5551
db: reload the credential row after a legacy hash verification
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
3b2553755b
db: disable GORM's prepared statement cache on SQLite
...
database.gorm.prepare_stmt is now ignored, with a startup warning.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
f39d1b8928
policy/v2: refuse check SSH rules with tag sources
...
A check asks the source's user to log in again, and a tagged node has
none. Tailscale SaaS refuses the rule; headscale accepted it.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
7fa696a690
policy/v2: limit the destination and port pairs a policy declares
...
A grant lists dst and ip apart, so its filter grows with their product.
Refuse a policy over 100,000 pairs, on every parse.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
cae4033813
policy/v2: refuse a port list in a grant ip entry
...
Tailscale SaaS takes one port range per ip entry; a list was accepted
and expanded. Write each range as an entry of its own.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
649e864819
policy/v2: evaluate policy tests before taking the write lock
...
SetPolicy ran the policy's tests under the lock every map response and
node write needs. Run them on a snapshot of users and nodes first.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
39f928e6d8
policy/v2: index compiled SSH rules by source for sshTests
...
Each check scanned every rule and parsed every principal per login name,
destination and source address. Compile once per run, key each
destination's rules by principal address, and evaluate a name once.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
19dc9873d1
policy/v2: parse the compiled filter once per tests run
...
The tests evaluator parsed every SrcIPs and DstPorts entry again for
each assertion, source prefix and rule. Parse the filter once per run.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
58c1ccf86c
policy/v2: need every dst node for a tests accept, no range sources
...
An accept passes only when each node behind the dst is reached, as on
Tailscale SaaS; a deny keeps its rule. A CIDR, "*" or autogroup:tagged
src names no user or host, so its test fails.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
ad1d2bef2f
policy/v2: label sshTests failures with the dst alias
...
The report goes back to the policy author: name src and dst as written,
one line per dst occurrence, and a dst with no node as not reached.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
19d8960f10
policy/v2: bound the tests and sshTests failure report
...
The report printed every failure with the full labels, so its size was
labels times failures. Print 100 lines of 256-byte labels, then a count.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
5a316e83d0
policy/v2: refuse autogroup:member as an sshTests destination
...
Tailscale SaaS refuses it when parsing; headscale evaluated it.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
63ccb1dad7
policy/v2: refuse address ranges as sshTests sources
...
A CIDR, or a hosts entry holding one, as an sshTests src is refused,
as on Tailscale SaaS. Destinations share the range check.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
7a5f548ec3
policy/v2: map login 0 to no local user in SSH rules
...
Every rule that maps root now carries "0": "", as Tailscale SaaS writes
it, also when the policy lists "0".
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
9e79b08fa6
policy/v2: write an ACL's repeated destination once
...
An ACL that names a destination and port twice wrote the pair twice.
Grants keep their repeats, as on Tailscale SaaS.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
0708870b6c
policy/v2: write a single-address via destination bare
...
Via rules wrote every destination with its prefix bits; ACL and grant
rules already drop them for a single address. Both use one formatter.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
c4bf1cb46f
db: keep only the current policy
...
Every write inserted a row and nothing deleted one, while every reader
takes only the newest. Writers store and install under one lock, so an
uncommitted insert cannot outlive the newer row that pruned the rest.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
7123c4b593
state: install a written policy only after it is stored
...
Writers validated by installing the policy live, so a store failure
left a refused or unstored policy enforced. Validate on a throwaway
manager, store, then reload from the stored row.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
f3b2d6b798
policy/v2: refuse an empty policy
...
SetPolicy returned a nil error for empty input it ignored, so the v1
API stored it as valid. Reload skips only the nil "no policy" case.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
8dee772bea
policy/v2: resolve tag owners one hop deep
...
A user claims only the tags it owns directly, and a tag owns only the
tags that list it, as on Tailscale SaaS. With no walk left, validate
names an undefined owner once, with the tag that lists it.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
23014255b2
policy/v2: evaluate sshTests sources through the nodes they cover
...
A src was expanded to every address it names, so "*" or ::/0 never
finished. Principals are node addresses: keep those plus one stand-in.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
b6edf6f0cf
policy/v2: resolve each group once per policy compile
...
Group.resolve walked users and nodes for every member at every mention.
Resolve all groups once on a copy of the policy and compile from it.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
80a9a9084b
policy/v2: compile SSH rules once and share them across nodes
...
SSHPolicy re-resolved every rule and built private principals per node.
Compile the rules once per policy, users and nodes; per node, only
select.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
65006bff41
policy/v2: merge rules sharing a source slice without rejoining it
...
The rules of one ACL now share one SrcIPs slice; key it once instead of
joining it again for every rule, globally and per node.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
eb9c14b5f2
policy/v2: treat an ACL as one grant in ViaRoutesForPeer
...
Ports never steer routes, and one grant per destination
matched the sources once per destination.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
0aff3656e2
policy/v2: bound via route steering by the peer's routes
...
Include and Exclude held one entry per overlapping dst, and the election
walked them per dst. Keep one entry per route; a peer without routes
returns at once.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
60f0b20d76
policy/v2: refresh clients when a user change drops the last via grant
...
SetUsers read needsPerNodeFilter after the recompile cleared it, so
the change was reported as empty and clients kept the via rules.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
60991f3d01
state: serialise policy reloads
...
Load and install the stored policy as one step, so an older
reload cannot install its document over a newer one.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
82ffc3d313
integration: keep HA cable-pull routers off each other's routes
...
A router holding the other's route for its docker subnet in table 52
cannot be reattached: docker resolves the gateway through tailscale0.
Replaces the phase 4a wait that covered one case of it.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
8967c7e91c
mapper: count only the batcher's goroutines in lifecycle tests
...
runtime.NumGoroutine deltas moved when goroutines left by earlier
tests exited mid-test. Label the batcher's goroutines and count those.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
4106bc816c
policy/v2: recapture SSH data captures
...
Every ssh_results row captured again from SaaS. SaaS now maps login "0"
to no local user in rules that map root, quotes a refused checkPeriod as
written and rewords its tailnet-domain refusal.
2026-10-30 14:55:35 +00:00
Kristoffer Dalby
d41d1cc718
hscontrol, servertest: add key list scope golden data
...
Read-only and key-making OAuth tokens of each tag set list auth keys
with and without all=true, over admin- and token-made keys of every tag
relation, one admin key made after the token-made ones.
2026-10-30 14:55:35 +00:00
Kristoffer Dalby
9746de8e4b
servertest: add user role dispatch golden data
...
An admin role change under autogroup:admin, mirrored as a user rename;
peers, filter and frames per node per step, and v2 device users.
2026-10-30 14:55:35 +00:00